Avoids NOTREACHED() in VideoFrame created by ::CreateVideoHoleFrame() [chromium/src : main]

2 views

Skip to first unread message

Dongheun Kang (Gerrit)

unread,

Apr 25, 2024, 1:26:59 AM4/25/24

to Dongheun Kang, Guohui Deng, AyeAye, chromium...@chromium.org, xhwang...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org

Attention needed from Guohui Deng

Dongheun Kang added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dongheun Kang . resolved

Dear Guohui Deng

In the webos environment, VideoHoleFrame is also used in webrtc. When the frame is delivered to WebMediaPlayerMS, the NOTREACHED() log is continuously output by media::BitDepth().
I wanted to get rid of this, so I created a patch. However, there are changes as mojo-related modifications are also needed.
Would it be better to simply remove handling of the PIXEL_FORMAT_UNKNOWN type in media::BitDepth()?

Open in Gerrit

Related details

Attention is currently required from:

Guohui Deng

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dongheun Kang (Gerrit)

unread,

Jul 7, 2025, 8:16:29 PM7/7/25

to Dongheun Kang, Rijubrata Bhaumik, Guohui Deng, AyeAye, chromium...@chromium.org, chfreme...@chromium.org, mfoltz...@chromium.org, jophba...@chromium.org, xhwang...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org

Dongheun Kang abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages