Revert "Reland "Remove callback_helpers.h include from is_callback.h"" [chromium/src : main]
0 views
Skip to first unread message
Marijn Kruisselbrink (Gerrit)
Dec 5, 2025, 8:00:27 PM (2 days ago) Dec 5
to Marijn Kruisselbrink, Rubber Stamper, Lei Zhang, Chromium LUCI CQ, Daniel Cheng, AyeAye, chromium...@chromium.org, storage...@chromium.org, feature-me...@chromium.org, edgesto...@microsoft.com, cc-...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, dmurph+watching...@chromium.org
Attention needed from Daniel Cheng and Lei Zhang
Marijn Kruisselbrink voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Dec 5, 2025, 8:01:15 PM (2 days ago) Dec 5
to Marijn Kruisselbrink, Lei Zhang, Chromium LUCI CQ, Daniel Cheng, AyeAye, chromium...@chromium.org, storage...@chromium.org, feature-me...@chromium.org, edgesto...@microsoft.com, cc-...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, dmurph+watching...@chromium.org
Attention needed from Daniel Cheng and Lei Zhang
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel Cheng
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Dec 5, 2025, 8:02:16 PM (2 days ago) Dec 5
to Marijn Kruisselbrink, Lei Zhang, Chromium LUCI CQ, Daniel Cheng, AyeAye, chromium...@chromium.org, storage...@chromium.org, feature-me...@chromium.org, edgesto...@microsoft.com, cc-...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, dmurph+watching...@chromium.org
Attention needed from Daniel Cheng, Lei Zhang and Marijn Kruisselbrink
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel Cheng
- Lei Zhang
- Marijn Kruisselbrink
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 5, 2025, 8:05:27 PM (2 days ago) Dec 5
to Marijn Kruisselbrink, Rubber Stamper, Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, storage...@chromium.org, feature-me...@chromium.org, edgesto...@microsoft.com, cc-...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, dmurph+watching...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Reland "Remove callback_helpers.h include from is_callback.h""
This reverts commit 9bd2be2d8d0c435542afc2e59f128b8e9ef23496.
Reason for revert: Causing compile failures on https://ci.chromium.org/ui/p/chromium/builders/ci/ios-device/459082
Original change's description:
> Reland "Remove callback_helpers.h include from is_callback.h"
>
> This is a reland of commit fab09e07f02d2033bd32ea32758d0f41e8312f51
>
> Added more missing includes to fix the Linux CFM bot.
>
> Original change's description:
> > Remove callback_helpers.h include from is_callback.h
> >
> > This temporary include existed to help safely land the CL that added
> > is_callback.h. Now that is_callback.h is in the code base, remove this
> > crutch.
> >
> > Change-Id: I2b457b73e799ee7226c5476cdcc9c48d9c8c3e3d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224760
> > Commit-Queue: Daniel Cheng <dch...@chromium.org>
> > Commit-Queue: Lei Zhang <the...@chromium.org>
> > Owners-Override: Daniel Cheng <dch...@chromium.org>
> > Reviewed-by: Daniel Cheng <dch...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1554466}
>
> Change-Id: Ib117b0e6f46c5593b677fbca15d242c9c5e1cadf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7230701
> Owners-Override: Daniel Cheng <dch...@chromium.org>
> Reviewed-by: Daniel Cheng <dch...@chromium.org>
> Commit-Queue: Lei Zhang <the...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1554999}
NOTRY=true
NOTREECHECKS=true
Change-Id: I7fae6d4be6e70d60793b4b1ab6f5469ddcffb8fa
Auto-Submit: Marijn Kruisselbrink <m...@chromium.org>
Owners-Override: Marijn Kruisselbrink <m...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1555007}
Files:
- M base/functional/is_callback.h
- M chrome/browser/ash/chromebox_for_meetings/artemis/local_data_source_unittest.cc
- M chrome/browser/ash/chromebox_for_meetings/artemis/log_source_unittest.cc
- M chrome/browser/ash/chromebox_for_meetings/artemis/test_data_aggregator_service.cc
- M chromecast/cast_core/runtime/browser/message_port_handler.cc
- M chromecast/media/audio/cast_audio_manager_android.cc
- M components/services/storage/dom_storage/session_storage_namespace_impl.cc
- M components/viz/service/transitions/transferable_resource_tracker_unittest.cc
Change size: S
Delta: 8 files changed, 4 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Dec 5, 2025, 8:41:57 PM (2 days ago) Dec 5
to Chromium LUCI CQ, Marijn Kruisselbrink, Rubber Stamper, Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, storage...@chromium.org, feature-me...@chromium.org, edgesto...@microsoft.com, cc-...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, dmurph+watching...@chromium.org
Lei Zhang added 1 comment![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ณรงค์กร ชูวงษ์วาน (menszgUDoker) (Gerrit)
Dec 6, 2025, 11:56:20 PM (1 hour ago) Dec 6
to Chromium LUCI CQ, Marijn Kruisselbrink, Rubber Stamper, Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, storage...@chromium.org, feature-me...@chromium.org, edgesto...@microsoft.com, cc-...@chromium.org, halliwe...@chromium.org, dmurph+watch...@chromium.org, dmurph+watching...@chromium.org
ณรงค์กร ชูวงษ์วาน (menszgUDoker) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
ณรงค์กร ชูวงษ์วาน (menszgUDoker) . resolved
7226613: Enable AvoidTrustedparamsCopies by default | https://chromium-review.googlesource.com/c/chromium/src/+/7226613
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages