| Code-Review | +1 |
I didn't review the details, but mostly of the CL is removing code so assume it's safe.
Thanks you so much for the cleanup!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +1 |
Hi all, I was looking through overlay processing code on the Viz side and noticed we have some more remnants of MF frame server mode that we can clean up. I reverted the original change (patchset 1) and locally resolved the conflicts (patchset 2+).
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hi all, I was looking through overlay processing code on the Viz side and noticed we have some more remnants of MF frame server mode that we can clean up. I reverted the original change (patchset 1) and locally resolved the conflicts (patchset 2+).
Thanks for catching this!
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Hi @xhw...@chromium.org and @sun...@chromium.org can you please take a look? Thank you!
Hi @sun...@chromium.org, gentle ping in case this was buried while you were out! Thank you!
Hi @sun...@chromium.org, gentle ping on this again. I can also find another reviewer, if needed. Thank you!
| Code-Review | +1 |
lgtm % question
class MediaFoundationRendererClientTestq: are these tests now obsolete?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +1 |
class MediaFoundationRendererClientTestq: are these tests now obsolete?
I don't believe this offers meaningful covereage in its current state. We have one integration test covering MF (`Pixel_MediaFoundationClearDirectComposition`), which is also a minimal smoke test that covers MF initialization. We can re-add this test if we want to add coverage in the future?
FYI @cham...@microsoft.com @Piet.S...@microsoft.com in case either of you have objections.
LGTM
class MediaFoundationRendererClientTestMichael Tangq: are these tests now obsolete?
I don't believe this offers meaningful covereage in its current state. We have one integration test covering MF (`Pixel_MediaFoundationClearDirectComposition`), which is also a minimal smoke test that covers MF initialization. We can re-add this test if we want to add coverage in the future?
FYI @cham...@microsoft.com @Piet.S...@microsoft.com in case either of you have objections.
In theory we could have unittests for the remaining dcomp support, but agreed we could re-add this file when we add those tests instead of keeping the file around not really testing anything (and giving false sense of test coverage).
| Commit-Queue | +2 |
Thank you all!
class MediaFoundationRendererClientTestMichael Tangq: are these tests now obsolete?
Nic WilliamsonI don't believe this offers meaningful covereage in its current state. We have one integration test covering MF (`Pixel_MediaFoundationClearDirectComposition`), which is also a minimal smoke test that covers MF initialization. We can re-add this test if we want to add coverage in the future?
FYI @cham...@microsoft.com @Piet.S...@microsoft.com in case either of you have objections.
In theory we could have unittests for the remaining dcomp support, but agreed we could re-add this file when we add those tests instead of keeping the file around not really testing anything (and giving false sense of test coverage).
Revert "MF Frame Server Mode: Part 5: Promotion Hint Service"
This reverts commit a28a7b4f4d86192a04281fc6f952c38d0eede0bd.
Reason for revert: Frame server mode has been removed and the promotion
hint service was only used by frame server mode.
This also reverts leftover changes from crrev.com/c/4629747.
Patchset 2+ contains merge conflict resolutions.
Original change's description:
> MF Frame Server Mode: Part 5: Promotion Hint Service
>
> This change introduces the underpinnings for an Overlay State Service
> on Windows. This service will live in the GPU process where it will
> track the overlay state of opted in textures.
>
> In the initial implementation the DC Overlay Processor provides state
> information during texture processing, a future update will likely
> also incorporate state information like video capture.
>
> The service is exposed to renderer clients via GPU channel and the
> service allows the client to subscribe for notifications based on the
> mailbox of the associated texture.
>
> A basic promotion state service & aggregator are introduced to track
> observers & current state. A future update will likely introduce
> additional logic into the aggregator to help minimize IPC.
>
> Bug: 1258887
> Change-Id: I1b69155079bce6f4d22e1e33626ceadc0c2aa325
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3403933
> Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
> Reviewed-by: Sunny Sachanandani <sun...@chromium.org>
> Reviewed-by: Daniel Cheng <dch...@chromium.org>
> Commit-Queue: William Carr <wic...@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#995427}
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |