Revert "MF Frame Server Mode: Part 5: Promotion Hint Service" [chromium/src : main]

0 views
Skip to first unread message

Xiaohan Wang (Gerrit)

unread,
Dec 11, 2025, 6:39:44 PM12/11/25
to Michael Tang, Rubber Stamper, Rijubrata Bhaumik, AyeAye, Rafael Cintron, David Springgay, Chromium LUCI CQ, Frank Li, William Carr, Daniel Cheng, chromium...@chromium.org, Dale Curtis, Tricium, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
Attention needed from Michael Tang

Xiaohan Wang voted and added 1 comment

Votes added by Xiaohan Wang

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Xiaohan Wang . resolved

I didn't review the details, but mostly of the CL is removing code so assume it's safe.

Thanks you so much for the cleanup!

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Tang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I538d4f39721842cc23149d7cb20acce153890113
Gerrit-Change-Number: 7254326
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Tang <ta...@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: David Springgay <dasp...@microsoft.com>
Gerrit-Reviewer: Frank Li <fra...@microsoft.com>
Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Sunny Sachanandani <sun...@chromium.org>
Gerrit-Reviewer: William Carr <wic...@microsoft.com>
Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-CC: Frank Liberato <libe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Michael Tang <ta...@microsoft.com>
Gerrit-Comment-Date: Thu, 11 Dec 2025 23:39:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Dec 11, 2025, 6:40:21 PM12/11/25
to Michael Tang, Rijubrata Bhaumik, AyeAye, Rafael Cintron, David Springgay, Chromium LUCI CQ, Frank Li, William Carr, Daniel Cheng, chromium...@chromium.org, Dale Curtis, Tricium, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
Attention needed from Michael Tang

Message from Rubber Stamper

The change is not in the configured time window. Rubber Stamper is only allowed to review reverts within 14 day(s). Learn more: go/rubber-stamper-user-guide.

Gerrit-Comment-Date: Thu, 11 Dec 2025 23:40:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Tang (Gerrit)

unread,
Dec 11, 2025, 7:12:46 PM12/11/25
to Rijubrata Bhaumik, AyeAye, Rafael Cintron, David Springgay, Sunny Sachanandani, Chromium LUCI CQ, Frank Li, William Carr, Daniel Cheng, chromium...@chromium.org, Dale Curtis, Tricium, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
Attention needed from Sunny Sachanandani and Xiaohan Wang

Michael Tang voted and added 1 comment

Votes added by Michael Tang

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4:
Michael Tang . resolved

Hi all, I was looking through overlay processing code on the Viz side and noticed we have some more remnants of MF frame server mode that we can clean up. I reverted the original change (patchset 1) and locally resolved the conflicts (patchset 2+).

Open in Gerrit

Related details

Attention is currently required from:
  • Sunny Sachanandani
  • Xiaohan Wang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I538d4f39721842cc23149d7cb20acce153890113
    Gerrit-Change-Number: 7254326
    Gerrit-PatchSet: 4
    Gerrit-Owner: Michael Tang <ta...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Springgay <dasp...@microsoft.com>
    Gerrit-Reviewer: Frank Li <fra...@microsoft.com>
    Gerrit-Reviewer: Michael Tang <ta...@microsoft.com>
    Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
    Gerrit-Reviewer: Sunny Sachanandani <sun...@chromium.org>
    Gerrit-Reviewer: William Carr <wic...@microsoft.com>
    Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-CC: Dale Curtis <dalec...@chromium.org>
    Gerrit-CC: Frank Liberato <libe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
    Gerrit-Attention: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-Comment-Date: Fri, 12 Dec 2025 00:12:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Dec 11, 2025, 7:35:54 PM12/11/25
    to Michael Tang, Daniel Cheng, Rijubrata Bhaumik, AyeAye, Rafael Cintron, David Springgay, Sunny Sachanandani, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, Tricium, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
    Attention needed from Michael Tang, Sunny Sachanandani and Xiaohan Wang

    Daniel Cheng voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Tang
    • Sunny Sachanandani
    • Xiaohan Wang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I538d4f39721842cc23149d7cb20acce153890113
      Gerrit-Change-Number: 7254326
      Gerrit-PatchSet: 5
      Gerrit-Owner: Michael Tang <ta...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: David Springgay <dasp...@microsoft.com>
      Gerrit-Reviewer: Frank Li <fra...@microsoft.com>
      Gerrit-Reviewer: Michael Tang <ta...@microsoft.com>
      Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
      Gerrit-Reviewer: Sunny Sachanandani <sun...@chromium.org>
      Gerrit-Reviewer: William Carr <wic...@microsoft.com>
      Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
      Gerrit-CC: Dale Curtis <dalec...@chromium.org>
      Gerrit-CC: Frank Liberato <libe...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
      Gerrit-Attention: Xiaohan Wang <xhw...@chromium.org>
      Gerrit-Attention: Michael Tang <ta...@microsoft.com>
      Gerrit-Comment-Date: Fri, 12 Dec 2025 00:35:42 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dale Curtis (Gerrit)

      unread,
      Dec 11, 2025, 7:40:05 PM12/11/25
      to Michael Tang, Daniel Cheng, Rijubrata Bhaumik, AyeAye, Rafael Cintron, David Springgay, Sunny Sachanandani, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Tricium, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Michael Tang, Sunny Sachanandani and Xiaohan Wang

      Dale Curtis added 1 comment

      Patchset-level comments
      Michael Tang . resolved

      Hi all, I was looking through overlay processing code on the Viz side and noticed we have some more remnants of MF frame server mode that we can clean up. I reverted the original change (patchset 1) and locally resolved the conflicts (patchset 2+).

      Dale Curtis

      Thanks for catching this!

      Gerrit-Comment-Date: Fri, 12 Dec 2025 00:39:55 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Michael Tang <ta...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Tang (Gerrit)

      unread,
      Dec 15, 2025, 11:54:37 AM12/15/25
      to Daniel Cheng, Rijubrata Bhaumik, AyeAye, Rafael Cintron, David Springgay, Sunny Sachanandani, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, Tricium, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Sunny Sachanandani and Xiaohan Wang

      Michael Tang voted and added 1 comment

      Votes added by Michael Tang

      Auto-Submit+1
      Commit-Queue+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 5 (Latest):
      Michael Tang . resolved

      Hi @xhw...@chromium.org and @sun...@chromium.org can you please take a look? Thank you!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sunny Sachanandani
      • Xiaohan Wang
      Gerrit-Comment-Date: Mon, 15 Dec 2025 16:54:26 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Xiaohan Wang (Gerrit)

      unread,
      Dec 16, 2025, 3:13:33 AM12/16/25
      to Michael Tang, Daniel Cheng, Rijubrata Bhaumik, AyeAye, Rafael Cintron, David Springgay, Sunny Sachanandani, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, Tricium, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Michael Tang and Sunny Sachanandani

      Xiaohan Wang voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Tang
      • Sunny Sachanandani
      Gerrit-Attention: Michael Tang <ta...@microsoft.com>
      Gerrit-Comment-Date: Tue, 16 Dec 2025 08:13:22 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rafael Cintron (Gerrit)

      unread,
      Dec 17, 2025, 2:45:44 PM12/17/25
      to Michael Tang, Daniel Cheng, Rijubrata Bhaumik, AyeAye, David Springgay, Sunny Sachanandani, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, Tricium, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Michael Tang and Sunny Sachanandani

      Rafael Cintron voted

      Code-Review+1
      Commit-Queue+2
      Gerrit-Comment-Date: Wed, 17 Dec 2025 19:45:29 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Tang (Gerrit)

      unread,
      Jan 5, 2026, 6:05:56 PMJan 5
      to Rafael Cintron, Daniel Cheng, Rijubrata Bhaumik, AyeAye, David Springgay, Sunny Sachanandani, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Sunny Sachanandani

      Michael Tang added 1 comment

      Patchset-level comments
      Michael Tang . resolved

      Hi @sun...@chromium.org, gentle ping in case this was buried while you were out! Thank you!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sunny Sachanandani
      Gerrit-CC: Deleted User
      Gerrit-CC: Frank Liberato <libe...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
      Gerrit-Comment-Date: Mon, 05 Jan 2026 23:05:46 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Tang (Gerrit)

      unread,
      Jan 14, 2026, 1:32:46 PM (7 days ago) Jan 14
      to Rafael Cintron, Daniel Cheng, Rijubrata Bhaumik, AyeAye, David Springgay, Sunny Sachanandani, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Sunny Sachanandani

      Michael Tang added 1 comment

      Patchset-level comments
      Michael Tang . resolved

      Hi @sun...@chromium.org, gentle ping on this again. I can also find another reviewer, if needed. Thank you!

      Gerrit-Comment-Date: Wed, 14 Jan 2026 18:32:25 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sunny Sachanandani (Gerrit)

      unread,
      Jan 20, 2026, 4:33:56 PM (10 hours ago) Jan 20
      to Michael Tang, Rafael Cintron, Daniel Cheng, Rijubrata Bhaumik, AyeAye, David Springgay, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Michael Tang

      Sunny Sachanandani voted and added 2 comments

      Votes added by Sunny Sachanandani

      Code-Review+1

      2 comments

      Patchset-level comments
      Sunny Sachanandani . resolved

      lgtm % question

      File media/mojo/clients/win/media_foundation_renderer_client_unittest.cc
      Line 149, Patchset 5 (Parent):class MediaFoundationRendererClientTest
      Sunny Sachanandani . unresolved

      q: are these tests now obsolete?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Tang
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I538d4f39721842cc23149d7cb20acce153890113
      Gerrit-Change-Number: 7254326
      Gerrit-PatchSet: 5
      Gerrit-Owner: Michael Tang <ta...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: David Springgay <dasp...@microsoft.com>
      Gerrit-Reviewer: Frank Li <fra...@microsoft.com>
      Gerrit-Reviewer: Michael Tang <ta...@microsoft.com>
      Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
      Gerrit-Reviewer: Sunny Sachanandani <sun...@chromium.org>
      Gerrit-Reviewer: William Carr <wic...@microsoft.com>
      Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
      Gerrit-CC: Dale Curtis <dalec...@chromium.org>
      Gerrit-CC: Frank Liberato <libe...@chromium.org>
      Gerrit-CC: Name of user not set #1242319
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-Attention: Michael Tang <ta...@microsoft.com>
      Gerrit-Comment-Date: Tue, 20 Jan 2026 21:33:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Tang (Gerrit)

      unread,
      Jan 20, 2026, 6:46:06 PM (7 hours ago) Jan 20
      to Nic Williamson, Piet Schouten, Sunny Sachanandani, Rafael Cintron, Daniel Cheng, Rijubrata Bhaumik, AyeAye, David Springgay, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Michael Tang, Nic Williamson, Piet Schouten and Sunny Sachanandani

      Michael Tang voted and added 1 comment

      Votes added by Michael Tang

      Commit-Queue+1

      1 comment

      File media/mojo/clients/win/media_foundation_renderer_client_unittest.cc
      Line 149, Patchset 5 (Parent):class MediaFoundationRendererClientTest
      Sunny Sachanandani . unresolved

      q: are these tests now obsolete?

      Michael Tang

      I don't believe this offers meaningful covereage in its current state. We have one integration test covering MF (`Pixel_MediaFoundationClearDirectComposition`), which is also a minimal smoke test that covers MF initialization. We can re-add this test if we want to add coverage in the future?

      FYI @cham...@microsoft.com @Piet.S...@microsoft.com in case either of you have objections.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Tang
      • Nic Williamson
      • Piet Schouten
      • Sunny Sachanandani
      Gerrit-CC: Nic Williamson <cham...@microsoft.com>
      Gerrit-CC: Piet Schouten <Piet.S...@microsoft.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
      Gerrit-Attention: Piet Schouten <Piet.S...@microsoft.com>
      Gerrit-Attention: Michael Tang <ta...@microsoft.com>
      Gerrit-Attention: Nic Williamson <cham...@microsoft.com>
      Gerrit-Comment-Date: Tue, 20 Jan 2026 23:45:54 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Sunny Sachanandani <sun...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nic Williamson (Gerrit)

      unread,
      Jan 20, 2026, 7:24:27 PM (7 hours ago) Jan 20
      to Michael Tang, Piet Schouten, Sunny Sachanandani, Rafael Cintron, Daniel Cheng, Rijubrata Bhaumik, AyeAye, David Springgay, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Michael Tang, Piet Schouten and Sunny Sachanandani

      Nic Williamson added 2 comments

      Patchset-level comments
      Nic Williamson . resolved

      LGTM

      File media/mojo/clients/win/media_foundation_renderer_client_unittest.cc
      Line 149, Patchset 5 (Parent):class MediaFoundationRendererClientTest
      Sunny Sachanandani . unresolved

      q: are these tests now obsolete?

      Michael Tang

      I don't believe this offers meaningful covereage in its current state. We have one integration test covering MF (`Pixel_MediaFoundationClearDirectComposition`), which is also a minimal smoke test that covers MF initialization. We can re-add this test if we want to add coverage in the future?

      FYI @cham...@microsoft.com @Piet.S...@microsoft.com in case either of you have objections.

      Nic Williamson

      In theory we could have unittests for the remaining dcomp support, but agreed we could re-add this file when we add those tests instead of keeping the file around not really testing anything (and giving false sense of test coverage).

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Tang
      • Piet Schouten
      • Sunny Sachanandani
      Gerrit-Comment-Date: Wed, 21 Jan 2026 00:24:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Sunny Sachanandani <sun...@chromium.org>
      Comment-In-Reply-To: Michael Tang <ta...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Tang (Gerrit)

      unread,
      Jan 20, 2026, 8:16:28 PM (6 hours ago) Jan 20
      to Nic Williamson, Piet Schouten, Sunny Sachanandani, Rafael Cintron, Daniel Cheng, Rijubrata Bhaumik, AyeAye, David Springgay, Chromium LUCI CQ, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org
      Attention needed from Nic Williamson, Piet Schouten and Sunny Sachanandani

      Michael Tang voted and added 2 comments

      Votes added by Michael Tang

      Commit-Queue+2

      2 comments

      Patchset-level comments
      Michael Tang . resolved

      Thank you all!

      File media/mojo/clients/win/media_foundation_renderer_client_unittest.cc
      Line 149, Patchset 5 (Parent):class MediaFoundationRendererClientTest
      Sunny Sachanandani . resolved

      q: are these tests now obsolete?

      Michael Tang

      I don't believe this offers meaningful covereage in its current state. We have one integration test covering MF (`Pixel_MediaFoundationClearDirectComposition`), which is also a minimal smoke test that covers MF initialization. We can re-add this test if we want to add coverage in the future?

      FYI @cham...@microsoft.com @Piet.S...@microsoft.com in case either of you have objections.

      Nic Williamson

      In theory we could have unittests for the remaining dcomp support, but agreed we could re-add this file when we add those tests instead of keeping the file around not really testing anything (and giving false sense of test coverage).

      Michael Tang

      Done

      I can re-add in a follow-up if needed.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nic Williamson
      • Piet Schouten
      • Sunny Sachanandani
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Gerrit-Attention: Nic Williamson <cham...@microsoft.com>
        Gerrit-Comment-Date: Wed, 21 Jan 2026 01:16:13 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Sunny Sachanandani <sun...@chromium.org>
        Comment-In-Reply-To: Michael Tang <ta...@microsoft.com>
        Comment-In-Reply-To: Nic Williamson <cham...@microsoft.com>
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jan 20, 2026, 8:57:18 PM (5 hours ago) Jan 20
        to Michael Tang, Nic Williamson, Piet Schouten, Sunny Sachanandani, Rafael Cintron, Daniel Cheng, Rijubrata Bhaumik, AyeAye, David Springgay, Frank Li, William Carr, chromium...@chromium.org, Dale Curtis, mfoltz...@chromium.org, media-cro...@chromium.org, chfreme...@chromium.org, xhwang...@chromium.org, droger+w...@chromium.org, poscia...@chromium.org, jophba...@chromium.org, feature-me...@chromium.org, penghu...@chromium.org, cc-...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Revert "MF Frame Server Mode: Part 5: Promotion Hint Service"

        This reverts commit a28a7b4f4d86192a04281fc6f952c38d0eede0bd.

        Reason for revert: Frame server mode has been removed and the promotion
        hint service was only used by frame server mode.

        This also reverts leftover changes from crrev.com/c/4629747.

        Patchset 2+ contains merge conflict resolutions.

        Original change's description:
        > MF Frame Server Mode: Part 5: Promotion Hint Service
        >
        > This change introduces the underpinnings for an Overlay State Service
        > on Windows. This service will live in the GPU process where it will
        > track the overlay state of opted in textures.
        >
        > In the initial implementation the DC Overlay Processor provides state
        > information during texture processing, a future update will likely
        > also incorporate state information like video capture.
        >
        > The service is exposed to renderer clients via GPU channel and the
        > service allows the client to subscribe for notifications based on the
        > mailbox of the associated texture.
        >
        > A basic promotion state service & aggregator are introduced to track
        > observers & current state. A future update will likely introduce
        > additional logic into the aggregator to help minimize IPC.
        >
        > Bug: 1258887
        > Change-Id: I1b69155079bce6f4d22e1e33626ceadc0c2aa325
        > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3403933
        > Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
        > Reviewed-by: Sunny Sachanandani <sun...@chromium.org>
        > Reviewed-by: Daniel Cheng <dch...@chromium.org>
        > Commit-Queue: William Carr <wic...@microsoft.com>
        > Cr-Commit-Position: refs/heads/main@{#995427}
        Bug: 1258887
        Change-Id: I538d4f39721842cc23149d7cb20acce153890113
        Commit-Queue: Michael Tang <ta...@microsoft.com>
        Reviewed-by: Rafael Cintron <rafael....@microsoft.com>
        Reviewed-by: Daniel Cheng <dch...@chromium.org>
        Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
        Reviewed-by: Sunny Sachanandani <sun...@chromium.org>
        Auto-Submit: Michael Tang <ta...@microsoft.com>
        Cr-Commit-Position: refs/heads/main@{#1572007}
        Files:
        • M components/viz/common/BUILD.gn
        • D components/viz/common/overlay_state/win/DEPS
        • D components/viz/common/overlay_state/win/overlay_state_aggregator.cc
        • D components/viz/common/overlay_state/win/overlay_state_aggregator.h
        • D components/viz/common/overlay_state/win/overlay_state_service.cc
        • D components/viz/common/overlay_state/win/overlay_state_service.h
        • D components/viz/common/overlay_state/win/overlay_state_service_unittest.cc
        • M components/viz/service/display/dc_layer_overlay.cc
        • M components/viz/service/display/dc_layer_overlay.h
        • M components/viz/service/display/display_resource_provider.cc
        • M components/viz/service/display/display_resource_provider.h
        • M components/viz/service/display/overlay_processor_win.cc
        • M components/viz/service/gl/DEPS
        • M components/viz/service/gl/gpu_service_impl.cc
        • M content/renderer/BUILD.gn
        • M content/renderer/media/media_factory.cc
        • M content/renderer/media/win/dcomp_texture_wrapper_impl.cc
        • D content/renderer/media/win/overlay_state_observer_impl.cc
        • D content/renderer/media/win/overlay_state_observer_impl.h
        • D content/renderer/media/win/overlay_state_observer_impl_unittest.cc
        • D content/renderer/media/win/overlay_state_service_provider.cc
        • D content/renderer/media/win/overlay_state_service_provider.h
        • M content/renderer/render_thread_impl.cc
        • M content/renderer/render_thread_impl.h
        • M content/test/BUILD.gn
        • M gpu/ipc/common/gpu_channel.mojom
        • M gpu/ipc/common/mock_gpu_channel.h
        • M gpu/ipc/service/DEPS
        • M gpu/ipc/service/gpu_channel.cc
        • M gpu/ipc/service/gpu_channel.h
        • M media/base/BUILD.gn
        • M media/base/win/BUILD.gn
        • D media/base/win/DEPS
        • M media/base/win/dcomp_texture_wrapper.h
        • D media/base/win/overlay_state_observer_subscription.h
        • M media/gpu/DEPS
        • M media/mojo/clients/BUILD.gn
        • D media/mojo/clients/win/DEPS
        • M media/mojo/clients/win/media_foundation_renderer_client.cc
        • M media/mojo/clients/win/media_foundation_renderer_client.h
        • M media/mojo/clients/win/media_foundation_renderer_client_factory.cc
        • M media/mojo/clients/win/media_foundation_renderer_client_factory.h
        • D media/mojo/clients/win/media_foundation_renderer_client_unittest.cc
        Change size: XL
        Delta: 43 files changed, 10 insertions(+), 1356 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Rafael Cintron, +1 by Daniel Cheng, +1 by Sunny Sachanandani, +1 by Xiaohan Wang
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I538d4f39721842cc23149d7cb20acce153890113
        Gerrit-Change-Number: 7254326
        Gerrit-PatchSet: 6
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages