Post destruction of WebMediaPlayer [chromium/src : main]

0 views

Skip to first unread message

Frank Liberato (Gerrit)

unread,

Oct 10, 2025, 4:28:12 PM (9 hours ago) Oct 10

to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, kinuko...@chromium.org

Frank Liberato added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Frank Liberato . resolved

here's the basic idea. doesn't work yet.

-fl

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dale Curtis (Gerrit)

unread,

Oct 10, 2025, 4:53:15 PM (9 hours ago) Oct 10

to Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, kinuko...@chromium.org

Attention needed from Frank Liberato

Dale Curtis added 2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Dale Curtis . unresolved

I wonder if it doesn't work because some aspect of the WMP shutdown process leaves playback state hung for tests if the posted WMP deletion just gets dropped / leaked. If so we might need to do as dcheng@ suggests.

File third_party/blink/renderer/core/html/media/html_media_element.cc

Line 367, Patchset 1 (Latest):class MediaPlayerClientForwarder final : public blink::MediaPlayerClient {

Dale Curtis . unresolved

Seems like just as much boilerplate plus a new object to track versus just making client weak in WebMediaPlayerImpl/MS itself? I guess we don't have to write the same code for WMP MS and WMPI, but the if (weak) pattern isn't uncommon.

Open in Gerrit

Related details

Attention is currently required from:

Frank Liberato

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages