[iOS] Update unit tests to create TestSyncService/SyncServiceImpl [chromium/src : main]
0 views
Skip to first unread message
Marc Treib (Gerrit)
Jun 16, 2026, 5:35:12 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/authentication
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: Ia03f757972ce4114b78ca0fbe26ec91e7a4403c8
Change diff
Change information
Files:
- M ios/chrome/browser/authentication/account_menu/ui/BUILD.gn
- M ios/chrome/browser/authentication/account_menu/ui/account_menu_view_controller_unittest.mm
- M ios/chrome/browser/authentication/add_account_signin/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/add_account_signin/coordinator/add_account_signin_coordinator_unittest.mm
- M ios/chrome/browser/authentication/age_mismatch_signout/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/age_mismatch_signout/coordinator/signin_account_capabilities_scene_agent_unittest.mm
- M ios/chrome/browser/authentication/consistency_promo_signin/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_coordinator_unittest.mm
- M ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_mediator_unittest.mm
- M ios/chrome/browser/authentication/signin/fullscreen_promo/model/BUILD.gn
- M ios/chrome/browser/authentication/signin/fullscreen_promo/model/fullscreen_signin_promo_scene_agent_unittest.mm
- M ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/non_modal_signin_promo_mediator_unittest.mm
- M ios/chrome/browser/authentication/trusted_vault_reauthentication/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/trusted_vault_reauthentication/coordinator/trusted_vault_reauthentication_coordinator_unittest.mm
- M ios/chrome/browser/authentication/ui_bundled/authentication_flow/authentication_flow_in_profile_performer_unittest.mm
- M ios/chrome/browser/authentication/ui_bundled/authentication_flow/authentication_flow_in_profile_unittest.mm
- M ios/chrome/browser/authentication/ui_bundled/re_signin_infobar_delegate_unittest.mm
- M ios/chrome/browser/authentication/ui_bundled/signin/signin_utils_unittest.mm
Change size: M
Delta: 19 files changed, 106 insertions(+), 39 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 16, 2026, 5:35:48 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, thegreenf...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
['ios/chrome/browser/bookmarks', 'ios/chrome/browser/main', 'ios/chrome/browser/save_to_drive', 'ios/chrome/browser/intelligence', 'ios/chrome/browser/ntp', 'ios/chrome/browser/push_notification', 'ios/chrome/browser/safety_check', 'ios/chrome/browser/tabs_search', 'ios/chrome/browser/tips_notifications']
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I96c16fd06d9eb8405c9a75b59cd88b1ac38d82aa
Change diff
Change information
Files:
- M ios/chrome/browser/bookmarks/model/BUILD.gn
- M ios/chrome/browser/bookmarks/model/DEPS
- M ios/chrome/browser/bookmarks/model/bookmark_ios_unit_test_support.mm
- M ios/chrome/browser/intelligence/page_action_menu/coordinator/BUILD.gn
- M ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_mediator_unittest.mm
- M ios/chrome/browser/main/ui_bundled/BUILD.gn
- M ios/chrome/browser/main/ui_bundled/browser_lifecycle_manager_unittest.mm
- M ios/chrome/browser/main/ui_bundled/default_browser_promo_scene_agent_unittest.mm
- M ios/chrome/browser/ntp/model/BUILD.gn
- M ios/chrome/browser/ntp/model/set_up_list_unittest.mm
- M ios/chrome/browser/push_notification/coordinator/BUILD.gn
- M ios/chrome/browser/push_notification/coordinator/notifications_opt_in_mediator_unittest.mm
- M ios/chrome/browser/safety_check/model/BUILD.gn
- M ios/chrome/browser/safety_check/model/ios_chrome_safety_check_manager_unittest.mm
- M ios/chrome/browser/save_to_drive/ui_bundled/BUILD.gn
- M ios/chrome/browser/save_to_drive/ui_bundled/save_to_drive_coordinator_unittest.mm
- M ios/chrome/browser/save_to_drive/ui_bundled/save_to_drive_mediator_unittest.mm
- M ios/chrome/browser/tabs_search/model/BUILD.gn
- M ios/chrome/browser/tabs_search/model/tabs_search_service_unittest.mm
- M ios/chrome/browser/tips_notifications/model/tips_notification_client_unittest.mm
Change size: M
Delta: 20 files changed, 78 insertions(+), 0 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 16, 2026, 5:36:33 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
['ios/chrome/browser/bring_android_tabs', 'ios/chrome/browser/lens_overlay', 'ios/chrome/browser/shared', 'ios/chrome/browser/content_suggestions', 'ios/chrome/browser/overlays', 'ios/chrome/browser/promos_manager', 'ios/chrome/browser/save_to_photos', 'ios/chrome/browser/tab_switcher']
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I963c0c004934786a6b2c1be2834d51d878cbc52f
Change diff
Change information
Files:
- M ios/chrome/browser/bring_android_tabs/ui_bundled/BUILD.gn
- M ios/chrome/browser/bring_android_tabs/ui_bundled/bring_android_tabs_prompt_mediator_unittest.mm
- M ios/chrome/browser/bring_android_tabs/ui_bundled/tab_list_from_android_mediator_unittest.mm
- M ios/chrome/browser/content_suggestions/price_tracking_promo/coordinator/BUILD.gn
- M ios/chrome/browser/content_suggestions/price_tracking_promo/coordinator/price_tracking_promo_mediator_unittest.mm
- M ios/chrome/browser/lens_overlay/coordinator/BUILD.gn
- M ios/chrome/browser/lens_overlay/coordinator/lens_overlay_coordinator_unittest.mm
- M ios/chrome/browser/lens_overlay/coordinator/lens_result_page_mediator_unittest.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/sync_error/BUILD.gn
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/sync_error/sync_error_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/promos_manager/coordinator/BUILD.gn
- M ios/chrome/browser/promos_manager/coordinator/promos_manager_coordinator_unittest.mm
- M ios/chrome/browser/save_to_photos/ui_bundled/BUILD.gn
- M ios/chrome/browser/save_to_photos/ui_bundled/save_to_photos_mediator_unittest.mm
- M ios/chrome/browser/shared/coordinator/scene/BUILD.gn
- M ios/chrome/browser/shared/coordinator/scene/scene_controller_unittest.mm
- M ios/chrome/browser/shared/coordinator/scene/task_updater_scene_agent_unittest.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/BUILD.gn
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_grid_coordinator_unittest.mm
Change size: M
Delta: 19 files changed, 75 insertions(+), 6 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 16, 2026, 5:37:26 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, christia...@chromium.org, eic+...@google.com, ios-revie...@chromium.org, xinghui...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
['ios/chrome/browser/browser_view', 'ios/chrome/browser/enterprise', 'ios/chrome/browser/account_picker', 'ios/chrome/browser/browsing_data', 'ios/chrome/browser/location_bar', 'ios/chrome/browser/post_restore_signin', 'ios/chrome/browser/safe_browsing', 'ios/chrome/browser/signin', 'ios/chrome/browser/welcome_back']
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: Id277e5d06ee26a93fd1680067482721cfb8181af
Change diff
Change information
Files:
- M ios/chrome/browser/account_picker/ui_bundled/BUILD.gn
- M ios/chrome/browser/account_picker/ui_bundled/account_picker_coordinator_unittest.mm
- M ios/chrome/browser/browser_view/ui_bundled/BUILD.gn
- M ios/chrome/browser/browser_view/ui_bundled/browser_view_controller_unittest.mm
- M ios/chrome/browser/browser_view/ui_bundled/key_commands_provider_unittest.mm
- M ios/chrome/browser/browsing_data/model/BUILD.gn
- M ios/chrome/browser/browsing_data/model/tabs_closure_util_unittest.mm
- M ios/chrome/browser/enterprise/model/idle/BUILD.gn
- M ios/chrome/browser/enterprise/model/idle/action_unittest.mm
- M ios/chrome/browser/enterprise/model/idle/idle_service_unittest.mm
- M ios/chrome/browser/location_bar/ui_bundled/BUILD.gn
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_coordinator_unittest.mm
- M ios/chrome/browser/post_restore_signin/ui_bundled/BUILD.gn
- M ios/chrome/browser/post_restore_signin/ui_bundled/post_restore_signin_provider_unittest.mm
- M ios/chrome/browser/safe_browsing/model/tailored_security/BUILD.gn
- M ios/chrome/browser/safe_browsing/model/tailored_security/tailored_security_tab_helper_unittest.mm
- M ios/chrome/browser/signin/model/account_consistency_browser_agent_unittest.mm
- M ios/chrome/browser/signin/model/authentication_service_observer_bridge_unittest.mm
- M ios/chrome/browser/welcome_back/coordinator/BUILD.gn
- M ios/chrome/browser/welcome_back/coordinator/welcome_back_mediator_unittest.mm
Change size: M
Delta: 20 files changed, 79 insertions(+), 0 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 16, 2026, 5:37:57 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/download
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I45baf398bee6688a7a5f8370705d0e8326b442b8
Change diff
Change information
Files:
- M ios/chrome/browser/download/coordinator/BUILD.gn
- M ios/chrome/browser/download/coordinator/download_manager_coordinator_unittest.mm
- M ios/chrome/browser/download/coordinator/download_manager_mediator_unittest.mm
- M ios/chrome/browser/download/model/BUILD.gn
- M ios/chrome/browser/download/model/document_download_tab_helper_unittest.mm
- M ios/chrome/browser/download/model/download_manager_tab_helper_unittest.mm
Change size: S
Delta: 6 files changed, 26 insertions(+), 1 deletion(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 16, 2026, 5:38:36 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, yuezhang...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, mdjone...@chromium.org, filesapp...@chromium.org, ayman...@chromium.org, marq+...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
['ios/chrome/browser/drive_file_picker', 'ios/chrome/browser/reader_mode', 'ios/chrome/browser/autofill', 'ios/chrome/browser/commerce', 'ios/chrome/browser/popup_menu', 'ios/chrome/browser/prerender', 'ios/chrome/browser/saved_tab_groups', 'ios/chrome/browser/synced_set_up']
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: Ia1cb2e2f6f278e7a365da98a7a498124c1ed6d15
Change diff
Change information
Files:
- M ios/chrome/browser/autofill/payments/coordinator/BUILD.gn
- M ios/chrome/browser/autofill/payments/coordinator/payments_suggestion_bottom_sheet_coordinator_unittest.mm
- M ios/chrome/browser/commerce/model/BUILD.gn
- M ios/chrome/browser/commerce/model/price_alert_util_unittest.mm
- M ios/chrome/browser/drive_file_picker/coordinator/BUILD.gn
- M ios/chrome/browser/drive_file_picker/coordinator/browse_drive_file_picker_coordinator_unittest.mm
- M ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_mediator_unittest.mm
- M ios/chrome/browser/drive_file_picker/coordinator/root_drive_file_picker_coordinator_unittest.mm
- M ios/chrome/browser/popup_menu/overflow_menu/coordinator/BUILD.gn
- M ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_mediator_unittest.mm
- M ios/chrome/browser/prerender/model/BUILD.gn
- M ios/chrome/browser/prerender/model/prerender_browser_agent_unittest.mm
- M ios/chrome/browser/reader_mode/model/BUILD.gn
- M ios/chrome/browser/reader_mode/model/reader_mode_tab_helper_unittest.mm
- M ios/chrome/browser/reader_mode/model/reader_mode_test.mm
- M ios/chrome/browser/saved_tab_groups/coordinator/BUILD.gn
- M ios/chrome/browser/saved_tab_groups/coordinator/face_pile_mediator_unittest.mm
- M ios/chrome/browser/synced_set_up/coordinator/BUILD.gn
- M ios/chrome/browser/synced_set_up/coordinator/synced_set_up_mediator_unittest.mm
Change size: M
Delta: 19 files changed, 78 insertions(+), 8 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 16, 2026, 5:40:54 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, thegreenf...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/ntp/ui_bundled
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I44ec0a388b07799f29d656bae11df01ce3a49990
Change diff
Change information
Files:
- M ios/chrome/browser/ntp/ui_bundled/BUILD.gn
- M ios/chrome/browser/ntp/ui_bundled/feed_top_section/BUILD.gn
- M ios/chrome/browser/ntp/ui_bundled/feed_top_section/feed_top_section_mediator_unittest.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_coordinator_unittest.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_mediator_unittest.mm
Change size: S
Delta: 5 files changed, 22 insertions(+), 0 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 16, 2026, 5:42:17 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/settings
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I724ef99252ffc5b1f83710156f5b6d58ff5ce2ec
Change diff
Change information
Files:
- M ios/chrome/browser/settings/clear_browsing_data/coordinator/BUILD.gn
- M ios/chrome/browser/settings/clear_browsing_data/coordinator/quick_delete_mediator_unittest.mm
- M ios/chrome/browser/settings/clear_browsing_data/quick_delete_other_data/coordinator/BUILD.gn
- M ios/chrome/browser/settings/clear_browsing_data/quick_delete_other_data/coordinator/quick_delete_other_data_mediator_unittest.mm
- M ios/chrome/browser/settings/manage_accounts/coordinator/BUILD.gn
- M ios/chrome/browser/settings/manage_accounts/coordinator/manage_accounts_mediator_unittest.mm
- M ios/chrome/browser/settings/manage_accounts/ui/BUILD.gn
- M ios/chrome/browser/settings/manage_accounts/ui/manage_accounts_table_view_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_profile_table_view_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/settings_navigation_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/sync/sync_encryption_table_view_controller_unittest.mm
Change size: M
Delta: 11 files changed, 52 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 16, 2026, 5:42:59 AM (13 days ago) Jun 16
to Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, ios-revie...@chromium.org, gcasto+w...@chromium.org, marq+...@chromium.org, Marc Treib
Attention needed from Rohit Rao
Marc Treib has uploaded the change for review![]( "Open in Gerrit")
Marc Treib would like Rohit Rao to review this change.
Commit message
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/settings/ui_bundled/password
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I9748ee7a2aec0cf2cae61c82ac277244b815ead0
Change diff
Change information
Files:
- M ios/chrome/browser/settings/ui_bundled/password/password_checkup/BUILD.gn
- M ios/chrome/browser/settings/ui_bundled/password/password_checkup/password_checkup_coordinator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_issues/password_issues_mediator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_manager_view_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_settings/BUILD.gn
- M ios/chrome/browser/settings/ui_bundled/password/password_settings/password_settings_coordinator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/BUILD.gn
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/sharing_status_mediator_unittest.mm
Change size: S
Delta: 8 files changed, 31 insertions(+), 0 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 17, 2026, 12:30:27 PM (12 days ago) Jun 17
to Marc Treib, Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 17, 2026, 12:32:41 PM (12 days ago) Jun 17
to Marc Treib, Rohit Rao, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 17, 2026, 12:35:40 PM (12 days ago) Jun 17
to Marc Treib, Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Marc Treib voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 17, 2026, 1:29:44 PM (12 days ago) Jun 17
to Marc Treib, Rohit Rao, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
['ios/chrome/browser/bookmarks', 'ios/chrome/browser/main', 'ios/chrome/browser/save_to_drive', 'ios/chrome/browser/intelligence', 'ios/chrome/browser/ntp', 'ios/chrome/browser/push_notification', 'ios/chrome/browser/safety_check', 'ios/chrome/browser/tabs_search', 'ios/chrome/browser/tips_notifications']
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I96c16fd06d9eb8405c9a75b59cd88b1ac38d82aa
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Auto-Submit: Marc Treib <tr...@chromium.org>
Commit-Queue: Rohit Rao <rohi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648421}
Files:
- M ios/chrome/browser/bookmarks/model/BUILD.gn
- M ios/chrome/browser/bookmarks/model/DEPS
- M ios/chrome/browser/bookmarks/model/bookmark_ios_unit_test_support.mm
- M ios/chrome/browser/intelligence/page_action_menu/coordinator/BUILD.gn
- M ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_mediator_unittest.mm
- M ios/chrome/browser/main/ui_bundled/BUILD.gn
- M ios/chrome/browser/main/ui_bundled/browser_lifecycle_manager_unittest.mm
- M ios/chrome/browser/main/ui_bundled/default_browser_promo_scene_agent_unittest.mm
- M ios/chrome/browser/ntp/model/BUILD.gn
- M ios/chrome/browser/ntp/model/set_up_list_unittest.mm
- M ios/chrome/browser/push_notification/coordinator/BUILD.gn
- M ios/chrome/browser/push_notification/coordinator/notifications_opt_in_mediator_unittest.mm
- M ios/chrome/browser/safety_check/model/BUILD.gn
- M ios/chrome/browser/safety_check/model/ios_chrome_safety_check_manager_unittest.mm
- M ios/chrome/browser/save_to_drive/ui_bundled/BUILD.gn
- M ios/chrome/browser/save_to_drive/ui_bundled/save_to_drive_coordinator_unittest.mm
- M ios/chrome/browser/save_to_drive/ui_bundled/save_to_drive_mediator_unittest.mm
- M ios/chrome/browser/tabs_search/model/BUILD.gn
- M ios/chrome/browser/tabs_search/model/tabs_search_service_unittest.mm
- M ios/chrome/browser/tips_notifications/model/tips_notification_client_unittest.mm
Change size: M
Delta: 20 files changed, 78 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Jun 17, 2026, 4:53:53 PM (12 days ago) Jun 17
to Marc Treib, Chromium LUCI CQ, Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Marc Treib voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 17, 2026, 5:33:11 PM (12 days ago) Jun 17
to Marc Treib, Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/authentication
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: Ia03f757972ce4114b78ca0fbe26ec91e7a4403c8
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Auto-Submit: Marc Treib <tr...@chromium.org>
Commit-Queue: Marc Treib <tr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648593}
Files:
- M ios/chrome/browser/authentication/account_menu/ui/BUILD.gn
- M ios/chrome/browser/authentication/account_menu/ui/account_menu_view_controller_unittest.mm
- M ios/chrome/browser/authentication/add_account_signin/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/add_account_signin/coordinator/add_account_signin_coordinator_unittest.mm
- M ios/chrome/browser/authentication/age_mismatch_signout/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/age_mismatch_signout/coordinator/signin_account_capabilities_scene_agent_unittest.mm
- M ios/chrome/browser/authentication/consistency_promo_signin/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_coordinator_unittest.mm
- M ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_mediator_unittest.mm
- M ios/chrome/browser/authentication/signin/fullscreen_promo/model/BUILD.gn
- M ios/chrome/browser/authentication/signin/fullscreen_promo/model/fullscreen_signin_promo_scene_agent_unittest.mm
- M ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/non_modal_signin_promo_mediator_unittest.mm
- M ios/chrome/browser/authentication/trusted_vault_reauthentication/coordinator/BUILD.gn
- M ios/chrome/browser/authentication/trusted_vault_reauthentication/coordinator/trusted_vault_reauthentication_coordinator_unittest.mm
- M ios/chrome/browser/authentication/ui_bundled/authentication_flow/authentication_flow_in_profile_performer_unittest.mm
- M ios/chrome/browser/authentication/ui_bundled/authentication_flow/authentication_flow_in_profile_unittest.mm
- M ios/chrome/browser/authentication/ui_bundled/re_signin_infobar_delegate_unittest.mm
- M ios/chrome/browser/authentication/ui_bundled/signin/signin_utils_unittest.mm
Change size: M
Delta: 19 files changed, 106 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 25, 2026, 8:39:02 AM (4 days ago) Jun 25
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted![]( "Open in Gerrit")
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 25, 2026, 9:37:01 AM (4 days ago) Jun 25
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/settings/ui_bundled/password
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I9748ee7a2aec0cf2cae61c82ac277244b815ead0
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Commit-Queue: Rohit Rao <rohi...@chromium.org>
Auto-Submit: Marc Treib <tr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652370}
Files:
- M ios/chrome/browser/settings/ui_bundled/password/password_checkup/BUILD.gn
- M ios/chrome/browser/settings/ui_bundled/password/password_checkup/password_checkup_coordinator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_issues/password_issues_mediator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_manager_view_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_settings/BUILD.gn
- M ios/chrome/browser/settings/ui_bundled/password/password_settings/password_settings_coordinator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/BUILD.gn
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/sharing_status_mediator_unittest.mm
Change size: S
Delta: 8 files changed, 31 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 26, 2026, 10:23:07 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 26, 2026, 10:23:58 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 26, 2026, 10:27:35 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, tmartino+tran...@chromium.org, yuezhang...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rohit Rao
| Code-Review | +1 |
1 comment
File ios/chrome/browser/reader_mode/model/BUILD.gn
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 26, 2026, 10:28:09 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 26, 2026, 10:31:23 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, andysjl...@chromium.org, christia...@chromium.org, dullweb...@chromium.org, eic+...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted and added 2 comments![]( "Open in Gerrit")
Votes added by Rohit Rao
| Code-Review | +1 |
2 comments
File ios/chrome/browser/enterprise/model/idle/action_unittest.mm
Line 34, Patchset 1 (Latest):
#import "ios/chrome/browser/signin/model/identity_test_environment_browser_state_adaptor.h"Rohit Rao . unresolved
Is this needed?
File ios/chrome/browser/safe_browsing/model/tailored_security/tailored_security_tab_helper_unittest.mm
Line 11, Patchset 1 (Latest):
#import "components/sync/test/test_sync_service.h"Rohit Rao . unresolved
Is this needed, if we're using a real SyncService in this test?
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Jun 26, 2026, 10:32:46 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Marc Treib
Rohit Rao voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 26, 2026, 11:23:12 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/ntp/ui_bundled
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
R=rohi...@chromium.org
Bug: 517225028
Change-Id: I44ec0a388b07799f29d656bae11df01ce3a49990
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Auto-Submit: Marc Treib <tr...@chromium.org>
Commit-Queue: Rohit Rao <rohi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653592}
Files:
- M ios/chrome/browser/ntp/ui_bundled/BUILD.gn
- M ios/chrome/browser/ntp/ui_bundled/feed_top_section/BUILD.gn
- M ios/chrome/browser/ntp/ui_bundled/feed_top_section/feed_top_section_mediator_unittest.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_coordinator_unittest.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_mediator_unittest.mm
Change size: S
Delta: 5 files changed, 22 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 26, 2026, 11:28:29 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
['ios/chrome/browser/bring_android_tabs', 'ios/chrome/browser/lens_overlay', 'ios/chrome/browser/shared', 'ios/chrome/browser/content_suggestions', 'ios/chrome/browser/overlays', 'ios/chrome/browser/promos_manager', 'ios/chrome/browser/save_to_photos', 'ios/chrome/browser/tab_switcher']
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
Bug: 517225028
Change-Id: I963c0c004934786a6b2c1be2834d51d878cbc52f
Auto-Submit: Marc Treib <tr...@chromium.org>
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Commit-Queue: Rohit Rao <rohi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653594}
Files:
- M ios/chrome/browser/bring_android_tabs/ui_bundled/BUILD.gn
- M ios/chrome/browser/bring_android_tabs/ui_bundled/bring_android_tabs_prompt_mediator_unittest.mm
- M ios/chrome/browser/bring_android_tabs/ui_bundled/tab_list_from_android_mediator_unittest.mm
- M ios/chrome/browser/content_suggestions/price_tracking_promo/coordinator/BUILD.gn
- M ios/chrome/browser/content_suggestions/price_tracking_promo/coordinator/price_tracking_promo_mediator_unittest.mm
- M ios/chrome/browser/lens_overlay/coordinator/BUILD.gn
- M ios/chrome/browser/lens_overlay/coordinator/lens_overlay_coordinator_unittest.mm
- M ios/chrome/browser/lens_overlay/coordinator/lens_result_page_mediator_unittest.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/sync_error/BUILD.gn
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/sync_error/sync_error_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/promos_manager/coordinator/BUILD.gn
- M ios/chrome/browser/promos_manager/coordinator/promos_manager_coordinator_unittest.mm
- M ios/chrome/browser/save_to_photos/ui_bundled/BUILD.gn
- M ios/chrome/browser/save_to_photos/ui_bundled/save_to_photos_mediator_unittest.mm
- M ios/chrome/browser/shared/coordinator/scene/BUILD.gn
- M ios/chrome/browser/shared/coordinator/scene/scene_controller_unittest.mm
- M ios/chrome/browser/shared/coordinator/scene/task_updater_scene_agent_unittest.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/BUILD.gn
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_grid_coordinator_unittest.mm
Change size: M
Delta: 19 files changed, 76 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 26, 2026, 11:28:47 PM (3 days ago) Jun 26
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/download
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
Bug: 517225028
Change-Id: I45baf398bee6688a7a5f8370705d0e8326b442b8
Commit-Queue: Rohit Rao <rohi...@chromium.org>
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Auto-Submit: Marc Treib <tr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653595}
Files:
- M ios/chrome/browser/download/coordinator/BUILD.gn
- M ios/chrome/browser/download/coordinator/download_manager_coordinator_unittest.mm
- M ios/chrome/browser/download/coordinator/download_manager_mediator_unittest.mm
- M ios/chrome/browser/download/model/BUILD.gn
- M ios/chrome/browser/download/model/document_download_tab_helper_unittest.mm
- M ios/chrome/browser/download/model/download_manager_tab_helper_unittest.mm
Change size: S
Delta: 6 files changed, 26 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
5:44 AM (9 hours ago) 5:44 AM
to Marc Treib, Rohit Rao, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, tmartino+tran...@chromium.org, yuezhang...@chromium.org
Marc Treib voted and added 2 comments![]( "Open in Gerrit")
Votes added by Marc Treib
| Auto-Submit | +0 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File ios/chrome/browser/reader_mode/model/BUILD.gn
Line 161, Patchset 1:
public_deps = [Rohit Rao . resolved
Marc TreibWhy public_deps?
No good reason, really - without this, the `unit_tests` target also has to depend on sync, but that's better. Updated.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
5:50 AM (9 hours ago) 5:50 AM
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, andysjl...@chromium.org, christia...@chromium.org, dullweb...@chromium.org, eic+...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Marc Treib voted and added 3 comments![]( "Open in Gerrit")
Votes added by Marc Treib
| Auto-Submit | +0 |
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File ios/chrome/browser/enterprise/model/idle/action_unittest.mm
Line 34, Patchset 1:
#import "ios/chrome/browser/signin/model/identity_test_environment_browser_state_adaptor.h"Rohit Rao . resolved
Marc TreibIs this needed?
Nope, dunno where that came from, sorry!
File ios/chrome/browser/safe_browsing/model/tailored_security/tailored_security_tab_helper_unittest.mm
Is this needed, if we're using a real SyncService in this test?
Marc Treib
Nope! Removed.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
7:21 AM (7 hours ago) 7:21 AM
to Marc Treib, Chromium LUCI CQ, Rohit Rao, Code Review Nudger, chromium...@chromium.org, andysjl...@chromium.org, christia...@chromium.org, dullweb...@chromium.org, eic+...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Marc Treib voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
7:21 AM (7 hours ago) 7:21 AM
to Marc Treib, Chromium LUCI CQ, Rohit Rao, Code Review Nudger, chromium...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, tmartino+tran...@chromium.org
Marc Treib voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:25 AM (7 hours ago) 7:25 AM
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, andysjl...@chromium.org, christia...@chromium.org, dullweb...@chromium.org, eic+...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/safe_browsing/model/tailored_security/tailored_security_tab_helper_unittest.mm
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: ios/chrome/browser/enterprise/model/idle/action_unittest.mm
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
['ios/chrome/browser/browser_view', 'ios/chrome/browser/enterprise', 'ios/chrome/browser/account_picker', 'ios/chrome/browser/browsing_data', 'ios/chrome/browser/location_bar', 'ios/chrome/browser/post_restore_signin', 'ios/chrome/browser/safe_browsing', 'ios/chrome/browser/signin', 'ios/chrome/browser/welcome_back']
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
Bug: 517225028
Change-Id: Id277e5d06ee26a93fd1680067482721cfb8181af
Commit-Queue: Marc Treib <tr...@chromium.org>
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653982}
Files:
- M ios/chrome/browser/account_picker/ui_bundled/BUILD.gn
- M ios/chrome/browser/account_picker/ui_bundled/account_picker_coordinator_unittest.mm
- M ios/chrome/browser/browser_view/ui_bundled/BUILD.gn
- M ios/chrome/browser/browser_view/ui_bundled/browser_view_controller_unittest.mm
- M ios/chrome/browser/browser_view/ui_bundled/key_commands_provider_unittest.mm
- M ios/chrome/browser/browsing_data/model/BUILD.gn
- M ios/chrome/browser/browsing_data/model/tabs_closure_util_unittest.mm
- M ios/chrome/browser/enterprise/model/idle/BUILD.gn
- M ios/chrome/browser/enterprise/model/idle/action_unittest.mm
- M ios/chrome/browser/enterprise/model/idle/idle_service_unittest.mm
- M ios/chrome/browser/location_bar/ui_bundled/BUILD.gn
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_coordinator_unittest.mm
- M ios/chrome/browser/post_restore_signin/ui_bundled/BUILD.gn
- M ios/chrome/browser/post_restore_signin/ui_bundled/post_restore_signin_provider_unittest.mm
- M ios/chrome/browser/safe_browsing/model/tailored_security/BUILD.gn
- M ios/chrome/browser/safe_browsing/model/tailored_security/tailored_security_tab_helper_unittest.mm
- M ios/chrome/browser/signin/model/account_consistency_browser_agent_unittest.mm
- M ios/chrome/browser/signin/model/authentication_service_observer_bridge_unittest.mm
- M ios/chrome/browser/welcome_back/coordinator/BUILD.gn
- M ios/chrome/browser/welcome_back/coordinator/welcome_back_mediator_unittest.mm
Change size: M
Delta: 20 files changed, 75 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:26 AM (7 hours ago) 7:26 AM
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, tmartino+tran...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
ios/chrome/browser/settings
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
Bug: 517225028
Change-Id: I724ef99252ffc5b1f83710156f5b6d58ff5ce2ec
Commit-Queue: Marc Treib <tr...@chromium.org>
Auto-Submit: Marc Treib <tr...@chromium.org>
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653983}
Files:
- M ios/chrome/browser/settings/clear_browsing_data/coordinator/BUILD.gn
- M ios/chrome/browser/settings/clear_browsing_data/coordinator/quick_delete_mediator_unittest.mm
- M ios/chrome/browser/settings/clear_browsing_data/quick_delete_other_data/coordinator/BUILD.gn
- M ios/chrome/browser/settings/clear_browsing_data/quick_delete_other_data/coordinator/quick_delete_other_data_mediator_unittest.mm
- M ios/chrome/browser/settings/manage_accounts/coordinator/BUILD.gn
- M ios/chrome/browser/settings/manage_accounts/coordinator/manage_accounts_mediator_unittest.mm
- M ios/chrome/browser/settings/manage_accounts/ui/BUILD.gn
- M ios/chrome/browser/settings/manage_accounts/ui/manage_accounts_table_view_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_profile_table_view_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/settings_navigation_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/sync/sync_encryption_table_view_controller_unittest.mm
Change size: M
Delta: 11 files changed, 49 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
8:26 AM (6 hours ago) 8:26 AM
to Marc Treib, Rohit Rao, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, tmartino+tran...@chromium.org, yuezhang...@chromium.org
Marc Treib voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:33 AM (6 hours ago) 8:33 AM
to Marc Treib, Rohit Rao, Code Review Nudger, chromium...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, tmartino+tran...@chromium.org, yuezhang...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/reader_mode/model/BUILD.gn
Insertions: 6, Deletions: 6.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[iOS] Update unit tests to create TestSyncService/SyncServiceImpl
Before, many unit tests on iOS relied (often accidentally) on the
fact that the SyncServiceFactory will, by default, create a real
SyncServiceImpl, even in unit tests.
Most of these tests don't actually need a real SyncServiceImpl;
they just need "something that's not null". This is better served
by TestSyncService, and so most tests are updated to use that. A
few tests *do* need SyncServiceImpl, and are updated to set that
up explicitly.
This CL addresses test files in the following directory/ies:
['ios/chrome/browser/drive_file_picker', 'ios/chrome/browser/reader_mode', 'ios/chrome/browser/autofill', 'ios/chrome/browser/commerce', 'ios/chrome/browser/popup_menu', 'ios/chrome/browser/prerender', 'ios/chrome/browser/saved_tab_groups', 'ios/chrome/browser/synced_set_up']
In a later CL, the factory will be updated to specify
TestingCreation::kNoServiceForTests, so that all future tests
will have to specify which kind of SyncService they need. This
will bring the iOS factory in line with that for other platforms
(see SyncServiceFactory::ServiceIsNULLWhileTesting()).
This CL was uploaded by git cl split.
Bug: 517225028
Change-Id: Ia1cb2e2f6f278e7a365da98a7a498124c1ed6d15
Commit-Queue: Marc Treib <tr...@chromium.org>
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1654006}
Files:
- M ios/chrome/browser/autofill/payments/coordinator/BUILD.gn
- M ios/chrome/browser/autofill/payments/coordinator/payments_suggestion_bottom_sheet_coordinator_unittest.mm
- M ios/chrome/browser/commerce/model/BUILD.gn
- M ios/chrome/browser/commerce/model/price_alert_util_unittest.mm
- M ios/chrome/browser/drive_file_picker/coordinator/BUILD.gn
- M ios/chrome/browser/drive_file_picker/coordinator/browse_drive_file_picker_coordinator_unittest.mm
- M ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_mediator_unittest.mm
- M ios/chrome/browser/drive_file_picker/coordinator/root_drive_file_picker_coordinator_unittest.mm
- M ios/chrome/browser/popup_menu/overflow_menu/coordinator/BUILD.gn
- M ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_mediator_unittest.mm
- M ios/chrome/browser/prerender/model/BUILD.gn
- M ios/chrome/browser/prerender/model/prerender_browser_agent_unittest.mm
- M ios/chrome/browser/reader_mode/model/BUILD.gn
- M ios/chrome/browser/reader_mode/model/reader_mode_tab_helper_unittest.mm
- M ios/chrome/browser/reader_mode/model/reader_mode_test.mm
- M ios/chrome/browser/saved_tab_groups/coordinator/BUILD.gn
- M ios/chrome/browser/saved_tab_groups/coordinator/face_pile_mediator_unittest.mm
- M ios/chrome/browser/synced_set_up/coordinator/BUILD.gn
- M ios/chrome/browser/synced_set_up/coordinator/synced_set_up_mediator_unittest.mm
Change size: M
Delta: 19 files changed, 77 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rohit Rao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages