OopVideoDecoderService: Remove unnecessary dereference [chromium/src : main]
0 views
Skip to first unread message
Nathan Hebert (Gerrit)
Jan 20, 2026, 5:07:20 PM (9 hours ago) Jan 20
to chromium...@chromium.org, feature-me...@chromium.org
Nathan Hebert has uploaded the change for review![]( "Open in Gerrit")
Commit message
OopVideoDecoderService: Remove unnecessary dereference
This should resolve a crash. The mojo OnVideoFrameDecoded interface
takes an Optional<UnguessableToken> for `release_token. It is safe to
skip dereferencing in the service trampoline because the OOPVideoDecoder
OnVideoFrameDecoded implementation handles an unset `release_token`.
Bug: 476483249
Change-Id: Ic6d57106ef7825c08a6d5c307df412216da6cc4b
Change diff
diff --git a/media/mojo/services/oop_video_decoder_service.cc b/media/mojo/services/oop_video_decoder_service.cc
index 86b39aaa..e542d569 100644
--- a/media/mojo/services/oop_video_decoder_service.cc
+++ b/media/mojo/services/oop_video_decoder_service.cc
@@ -269,7 +269,7 @@
CHECK(!frame->HasMappableSharedImage());
video_decoder_client_remote_->OnVideoFrameDecoded(
- std::move(frame), can_read_without_stalling, *release_token);
+ std::move(frame), can_read_without_stalling, release_token);
}
void OOPVideoDecoderService::OnWaiting(WaitingReason reason) {
Change information
Files:
- M media/mojo/services/oop_video_decoder_service.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jan 20, 2026, 5:09:28 PM (9 hours ago) Jan 20
to Nathan Hebert, Andres Calderon Jaramillo, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Nathan Hebert
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Nathan Hebert
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Jan 20, 2026, 6:48:14 PM (7 hours ago) Jan 20
to Chromium LUCI CQ, Dale Curtis, Andres Calderon Jaramillo, chromium...@chromium.org, feature-me...@chromium.org
Nathan Hebert voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 20, 2026, 6:50:51 PM (7 hours ago) Jan 20
to Nathan Hebert, Dale Curtis, Andres Calderon Jaramillo, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
OopVideoDecoderService: Remove unnecessary dereference
This should resolve a crash. The mojo OnVideoFrameDecoded interface
takes an Optional<UnguessableToken> for `release_token`. It is safe to
skip dereferencing in the service trampoline because the OOPVideoDecoder
OnVideoFrameDecoded implementation handles an unset `release_token`.
Bug: 476483249
Change-Id: Ic6d57106ef7825c08a6d5c307df412216da6cc4b
Commit-Queue: Nathan Hebert <nhe...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1571942}
Files:
- M media/mojo/services/oop_video_decoder_service.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages