[iOS] Update All{Regular|Incognito}Browsers call [chromium/src : main]
0 views
Skip to first unread message
Gauthier Ambard (Gerrit)
Jul 4, 2024, 12:41:43 PM (16 hours ago) Jul 4
to Sylvain Defresne, chromium...@chromium.org, asvitki...@chromium.org, chrome-intell...@chromium.org, chromiumme...@microsoft.com, dullweb...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Sylvain Defresne
Gauthier Ambard voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 4, 2024, 12:42:22 PM (16 hours ago) Jul 4
to Chromium LUCI CQ, Sylvain Defresne, chromium...@chromium.org, asvitki...@chromium.org, chrome-intell...@chromium.org, chromiumme...@microsoft.com, dullweb...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Sylvain Defresne
Gauthier Ambard added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 2 (Latest):
Use the new API.Gauthier Ambard . unresolved
I suspect that some of them were using inactive and shouldn't but I am not sure.
If you see places were it is wrong, let me know.
Related details
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
findit-for-me@appspot.gserviceaccount.com (Gerrit)
Jul 4, 2024, 1:30:31 PM (15 hours ago) Jul 4
to Gauthier Ambard, Chromium LUCI CQ, Sylvain Defresne, chromium...@chromium.org, asvitki...@chromium.org, chrome-intell...@chromium.org, chromiumme...@microsoft.com, dullweb...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Gauthier Ambard and Sylvain Defresne
findit...@appspot.gserviceaccount.com voted Code-Coverage-1![]( "Open in Gerrit")
This change will be blocked from submission as there are files which do not meet the coverage criteria. Following files have incremental coverage(all tests) < 70%.
- //ios/chrome/browser/metrics/model/ios_chrome_metrics_service_client.mm
- //ios/chrome/browser/webui/ui_bundled/translate_internals/ios_translate_internals_handler.mm
Please add tests for uncovered lines, or add Low-Coverage-Reason:<reason> in the change description to bypass. See https://bit.ly/46jhjS9 to understand when it is okay to bypass. If you think coverage is underreported, file a bug at https://bit.ly/3ENM7Pe
| Code-Coverage | -1 |
Related details
Attention is currently required from:
- Gauthier Ambard
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages