Avoid propagating GenerateStreams from inactive RFHs [chromium/src : main]

0 views

Skip to first unread message

Elad Alon (Gerrit)

unread,

Sep 19, 2025, 10:52:23 AM (16 hours ago) Sep 19

to Guido Urdaneta, Simon Hangl, Daniel Cheng, Tove Petersson, Fergal Daly, chromium...@chromium.org, Rijubrata Bhaumik, Chromium LUCI CQ, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org

Attention needed from Daniel Cheng, Guido Urdaneta and Simon Hangl

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Guido Urdaneta
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Sep 19, 2025, 5:39:32 PM (9 hours ago) Sep 19

to Elad Alon, Guido Urdaneta, Simon Hangl, Daniel Cheng, Tove Petersson, Fergal Daly, chromium...@chromium.org, Rijubrata Bhaumik, Chromium LUCI CQ, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org

Attention needed from Elad Alon, Guido Urdaneta and Simon Hangl

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Daniel Cheng . unresolved

1, I am assuming you did some manual testing as well.
2. How much more work is it to figure out where else needs `IsActive()` checks? It looks like this probably fixes some instances of it, but races are still possible, right? If we land this, I'm not sure we could mark the associated bug as fixed.