Add comment to clank media capture feature flags redirecting to finch [chromium/src : main]

0 views
Skip to first unread message

Grace Cham (Gerrit)

unread,
Mar 4, 2026, 11:54:25 PM (14 hours ago) Mar 4
to Alex Moshchuk, James Cook, chromium...@chromium.org, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, AyeAye, feature-me...@chromium.org, chfreme...@chromium.org
Attention needed from Alex Moshchuk and Frank Liberato

Grace Cham voted and added 1 comment

Votes added by Grace Cham

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Grace Cham . resolved

Hi, this is just to add a comment for readers that the flags are controlled by finch and not always disabled. PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Moshchuk
  • Frank Liberato
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I678ca618bbd8da79b52fcf1122c05a9d52960494
Gerrit-Change-Number: 7632099
Gerrit-PatchSet: 1
Gerrit-Owner: Grace Cham <hsc...@chromium.org>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: James Cook <jame...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
Gerrit-Attention: Frank Liberato <libe...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Mar 2026 04:53:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Moshchuk (Gerrit)

unread,
12:15 AM (14 hours ago) 12:15 AM
to Grace Cham, Chromium LUCI CQ, James Cook, chromium...@chromium.org, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, AyeAye, feature-me...@chromium.org, chfreme...@chromium.org
Attention needed from Frank Liberato and Grace Cham

Alex Moshchuk voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Frank Liberato
  • Grace Cham
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I678ca618bbd8da79b52fcf1122c05a9d52960494
    Gerrit-Change-Number: 7632099
    Gerrit-PatchSet: 1
    Gerrit-Owner: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
    Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: James Cook <jame...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Grace Cham <hsc...@chromium.org>
    Gerrit-Attention: Frank Liberato <libe...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Mar 2026 05:15:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Frank Liberato (Gerrit)

    unread,
    11:40 AM (3 hours ago) 11:40 AM
    to Grace Cham, Alex Moshchuk, Chromium LUCI CQ, James Cook, chromium...@chromium.org, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, AyeAye, feature-me...@chromium.org, chfreme...@chromium.org
    Attention needed from Grace Cham

    Frank Liberato voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Grace Cham
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I678ca618bbd8da79b52fcf1122c05a9d52960494
    Gerrit-Change-Number: 7632099
    Gerrit-PatchSet: 1
    Gerrit-Owner: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
    Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: James Cook <jame...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Grace Cham <hsc...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Mar 2026 16:39:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    11:42 AM (3 hours ago) 11:42 AM
    to Grace Cham, Alex Moshchuk, James Cook, chromium...@chromium.org, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, AyeAye, feature-me...@chromium.org, chfreme...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add comment to clank media capture feature flags redirecting to finch

    To avoid confusion that they are always disabled by default.
    Bug: 405218400
    Change-Id: I678ca618bbd8da79b52fcf1122c05a9d52960494
    Auto-Submit: Grace Cham <hsc...@chromium.org>
    Commit-Queue: Frank Liberato <libe...@chromium.org>
    Reviewed-by: Alex Moshchuk <ale...@chromium.org>
    Reviewed-by: Frank Liberato <libe...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1594721}
    Files:
    • M chrome/browser/media/webrtc/desktop_media_picker.cc
    • M content/public/common/content_features.cc
    Change size: XS
    Delta: 2 files changed, 2 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Frank Liberato, +1 by Alex Moshchuk
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I678ca618bbd8da79b52fcf1122c05a9d52960494
    Gerrit-Change-Number: 7632099
    Gerrit-PatchSet: 2
    Gerrit-Owner: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
    Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    open
    diffy
    satisfied_requirement

    James Cook (Gerrit)

    unread,
    1:53 PM (22 minutes ago) 1:53 PM
    to Grace Cham, Chromium LUCI CQ, Alex Moshchuk, chromium...@chromium.org, Rijubrata Bhaumik, Andrew Rayskiy, Simon Hangl, AyeAye, feature-me...@chromium.org, chfreme...@chromium.org

    James Cook added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    James Cook . resolved

    Thank you!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I678ca618bbd8da79b52fcf1122c05a9d52960494
    Gerrit-Change-Number: 7632099
    Gerrit-PatchSet: 2
    Gerrit-Owner: Grace Cham <hsc...@chromium.org>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
    Gerrit-Reviewer: Grace Cham <hsc...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: James Cook <jame...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Comment-Date: Thu, 05 Mar 2026 18:53:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages