Convert to UNSAFE_TODO in media [chromium/src : main]

0 views

Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,

Nov 7, 2025, 11:57:28 AM11/7/25

to Sam Zackrisson, Rijubrata Bhaumik, Ale Bzk, Zijie He, chromium...@chromium.org, Per Åhgren, erickun...@chromium.org, toyosh...@chromium.org, chfreme...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, eme-r...@chromium.org, ipc-securi...@chromium.org, feature-me...@chromium.org, chromeos-ca...@google.com, mac-r...@chromium.org, oshima...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org

Arthur Sonzogni has uploaded the change for review

Commit message

Convert to UNSAFE_TODO in media

This is an automated #cleanup patch using the [Script] below.

We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations, allowing
the rest of the file to be enforced as safe.

This CL was uploaded by git cl split.

Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing

AX-Relnotes: N/A

Cleanup: This is an automated #cleanup.

Bug: 409340989

Change-Id: Ic926b6fa659263033280e17e5fc1d0f731911715

Change diff

Change information

Files:

M media/audio/apple/audio_auhal.cc
M media/audio/apple/audio_low_latency_input.cc
M media/audio/fuchsia/audio_input_stream_fuchsia.cc
M media/audio/fuchsia/audio_input_stream_fuchsia_test.cc
M media/audio/fuchsia/audio_output_stream_fuchsia.cc
M media/audio/mac/audio_device_listener_mac.cc
M media/audio/mac/audio_loopback_input_mac_impl.mm
M media/audio/mac/audio_loopback_input_mac_unittest.mm
M media/audio/mac/audio_manager_mac.cc
M media/audio/win/core_audio_util_win_unittest.cc
M media/audio/win/waveout_output_win.cc
M media/capture/video/apple/sample_buffer_transformer_unittest.mm
M media/capture/video/apple/video_capture_device_apple.mm
M media/capture/video/apple/video_capture_device_avfoundation.mm
M media/capture/video/apple/video_capture_device_factory_apple.mm
M media/capture/video/blob_utils.cc
M media/capture/video/chromeos/camera_app_device_impl.cc
M media/capture/video/chromeos/camera_device_delegate.cc
M media/capture/video/chromeos/camera_device_delegate_unittest.cc
M media/capture/video/chromeos/camera_hal_delegate.cc
M media/capture/video/chromeos/camera_hal_delegate_unittest.cc
M media/capture/video/chromeos/camera_metadata_utils.h
M media/capture/video/chromeos/request_manager.cc
M media/capture/video/chromeos/request_manager_unittest.cc
M media/capture/video/chromeos/stream_buffer_manager.cc
M media/capture/video/fake_video_capture_device.cc
M media/capture/video/fuchsia/video_capture_device_fuchsia.cc
M media/capture/video/linux/fake_v4l2_impl.cc
M media/capture/video/linux/v4l2_capture_delegate.cc
M media/capture/video/linux/video_capture_device_factory_v4l2.cc
M media/capture/video/mac/uvc_control_mac.mm
M media/capture/video/video_capture_device_client.cc
M media/capture/video/video_capture_device_unittest.cc
M media/capture/video/win/video_capture_device_factory_win.cc
M media/capture/video/win/video_capture_device_factory_win_unittest.cc
M media/capture/video/win/video_capture_device_utils_win.cc
M media/capture/video/win/video_capture_device_win.cc
M media/cdm/aes_decryptor_unittest.cc
M media/cdm/cdm_adapter_unittest.cc
M media/cdm/cenc_utils_fuzzertest.cc
M media/cdm/json_web_key_fuzzer.cc
M media/cdm/library_cdm/clear_key_cdm/cdm_video_decoder.cc
M media/cdm/library_cdm/clear_key_cdm/clear_key_cdm.cc
M media/cdm/win/media_foundation_cdm.cc
M media/cdm/win/media_foundation_cdm_session.cc
M media/cdm/win/test/media_foundation_clear_key_cdm_factory.h
M media/cdm/win/test/media_foundation_clear_key_input_trust_authority.cc
M media/cdm/win/test/media_foundation_clear_key_session.cc
M media/filters/chunk_demuxer_unittest.cc
M media/filters/ffmpeg_aac_bitstream_converter.cc
M media/filters/source_buffer_range.cc
M media/filters/vpx_video_decoder_unittest.cc
M media/formats/mp2t/es_adapter_video_unittest.cc
M media/formats/mp2t/es_parser.cc
M media/formats/mp2t/es_parser_adts.cc
M media/formats/mp2t/es_parser_h264.cc
M media/formats/mp2t/mp2t_stream_parser.cc
M media/formats/mp2t/mp2t_stream_parser_unittest.cc
M media/formats/mp2t/timestamp_unroller_unittest.cc
M media/formats/mp2t/ts_packet.cc
M media/formats/mp2t/ts_section_pes.cc
M media/formats/mp2t/ts_section_psi.cc
M media/formats/mp4/aac_unittest.cc
M media/formats/mp4/ac3.cc
M media/formats/mp4/avc.cc
M media/formats/mp4/avc_unittest.cc
M media/formats/mp4/box_reader_unittest.cc
M media/formats/mp4/eac3.cc
M media/formats/mp4/es_descriptor_unittest.cc
M media/formats/mp4/h264_annex_b_to_avc_bitstream_converter_fuzztest.cc
M media/formats/mp4/hevc.cc
M media/fuchsia/camera/fake_fuchsia_camera.cc
M media/fuchsia/common/vmo_buffer.cc
M media/fuchsia/common/vmo_buffer_writer_queue.cc
M media/fuchsia/video/fuchsia_video_decoder.cc
M media/fuchsia/video/fuchsia_video_decoder_unittest.cc
M media/fuchsia/video/fuchsia_video_encode_accelerator.cc
M media/midi/midi_manager_mac.cc
M media/midi/midi_manager_win.cc
M media/midi/midi_manager_winrt.cc
M media/midi/midi_webmidi_data_validator_fuzzer.cc
M media/mojo/mojom/video_frame_mojom_traits_unittest.cc
M media/parsers/h265_parser_unittest.cc
M media/parsers/jpeg_parser_picture_fuzzertest.cc
M media/parsers/vp9_parser.h
M media/parsers/webp_parser_fuzzertest.cc
M media/remoting/fake_remoter.cc
M media/renderers/audio_renderer_impl_unittest.cc
M media/renderers/paint_canvas_video_renderer.cc
M media/renderers/paint_canvas_video_renderer_unittest.cc
M media/renderers/shared_image_video_frame_test_utils.cc
M media/renderers/video_resource_updater_unittest.cc
M media/renderers/win/media_foundation_audio_stream.cc
M media/renderers/win/media_foundation_renderer_integration_test.cc
M media/test/pipeline_integration_fuzzertest.cc
M media/video/gpu_memory_buffer_video_frame_pool.cc
M media/webrtc/audio_processor.cc
M media/webrtc/audio_processor_test.cc

Change size: XL

Delta: 98 files changed, 566 insertions(+), 909 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Arthur Sonzogni (Gerrit)

unread,

Nov 8, 2025, 2:39:55 AM11/8/25

to Ale Bzk, chromium...@chromium.org, Per Åhgren, Rijubrata Bhaumik, Sam Zackrisson, Zijie He, chfreme...@chromium.org, chromeos-ca...@google.com, eme-r...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org, toyosh...@chromium.org

Arthur Sonzogni voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Arthur Sonzogni (Gerrit)

unread,

Mar 11, 2026, 2:32:25 PMMar 11

to AyeAye, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Rijubrata Bhaumik, Sam Zackrisson, Zijie He, ortuno...@chromium.org, vaapi-...@chromium.org, media-wi...@chromium.org, titoua...@chromium.org, chromeos-gfx-...@google.com, media-cro...@chromium.org, chfreme...@chromium.org, chromeos-ca...@google.com, eme-r...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org, toyosh...@chromium.org

Arthur Sonzogni abandoned this change.

View Change

Abandoned

Arthur Sonzogni abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages