Adds Media.Audio.LoopbackReference UMAs [chromium/src : main]

0 views
Skip to first unread message

Fredrik Hernqvist (Gerrit)

unread,
Jul 3, 2025, 7:26:48 AM7/3/25
to Henrik Andreasson, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
Attention needed from Henrik Andreasson

Fredrik Hernqvist added 3 comments

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Fredrik Hernqvist . resolved

Looking good!

File services/audio/loopback_reference_manager.cc
Line 64, Patchset 8 (Latest):void ReportOpenResult(ReferenceOpenOutcome outcome) {
Fredrik Hernqvist . unresolved

To avoid having to introduce temporary ReferenceOpenOutcome variables or write the same ReferenceOpenOutcome twice, we can do

```
ReferenceOpenOutcome ReportOpenResult(ReferenceOpenOutcome outcome) {
  base::Uma...
  return outcome;
}
```
Then in other places we can do `return ReportOpenResult(ReferenceOpenOutcome::SUCCESS);` or similar.
Line 300, Patchset 8 (Latest): ReferenceOpenOutcome StartListening(ReferenceOutput::Listener* listener,
Fredrik Hernqvist . unresolved

Let's report in here instead, so we also include STREAM_PREVIOUS_ERROR.

Open in Gerrit

Related details

Attention is currently required from:
  • Henrik Andreasson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
Gerrit-Change-Number: 6696014
Gerrit-PatchSet: 8
Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
Gerrit-Comment-Date: Thu, 03 Jul 2025 11:26:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Henrik Andreasson (Gerrit)

unread,
Jul 3, 2025, 8:11:06 AM7/3/25
to Chromium Metrics Reviews, AyeAye, Fredrik Hernqvist, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
Attention needed from Fredrik Hernqvist

Henrik Andreasson added 3 comments

Patchset-level comments
Henrik Andreasson . resolved

PTAL

File services/audio/loopback_reference_manager.cc
Line 64, Patchset 8 (Latest):void ReportOpenResult(ReferenceOpenOutcome outcome) {
Fredrik Hernqvist . resolved

To avoid having to introduce temporary ReferenceOpenOutcome variables or write the same ReferenceOpenOutcome twice, we can do

```
ReferenceOpenOutcome ReportOpenResult(ReferenceOpenOutcome outcome) {
  base::Uma...
  return outcome;
}
```
Then in other places we can do `return ReportOpenResult(ReferenceOpenOutcome::SUCCESS);` or similar.
Henrik Andreasson

Done

Line 300, Patchset 8 (Latest): ReferenceOpenOutcome StartListening(ReferenceOutput::Listener* listener,
Fredrik Hernqvist . resolved

Let's report in here instead, so we also include STREAM_PREVIOUS_ERROR.

Henrik Andreasson

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Hernqvist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
Gerrit-Change-Number: 6696014
Gerrit-PatchSet: 8
Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Fredrik Hernqvist <fhern...@google.com>
Gerrit-Comment-Date: Thu, 03 Jul 2025 12:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fredrik Hernqvist <fhern...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Hernqvist (Gerrit)

unread,
Jul 3, 2025, 10:08:44 AM7/3/25
to Henrik Andreasson, Dale Curtis, Chrome Metrics Logs, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
Attention needed from Dale Curtis and Henrik Andreasson

Fredrik Hernqvist voted and added 1 comment

Votes added by Fredrik Hernqvist

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Fredrik Hernqvist . resolved

LGTM! @dalec...@chromium.org, Olga (who usually reviews our AudioService CLs) is on vacation, please take a look :)

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • Henrik Andreasson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
    Gerrit-Change-Number: 6696014
    Gerrit-PatchSet: 10
    Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Reviewer: Chrome Metrics Logs <chrome-metri...@google.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Comment-Date: Thu, 03 Jul 2025 14:08:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Jul 7, 2025, 1:09:07 PM7/7/25
    to Henrik Andreasson, Fredrik Hernqvist, Chrome Metrics Logs, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
    Attention needed from Henrik Andreasson

    Dale Curtis voted and added 1 comment

    Votes added by Dale Curtis

    Code-Review+1

    1 comment

    File services/audio/reference_signal_provider.h
    Line 19, Patchset 11 (Latest): SUCCESS = 0,
    Dale Curtis . unresolved

    Naming style these days is `kSuccess`, etc https://google.github.io/styleguide/cppguide.html#Enumerator_Names

    Since you're now mixing styles, this seems a good thing to cleanup in a separate CL.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Henrik Andreasson
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
      Gerrit-Change-Number: 6696014
      Gerrit-PatchSet: 11
      Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Reviewer: Chrome Metrics Logs <chrome-metri...@google.com>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Comment-Date: Mon, 07 Jul 2025 17:08:55 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Fredrik Hernqvist (Gerrit)

      unread,
      Jul 8, 2025, 4:29:20 AM7/8/25
      to Henrik Andreasson, Dale Curtis, Chrome Metrics Logs, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
      Attention needed from Henrik Andreasson

      Fredrik Hernqvist voted and added 1 comment

      Votes added by Fredrik Hernqvist

      Code-Review+1

      1 comment

      File services/audio/reference_signal_provider.h
      Dale Curtis . resolved

      Naming style these days is `kSuccess`, etc https://google.github.io/styleguide/cppguide.html#Enumerator_Names

      Since you're now mixing styles, this seems a good thing to cleanup in a separate CL.

      Fredrik Hernqvist

      Will do! Thanks

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Henrik Andreasson
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
      Gerrit-Change-Number: 6696014
      Gerrit-PatchSet: 11
      Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Reviewer: Chrome Metrics Logs <chrome-metri...@google.com>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Comment-Date: Tue, 08 Jul 2025 08:29:07 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Fredrik Hernqvist (Gerrit)

      unread,
      Jul 8, 2025, 4:31:47 AM7/8/25
      to Henrik Andreasson, Evan Liu, Dale Curtis, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
      Attention needed from Evan Liu and Henrik Andreasson

      Fredrik Hernqvist added 1 comment

      Patchset-level comments
      File-level comment, Patchset 11 (Latest):
      Fredrik Hernqvist . resolved

      Adding Evan for histograms.xml and enums.xml, PTAL! :)

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Evan Liu
      • Henrik Andreasson
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
      Gerrit-Change-Number: 6696014
      Gerrit-PatchSet: 11
      Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Evan Liu <ev...@google.com>
      Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Evan Liu <ev...@google.com>
      Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Comment-Date: Tue, 08 Jul 2025 08:31:29 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Evan Liu (Gerrit)

      unread,
      Jul 8, 2025, 1:24:32 PM7/8/25
      to Henrik Andreasson, Fredrik Hernqvist, Dale Curtis, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
      Attention needed from Henrik Andreasson

      Evan Liu voted and added 2 comments

      Votes added by Evan Liu

      Code-Review+1

      2 comments

      File services/audio/reference_signal_provider.h
      Line 17, Patchset 11 (Latest): enum class ReferenceOpenOutcome {
      Evan Liu . unresolved

      nit: this enum should have a comment that starts with:
      // These values are persisted to logs. Entries should not be renumbered and
      // numeric values should never be reused.

      Also, ideally it should be guarded by a LINT statement

      https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#requirements

      File tools/metrics/histograms/metadata/media/histograms.xml
      Line 1038, Patchset 11 (Latest): enum="BooleanRuntimeError" expires_after="2026-07-03">
      Evan Liu . unresolved

      You could just do `enum="Boolean"` here and remove the `BooleanRuntimeError` definition from enums.xml

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Henrik Andreasson
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
      Gerrit-Change-Number: 6696014
      Gerrit-PatchSet: 11
      Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Evan Liu <ev...@google.com>
      Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Comment-Date: Tue, 08 Jul 2025 17:24:18 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Fredrik Hernqvist (Gerrit)

      unread,
      Jul 9, 2025, 10:11:17 AM7/9/25
      to Henrik Andreasson, Evan Liu, Dale Curtis, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
      Attention needed from Dale Curtis, Evan Liu and Henrik Andreasson

      Fredrik Hernqvist voted and added 2 comments

      Votes added by Fredrik Hernqvist

      Code-Review+1

      2 comments

      File services/audio/reference_signal_provider.h
      Line 17, Patchset 11: enum class ReferenceOpenOutcome {
      Evan Liu . resolved

      nit: this enum should have a comment that starts with:
      // These values are persisted to logs. Entries should not be renumbered and
      // numeric values should never be reused.

      Also, ideally it should be guarded by a LINT statement

      https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#requirements

      Fredrik Hernqvist

      Done

      File tools/metrics/histograms/metadata/media/histograms.xml
      Line 1038, Patchset 11: enum="BooleanRuntimeError" expires_after="2026-07-03">
      Evan Liu . resolved

      You could just do `enum="Boolean"` here and remove the `BooleanRuntimeError` definition from enums.xml

      Fredrik Hernqvist

      Yes, but we would like to keep it this way because it makes it clear at a glance if we're looking at the Error or NoError plot from a glance without looking at the histogram name.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dale Curtis
      • Evan Liu
      • Henrik Andreasson
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
        Gerrit-Change-Number: 6696014
        Gerrit-PatchSet: 13
        Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
        Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
        Gerrit-Reviewer: Evan Liu <ev...@google.com>
        Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
        Gerrit-Attention: Evan Liu <ev...@google.com>
        Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
        Gerrit-Comment-Date: Wed, 09 Jul 2025 14:10:59 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Evan Liu <ev...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Dale Curtis (Gerrit)

        unread,
        Jul 9, 2025, 12:44:00 PM7/9/25
        to Fredrik Hernqvist, Henrik Andreasson, Evan Liu, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
        Attention needed from Evan Liu, Fredrik Hernqvist and Henrik Andreasson

        Dale Curtis voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Evan Liu
        • Fredrik Hernqvist
        • Henrik Andreasson
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
          Gerrit-Change-Number: 6696014
          Gerrit-PatchSet: 13
          Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
          Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
          Gerrit-Reviewer: Evan Liu <ev...@google.com>
          Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-Attention: Fredrik Hernqvist <fhern...@google.com>
          Gerrit-Attention: Evan Liu <ev...@google.com>
          Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
          Gerrit-Comment-Date: Wed, 09 Jul 2025 16:43:48 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Fredrik Hernqvist (Gerrit)

          unread,
          Jul 9, 2025, 12:46:53 PM7/9/25
          to Henrik Andreasson, Dale Curtis, Evan Liu, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com
          Attention needed from Evan Liu and Henrik Andreasson

          Fredrik Hernqvist voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Evan Liu
          • Henrik Andreasson
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
          Gerrit-Change-Number: 6696014
          Gerrit-PatchSet: 13
          Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
          Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
          Gerrit-Reviewer: Evan Liu <ev...@google.com>
          Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-Attention: Evan Liu <ev...@google.com>
          Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
          Gerrit-Comment-Date: Wed, 09 Jul 2025 16:46:37 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Jul 9, 2025, 12:49:56 PM7/9/25
          to Fredrik Hernqvist, Henrik Andreasson, Dale Curtis, Evan Liu, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, asvitkine...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, zhangwen...@google.com

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          Adds Media.Audio.LoopbackReference UMAs
          Bug: 419813744
          Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
          Reviewed-by: Fredrik Hernqvist <fhern...@google.com>
          Commit-Queue: Fredrik Hernqvist <fhern...@google.com>
          Reviewed-by: Dale Curtis <dalec...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1484418}
          Files:
          • M services/audio/loopback_reference_manager.cc
          • M services/audio/loopback_reference_manager_unittest.cc
          • M services/audio/reference_signal_provider.h
          • M tools/metrics/histograms/metadata/media/enums.xml
          • M tools/metrics/histograms/metadata/media/histograms.xml
          Change size: M
          Delta: 5 files changed, 109 insertions(+), 24 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Fredrik Hernqvist, +1 by Dale Curtis
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I105069eab60c043a3feb62e72747505a353f89f3
          Gerrit-Change-Number: 6696014
          Gerrit-PatchSet: 14
          Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
          Gerrit-Reviewer: Evan Liu <ev...@google.com>
          Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages