Fix files broken by crrev.com/c/6914274 [chromium/src : main]

0 views
Skip to first unread message

Antonio Rivera (Gerrit)

unread,
Sep 19, 2025, 4:24:25 PM (16 hours ago) Sep 19
to Shawn Quereshi, chromium...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
Attention needed from Shawn Quereshi

Antonio Rivera voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shawn Quereshi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ife080928e942dff7de5bd7f29c63eaa5f308c7aa
Gerrit-Change-Number: 6969909
Gerrit-PatchSet: 1
Gerrit-Owner: Antonio Rivera <anto...@google.com>
Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Shawn Quereshi <sha...@google.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 20:24:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shawn Quereshi (Gerrit)

unread,
Sep 19, 2025, 4:41:49 PM (15 hours ago) Sep 19
to Antonio Rivera, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
Attention needed from Antonio Rivera

Shawn Quereshi voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Antonio Rivera
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ife080928e942dff7de5bd7f29c63eaa5f308c7aa
    Gerrit-Change-Number: 6969909
    Gerrit-PatchSet: 1
    Gerrit-Owner: Antonio Rivera <anto...@google.com>
    Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
    Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
    Gerrit-Attention: Antonio Rivera <anto...@google.com>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 20:41:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Antonio Rivera (Gerrit)

    unread,
    Sep 19, 2025, 5:11:53 PM (15 hours ago) Sep 19
    to Shawn Quereshi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org

    Antonio Rivera voted and added 1 comment

    Votes added by Antonio Rivera

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Antonio Rivera . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ife080928e942dff7de5bd7f29c63eaa5f308c7aa
    Gerrit-Change-Number: 6969909
    Gerrit-PatchSet: 1
    Gerrit-Owner: Antonio Rivera <anto...@google.com>
    Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
    Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 21:11:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 19, 2025, 5:17:40 PM (15 hours ago) Sep 19
    to Antonio Rivera, Shawn Quereshi, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix files broken by crrev.com/c/6914274

    I'm not sure why the tests or production code didn't get built in any
    precommits... I'll have to look into that later.

    Also fixed a build failure for core_runtime_starboard.

    Test:
    tools/autotest.py -C out/glinux --run_all ./chromecast/starboard/media
    Bug: None
    Change-Id: Ife080928e942dff7de5bd7f29c63eaa5f308c7aa
    Commit-Queue: Antonio Rivera <anto...@google.com>
    Reviewed-by: Shawn Quereshi <sha...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1518168}
    Files:
    • M chromecast/starboard/chromecast/starboard_adapter/src/cast_starboard_api_adapter_impl.cc
    • M chromecast/starboard/media/renderer/demuxer_stream_reader.cc
    • M chromecast/starboard/media/renderer/demuxer_stream_reader_test.cc
    • M chromecast/starboard/media/renderer/starboard_player_manager_test.cc
    • M chromecast/starboard/media/renderer/starboard_renderer_test.cc
    Change size: S
    Delta: 5 files changed, 18 insertions(+), 12 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Shawn Quereshi
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ife080928e942dff7de5bd7f29c63eaa5f308c7aa
    Gerrit-Change-Number: 6969909
    Gerrit-PatchSet: 2
    Gerrit-Owner: Antonio Rivera <anto...@google.com>
    Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages