[Test][Android] Fix SigninFirstRunFragmentTest [chromium/src : main]

[Tanmoy Mollik (Gerrit)]

Attention needed from Boris Sazonov

Tanmoy Mollik added 2 comments

Patchset-level comments

File-level comment, Patchset 21:

Boris Sazonov . resolved

It looks like there are some failing tests that might need fixing (let's decide what do we do with hiding the spinner first).

Tanmoy Mollik

Done

File chrome/browser/ui/android/signin/java/src/org/chromium/chrome/browser/ui/signin/fullscreen_signin/FullscreenSigninViewBinder.java

Line 273, Patchset 21: if (!sHideSigninSpinnerForTests) {

Boris Sazonov . resolved

I've commented this out and run `testSigninWithDefaultAccount` 100 times on `crow --device generic_phone --api_level 35 --arch x86_64` - it passed all 100 times without any issues. Can you please share more details on how you've reproduced the issue?

Tanmoy Mollik

Hi . I removed that change. It looks like it is no longer needed. PTAL

Open in Gerrit

Related details

Attention is currently required from:

• Boris Sazonov

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib3b6479f9efc2960e38e47d6674c04281378a5a1

Gerrit-Change-Number: 7198580

Gerrit-PatchSet: 24

Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>

Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>

Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Boris Sazonov <bsaz...@chromium.org>

Gerrit-Comment-Date: Mon, 22 Dec 2025 16:54:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Boris Sazonov <bsaz...@chromium.org>

[Boris Sazonov (Gerrit)]

Attention needed from Tanmoy Mollik

Boris Sazonov added 3 comments

Commit Message

Line 12, Patchset 25 (Latest):The first case is solved by adding scrollTo() call in test failure

Boris Sazonov . unresolved

[Nit] It looks like we only have a single case, please update.

File chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninFirstRunFragmentTest.java

Line 478, Patchset 25 (Latest): onScrollToView(withText(R.string.continue_button)).perform(scrollTo(), click());

Boris Sazonov . unresolved

Looks like you're scrolling twice?

Line 577, Patchset 25 (Latest): onView(withText(continueAsText)).perform(scrollTo(), click());

Boris Sazonov . unresolved

Nit: should this use `onScrollToView`? It looks like some other test are also using `scrollTo` instead of `onScrollToView`.

Open in Gerrit

Related details

Attention is currently required from:

• Tanmoy Mollik

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib3b6479f9efc2960e38e47d6674c04281378a5a1

Gerrit-Change-Number: 7198580

Gerrit-PatchSet: 25

Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>

Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>

Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tanmoy Mollik <triplo...@google.com>

Gerrit-Comment-Date: Tue, 23 Dec 2025 13:12:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Tanmoy Mollik (Gerrit)]

Attention needed from Boris Sazonov

Tanmoy Mollik added 3 comments

Commit Message

Line 12, Patchset 25:The first case is solved by adding scrollTo() call in test failure

Boris Sazonov . resolved

[Nit] It looks like we only have a single case, please update.

Tanmoy Mollik

Done

File chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninFirstRunFragmentTest.java

Line 478, Patchset 25: onScrollToView(withText(R.string.continue_button)).perform(scrollTo(), click());

Boris Sazonov . resolved

Looks like you're scrolling twice?

Tanmoy Mollik

Done

Line 577, Patchset 25: onView(withText(continueAsText)).perform(scrollTo(), click());

Boris Sazonov . resolved

Nit: should this use `onScrollToView`? It looks like some other test are also using `scrollTo` instead of `onScrollToView`.

Tanmoy Mollik

They got reverted during a conflicting merge. Fixed

Open in Gerrit

Related details

Attention is currently required from:

• Boris Sazonov

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib3b6479f9efc2960e38e47d6674c04281378a5a1

Gerrit-Change-Number: 7198580

Gerrit-PatchSet: 27

Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>

Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>

Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Boris Sazonov <bsaz...@chromium.org>

Gerrit-Comment-Date: Wed, 24 Dec 2025 15:18:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Boris Sazonov <bsaz...@chromium.org>