[iOS] Refactor TabsClosureAnimation to RadialWipeAnimation [chromium/src : main]

0 views

Skip to first unread message

Benjamin Williams (Gerrit)

unread,

6:21 AM (16 hours ago) 6:21 AM

to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, christia...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, rkgibso...@chromium.org

Attention needed from Gauthier Ambard

Benjamin Williams added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Benjamin Williams . resolved

Hey @gam...@chromium.org! I know this is a large CL due to renaming `TabsClosureAnimation` to `RadialWipeAnimation` and updating all call sites at once. If you'd prefer, I can split this into smaller CLs, likely something like:
1. Introducing `radial_wipe_animation.h/mm` as new files (duping the existing logic).
2. Updating each call site to use the new `RadialWipeAnimation` (each in separate CLs).
3. Removing the now-obsolete `TabsClosureAnimation.h/mm`, etc.

Happy to proceed with this multi-step approach if it makes the review easier, but since I only need your review, I figured keeping it together might be OK too.

Open in Gerrit

Related details

Attention is currently required from:

Gauthier Ambard

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages