[PiP] Add confirmation flow for immersive playback [chromium/src : main]

0 views
Skip to first unread message

Camille Lamy (Gerrit)

unread,
Apr 22, 2026, 8:29:05 AM (yesterday) Apr 22
to Oleh Desiatyrikov (xWF), Giovanni Ortuno Urquidi, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Code Review Nudger, Gurmeet Kalra, Yizhi Zhao, chromium...@chromium.org, srirama chandra sekhar, blink-re...@chromium.org, mattreyno...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, security-...@chromium.org
Attention needed from Frank Liberato, Giovanni Ortuno Urquidi and Oleh Desiatyrikov (xWF)

Camille Lamy added 1 comment

Patchset-level comments
File-level comment, Patchset 22 (Latest):
Camille Lamy . resolved

The plumbing in mojo and content looks ok, I will lgtm this once folks working on the video stack approve it.

Open in Gerrit

Related details

Attention is currently required from:
  • Frank Liberato
  • Giovanni Ortuno Urquidi
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I75c9438278b83ef1d1f4217db0f0cf0f799af45b
Gerrit-Change-Number: 7716732
Gerrit-PatchSet: 22
Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Yizhi Zhao <yi...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Attention: Frank Liberato <libe...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Apr 2026 12:28:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Giovanni Ortuno Urquidi (Gerrit)

unread,
Apr 22, 2026, 10:26:27 AM (yesterday) Apr 22
to Oleh Desiatyrikov (xWF), Giovanni Ortuno Urquidi, Camille Lamy, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Code Review Nudger, Gurmeet Kalra, Yizhi Zhao, chromium...@chromium.org, srirama chandra sekhar, blink-re...@chromium.org, mattreyno...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, security-...@chromium.org
Attention needed from Frank Liberato and Oleh Desiatyrikov (xWF)

Giovanni Ortuno Urquidi added 1 comment

Patchset-level comments
Giovanni Ortuno Urquidi . resolved

I don't think you need me since clamy is taking a look at mojo.

Open in Gerrit

Related details

Attention is currently required from:
  • Frank Liberato
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I75c9438278b83ef1d1f4217db0f0cf0f799af45b
Gerrit-Change-Number: 7716732
Gerrit-PatchSet: 22
Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Yizhi Zhao <yi...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Attention: Frank Liberato <libe...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Apr 2026 14:26:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Oleh Desiatyrikov (xWF) (Gerrit)

unread,
11:18 AM (7 hours ago) 11:18 AM
to Giovanni Ortuno Urquidi, Camille Lamy, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Code Review Nudger, Gurmeet Kalra, Yizhi Zhao, chromium...@chromium.org, srirama chandra sekhar, blink-re...@chromium.org, mattreyno...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, security-...@chromium.org
Attention needed from Frank Liberato

Oleh Desiatyrikov (xWF) added 1 comment

Patchset-level comments
File-level comment, Patchset 23 (Latest):
Oleh Desiatyrikov (xWF) . resolved

Hi @libe...@chromium.org ! I've reorganized the CL chain, so you might recognize some code here from previous reviews. Could you take another look when you have a chance? I'm hoping to get this unblocked. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Frank Liberato
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I75c9438278b83ef1d1f4217db0f0cf0f799af45b
Gerrit-Change-Number: 7716732
Gerrit-PatchSet: 23
Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Yizhi Zhao <yi...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Frank Liberato <libe...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Apr 2026 15:18:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages