Fix more style issues in the VCN bottom sheet code. [chromium/src : main]
0 views
Skip to first unread message
Slobodan Pejic (Gerrit)
Jul 3, 2024, 11:14:05 AM (2 days ago) Jul 3
to Chromium LUCI CQ, Tricium, chromium...@chromium.org, armalhotra+a...@google.com, blundell+...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, feliciac+au...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, jsaul+aut...@google.com, marq+...@chromium.org, rouslan+au...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Slobodan Pejic voted and added 1 comment![]( "Open in Gerrit")
Votes added by Slobodan Pejic
| Commit-Queue | +1 |
1 comment
File ios/chrome/browser/autofill/ui_bundled/bottom_sheet/BUILD.gn
Line 168, Patchset 3 (Parent):
"//ios/chrome/browser/shared/model/browser_state:browser_state",Slobodan Pejic . resolved
FYI: This dependency is removed. (The rest of the changes are sorting due to the recent ui_bundled change).
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
findit-for-me@appspot.gserviceaccount.com (Gerrit)
Jul 3, 2024, 4:09:51 PM (2 days ago) Jul 3
to Slobodan Pejic, Chromium LUCI CQ, Tricium, chromium...@chromium.org, armalhotra+a...@google.com, blundell+...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, feliciac+au...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, jsaul+aut...@google.com, marq+...@chromium.org, rouslan+au...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
findit...@appspot.gserviceaccount.com voted Code-Coverage+1![]( "Open in Gerrit")
This change meets the code coverage requirements.
| Code-Coverage | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slobodan Pejic (Gerrit)
Jul 3, 2024, 4:28:20 PM (2 days ago) Jul 3
to Tommy Martino, findit...@appspot.gserviceaccount.com, Chromium LUCI CQ, Tricium, chromium...@chromium.org, armalhotra+a...@google.com, blundell+...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, feliciac+au...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, jsaul+aut...@google.com, marq+...@chromium.org, rouslan+au...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Tommy Martino
Slobodan Pejic voted and added 1 comment![]( "Open in Gerrit")
Votes added by Slobodan Pejic
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Tommy Martino
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Martino (Gerrit)
Jul 4, 2024, 1:36:53 PM (15 hours ago) Jul 4
to Slobodan Pejic, Gauthier Ambard, findit...@appspot.gserviceaccount.com, Chromium LUCI CQ, Tricium, chromium...@chromium.org, armalhotra+a...@google.com, blundell+...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, feliciac+au...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, jsaul+aut...@google.com, marq+...@chromium.org, rouslan+au...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Slobodan Pejic
Tommy Martino voted and added 3 comments![]( "Open in Gerrit")
Votes added by Tommy Martino
| Code-Review | +1 |
3 comments
Patchset-level comments
Tommy Martino . resolved
The code's in much better shape now, thanks for the cleanup.
cc @gam...@chromium.org FYI
File ios/chrome/browser/autofill/ui_bundled/bottom_sheet/virtual_card_enrollment_bottom_sheet_mediator.mm
Line 87, Patchset 7 (Latest):
CHECK(_callbacks) << "Callbacks_ are not set. Callbacks_ should have been "Tommy Martino . unresolved
Update to match _callbacks (or just use "Callbacks" as a regular word)
File ios/chrome/browser/autofill/ui_bundled/bottom_sheet/virtual_card_enrollment_bottom_sheet_view_controller.mm
Line 53, Patchset 7 (Latest):
Tommy Martino . unresolved
This should probably have a `#pragma mark - UIViewController` for completeness
Related details
Attention is currently required from:
- Slobodan Pejic
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages