[DX12 Enc] Pack color space into encoded AV1 bitstream. [chromium/src : main]
1 view
Skip to first unread message
Ilya Nikolaevskiy (Gerrit)
Jul 7, 2025, 9:38:33 AM7/7/25
to Jianlin Qiu, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org
Attention needed from Eugene Zemtsov and Jianlin Qiu
Ilya Nikolaevskiy voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Eugene Zemtsov
- Jianlin Qiu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianlin Qiu (Gerrit)
Jul 7, 2025, 10:14:51 PM7/7/25
to Ilya Nikolaevskiy, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org
Attention needed from Eugene Zemtsov
Jianlin Qiu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jul 8, 2025, 12:13:17 AM7/8/25
to Jianlin Qiu, Eugene Zemtsov, Ilya Nikolaevskiy, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org
Attention needed from Jianlin Qiu
Eugene Zemtsov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Eugene Zemtsov
| Code-Review | +1 |
1 comment
File media/gpu/windows/d3d12_video_encode_av1_delegate.cc
Line 855, Patchset 2 (Latest):
}Eugene Zemtsov . unresolved
anything we want to set here if it's neither 601 or 709?
Related details
Attention is currently required from:
- Jianlin Qiu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianlin Qiu (Gerrit)
Jul 8, 2025, 12:41:08 AM7/8/25
to Eugene Zemtsov, Ilya Nikolaevskiy, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org
Attention needed from Eugene Zemtsov
Jianlin Qiu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jianlin Qiu
| Commit-Queue | +2 |
1 comment
File media/gpu/windows/d3d12_video_encode_av1_delegate.cc
Eugene Zemtsov . unresolved
anything we want to set here if it's neither 601 or 709?
Jianlin Qiu
For now if it's not 601 or 709, we don't set color space info in sequence header. It will be added case by case if necessary.
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianlin Qiu (Gerrit)
Jul 8, 2025, 12:41:54 AM7/8/25
to Eugene Zemtsov, Ilya Nikolaevskiy, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org
Attention needed from Eugene Zemtsov
Jianlin Qiu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jianlin Qiu
| Commit-Queue | +2 |
1 comment
File media/gpu/windows/d3d12_video_encode_av1_delegate.cc
Eugene Zemtsov . resolved
Jianlin Qiuanything we want to set here if it's neither 601 or 709?
For now if it's not 601 or 709, we don't set color space info in sequence header. It will be added case by case if necessary.
Jianlin Qiu
Done
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 8, 2025, 12:44:39 AM7/8/25
to Jianlin Qiu, Eugene Zemtsov, Ilya Nikolaevskiy, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[DX12 Enc] Pack color space into encoded AV1 bitstream.
When input frame's color space is Rec.709/Rec.601, pack color space
information into AV1 bitstream.
Bug: 40275246, 40269844
Change-Id: I930569602f7100b1451b6fd57ea0f2b2ead3da8e
Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <il...@chromium.org>
Commit-Queue: Jianlin Qiu <jianl...@intel.com>
Cr-Commit-Position: refs/heads/main@{#1483536}
Files:
- M media/gpu/av1_builder.cc
- M media/gpu/av1_builder.h
- M media/gpu/av1_builder_unittest.cc
- M media/gpu/windows/d3d12_video_encode_accelerator_unittest.cc
- M media/gpu/windows/d3d12_video_encode_av1_delegate.cc
- M media/gpu/windows/d3d12_video_encode_av1_delegate.h
- M media/gpu/windows/d3d12_video_encode_delegate.cc
- M media/gpu/windows/d3d12_video_encode_delegate.h
- M media/gpu/windows/d3d12_video_encode_delegate_unittest.cc
- M media/gpu/windows/d3d12_video_encode_h264_delegate.cc
- M media/gpu/windows/d3d12_video_encode_h264_delegate.h
- M media/gpu/windows/d3d12_video_encode_h265_delegate.cc
- M media/gpu/windows/d3d12_video_encode_h265_delegate.h
Change size: M
Delta: 13 files changed, 136 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ilya Nikolaevskiy, +1 by Eugene Zemtsov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages