Hidehiko Abe (Gerrit)

unread,

Jan 20, 2026, 7:57:05 AM (18 hours ago) Jan 20

to Jun Ishiguro, Daniel Murphy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Simon Hangl, aixba+wat...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Jun Ishiguro

Hidehiko Abe added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hidehiko Abe . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:

Jun Ishiguro

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jun Ishiguro (Gerrit)

unread,

Jan 20, 2026, 8:01:05 PM (6 hours ago) Jan 20

to Hidehiko Abe, Daniel Murphy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Simon Hangl, aixba+wat...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Hidehiko Abe

Jun Ishiguro voted and added 1 comment

Votes added by Jun Ishiguro

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jun Ishiguro . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

Jan 20, 2026, 8:02:44 PM (6 hours ago) Jan 20

to Jun Ishiguro, Daniel Murphy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Simon Hangl, aixba+wat...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Hidehiko Abe added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hidehiko Abe . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

Jan 20, 2026, 10:11:08 PM (4 hours ago) Jan 20

to Jun Ishiguro, Daniel Murphy, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Simon Hangl, aixba+wat...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Hidehiko Abe voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 20, 2026, 10:14:15 PM (4 hours ago) Jan 20

to Hidehiko Abe, Jun Ishiguro, Daniel Murphy, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Simon Hangl, aixba+wat...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Move AppLaunchParams to components.

That does not have //chrome dependencies. Let's move it out.

BUG=477191550
TEST=Tryjob

Bypass-Check-License: move files.

Change-Id: I36add893b7a262d196050d09f15558133aa6a461

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7497272

Commit-Queue: Hidehiko Abe <hide...@chromium.org>

Reviewed-by: Jun Ishiguro <ju...@google.com>

Cr-Commit-Position: refs/heads/main@{#1572025}

Files:

M chrome/browser/apps/app_service/BUILD.gn
M chrome/browser/apps/app_service/app_icon/app_icon_test_util.cc
M chrome/browser/apps/app_service/app_install/BUILD.gn
M chrome/browser/apps/app_service/app_install/app_install_navigation_throttle_browsertest.cc
M chrome/browser/apps/app_service/app_service_proxy_base.cc
M chrome/browser/apps/app_service/app_service_proxy_base.h
M chrome/browser/apps/app_service/browser_app_launcher.h
M chrome/browser/apps/app_service/launch_utils.h
M chrome/browser/apps/app_service/launch_utils_unittest.cc
M chrome/browser/apps/app_service/metrics/app_platform_metrics_service_unittest.cc
M chrome/browser/apps/app_service/publisher.h
M chrome/browser/apps/app_service/publishers/arc_apps.cc
M chrome/browser/apps/app_service/publishers/borealis_apps.cc
M chrome/browser/apps/app_service/publishers/bruschetta_apps.cc
M chrome/browser/apps/app_service/publishers/extension_apps_base.cc
M chrome/browser/apps/app_service/publishers/guest_os_apps.cc
M chrome/browser/apps/app_service/publishers/plugin_vm_apps.cc
M chrome/browser/apps/app_service/publishers/remote_apps.cc
M chrome/browser/apps/app_shim/BUILD.gn
M chrome/browser/apps/app_shim/web_app_shim_manager_delegate_mac.cc
M chrome/browser/apps/app_shim/web_app_shim_manager_delegate_mac_unittest.cc
M chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_apitest.cc
M chrome/browser/apps/platform_apps/app_browsertest.cc
M chrome/browser/apps/platform_apps/app_browsertest_util.cc
M chrome/browser/apps/platform_apps/app_window_browsertest.cc
M chrome/browser/apps/platform_apps/extension_app_shim_manager_delegate_mac.cc
M chrome/browser/apps/platform_apps/platform_app_launch.cc
M chrome/browser/ash/android_sms/BUILD.gn
M chrome/browser/ash/android_sms/android_sms_app_manager_impl.h
M chrome/browser/ash/android_sms/android_sms_app_manager_impl_unittest.cc
M chrome/browser/ash/app_list/BUILD.gn
M chrome/browser/ash/app_list/app_list_client_impl_browsertest.cc
M chrome/browser/ash/app_list/app_service/BUILD.gn
M chrome/browser/ash/app_list/app_service/app_service_app_item_browsertest.cc
M chrome/browser/ash/app_list/search/BUILD.gn
M chrome/browser/ash/app_list/search/help_app_search_browsertest.cc
M chrome/browser/ash/app_mode/web_app/BUILD.gn
M chrome/browser/ash/app_mode/web_app/kiosk_web_app_manager_unittest.cc
M chrome/browser/ash/app_mode/web_app/kiosk_web_app_service_launcher_unittest.cc
M chrome/browser/ash/file_manager/BUILD.gn
M chrome/browser/ash/file_manager/file_tasks.cc
M chrome/browser/ash/file_manager/file_tasks_browsertest.cc
M chrome/browser/ash/guest_os/BUILD.gn
M chrome/browser/ash/guest_os/guest_os_terminal.cc
M chrome/browser/ash/login/demo_mode/BUILD.gn
M chrome/browser/ash/login/demo_mode/demo_session.cc
M chrome/browser/ash/login/screens/BUILD.gn
M chrome/browser/ash/login/screens/error_screen.cc
M chrome/browser/ash/policy/reporting/metrics_reporting/apps/BUILD.gn
M chrome/browser/ash/policy/reporting/metrics_reporting/apps/app_events_observer_unittest.cc
M chrome/browser/ash/system_web_apps/BUILD.gn
M chrome/browser/ash/system_web_apps/apps/BUILD.gn
M chrome/browser/ash/system_web_apps/apps/camera_app/BUILD.gn
M chrome/browser/ash/system_web_apps/apps/demo_mode_app_integration_browsertest.cc
M chrome/browser/ash/system_web_apps/apps/help_app/BUILD.gn
M chrome/browser/ash/system_web_apps/apps/help_app/help_app_integration_browsertest.cc
M chrome/browser/ash/system_web_apps/apps/help_app/help_app_web_app_info.cc
M chrome/browser/ash/system_web_apps/apps/media_app/BUILD.gn
M chrome/browser/ash/system_web_apps/apps/media_app/media_app_integration_browsertest.cc
M chrome/browser/ash/system_web_apps/apps/media_app/media_app_ocr_integration_browsertest.cc
M chrome/browser/ash/system_web_apps/apps/media_app/media_web_app_info.cc
M chrome/browser/ash/system_web_apps/apps/os_feedback_system_web_app_info.cc
M chrome/browser/ash/system_web_apps/apps/personalization_app/BUILD.gn
M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_integration_browsertest.cc
M chrome/browser/ash/system_web_apps/system_web_app_manager_browsertest.cc
M chrome/browser/ash/system_web_apps/test_support/BUILD.gn
M chrome/browser/ash/system_web_apps/test_support/system_web_app_browsertest_base.cc
M chrome/browser/ash/system_web_apps/test_support/system_web_app_integration_test.cc
M chrome/browser/ash/system_web_apps/test_support/test_system_web_app_installation.cc
M chrome/browser/background/extensions/BUILD.gn
M chrome/browser/chromeos/app_mode/BUILD.gn
M chrome/browser/chromeos/app_mode/kiosk_app_service_launcher.cc
M chrome/browser/chromeos/app_mode/kiosk_app_service_launcher_unittest.cc
M chrome/browser/devtools/BUILD.gn
M chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc
M chrome/browser/extensions/BUILD.gn
M chrome/browser/extensions/api/management/chrome_management_api_delegate_nonandroid.cc
M chrome/browser/extensions/api/notifications/notifications_apitest.cc
M chrome/browser/extensions/browsertest_util.cc
M chrome/browser/extensions/extension_apitest.cc
M chrome/browser/extensions/extension_browsertest_platform_delegate_non_android.cc
M chrome/browser/policy/test/url_blocklist_policy_browsertest.cc
M chrome/browser/renderer_context_menu/render_view_context_menu.cc
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
M chrome/browser/ui/ash/assistant/assistant_browser_delegate_impl.cc
M chrome/browser/ui/ash/shelf/BUILD.gn
M chrome/browser/ui/ash/shelf/app_service/web_app_shelf_browsertest.cc
M chrome/browser/ui/ash/shelf/chrome_shelf_controller_browsertest.cc
M chrome/browser/ui/ash/system_web_apps/BUILD.gn
M chrome/browser/ui/ash/system_web_apps/system_web_app_delegate_ui_impl.cc
M chrome/browser/ui/ash/system_web_apps/system_web_app_ui_utils.h
M chrome/browser/ui/browser_browsertest.cc
M chrome/browser/ui/browser_commands.cc
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm
M chrome/browser/ui/extensions/BUILD.gn
M chrome/browser/ui/extensions/app_launch_params.h
M chrome/browser/ui/extensions/application_launch.cc
M chrome/browser/ui/extensions/application_launch.h
M chrome/browser/ui/extensions/web_file_handlers/multiclient_util.cc
M chrome/browser/ui/extensions/web_file_handlers/multiclient_util.h
M chrome/browser/ui/permission_bubble/BUILD.gn
M chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc
M chrome/browser/ui/settings_window_manager_browsertest_chromeos.cc
M chrome/browser/ui/views/frame/browser_frame_view_chromeos_browsertest.cc
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
M chrome/browser/ui/views/web_apps/isolated_web_apps/isolated_web_app_installer_view_controller_unittest.cc
M chrome/browser/ui/views/web_apps/protocol_handler_picker_coordinator.cc
M chrome/browser/ui/views/web_apps/protocol_handler_picker_coordinator.h
M chrome/browser/ui/views/web_apps/web_app_launch_dialog.cc
M chrome/browser/ui/web_applications/BUILD.gn
M chrome/browser/ui/web_applications/test/web_app_browsertest_util.cc
M chrome/browser/ui/web_applications/web_app_browsertest.cc
M chrome/browser/ui/web_applications/web_app_browsertest_base.cc
M chrome/browser/ui/web_applications/web_app_file_handling_browsertest.cc
M chrome/browser/ui/web_applications/web_app_guest_session_browsertest_chromeos.cc
M chrome/browser/ui/web_applications/web_app_launch_process.cc
M chrome/browser/ui/web_applications/web_app_launch_utils.cc
M chrome/browser/ui/web_applications/web_app_ui_manager_impl.cc
M chrome/browser/ui/web_applications/web_app_uninstall_browsertest.cc
M chrome/browser/ui/webui/app_home/BUILD.gn
M chrome/browser/ui/webui/app_home/app_home_page_handler.cc
M chrome/browser/ui/webui/ash/settings/pages/device/input_device_settings/BUILD.gn
M chrome/browser/ui/webui/ash/settings/pages/device/input_device_settings/input_device_settings_provider.cc
M chrome/browser/web_applications/BUILD.gn
M chrome/browser/web_applications/app_service/web_app_publisher_helper.cc
M chrome/browser/web_applications/app_service/web_app_publisher_unittest.cc
M chrome/browser/web_applications/app_service/web_apps.cc
M chrome/browser/web_applications/commands/launch_web_app_command.cc
M chrome/browser/web_applications/commands/launch_web_app_command.h
M chrome/browser/web_applications/commands/launch_web_app_command_browsertest.cc
M chrome/browser/web_applications/extensions/BUILD.gn
M chrome/browser/web_applications/extensions/launch.h
M chrome/browser/web_applications/isolated_web_apps/isolated_web_app_file_handling_browsertest.cc
M chrome/browser/web_applications/web_app_command_scheduler.h
M chrome/browser/web_applications/web_app_icon_manager_browsertest.cc
M chrome/browser/web_applications/web_app_run_on_os_login_manager.cc
M chrome/browser/web_applications/web_app_ui_manager.h
M chrome/browser/web_applications/web_app_ui_manager_unittest.cc
M chrome/test/BUILD.gn
M chrome/test/base/ash/util/ash_test_util.cc
M components/services/app_service/BUILD.gn
M components/services/app_service/public/cpp/BUILD.gn
A components/services/app_service/public/cpp/DEPS
R components/services/app_service/public/cpp/app_launch_params.cc
R components/services/app_service/public/cpp/app_launch_params.h

Change size: L

Delta: 145 files changed, 166 insertions(+), 174 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Jun Ishiguro

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Move AppLaunchParams to components. [chromium/src : main]

Hidehiko Abe (Gerrit)

Hidehiko Abe added 1 comment

Related details

Jun Ishiguro (Gerrit)

Jun Ishiguro voted and added 1 comment

Votes added by Jun Ishiguro

1 comment

Related details

Hidehiko Abe (Gerrit)

Hidehiko Abe added 1 comment

Related details

Hidehiko Abe (Gerrit)

Hidehiko Abe voted Commit-Queue+2

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information