[Media Capture] old UI: return to chrome dialog on system UI dismissed [chromium/src : main]
0 views
Skip to first unread message
Grace Cham (Gerrit)
Mar 11, 2026, 12:21:24 AMMar 11
to Calder Kitagawa, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Calder Kitagawa
Grace Cham voted and added 1 comment![]( "Open in Gerrit")
Votes added by Grace Cham
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Grace Cham . resolved
Hi Calder, PTAL!
Previously, closing the system UI to share window/screen will cancel the sharing request i.e. close the chrome dialog for tab sharing as well. It worked fine because the system UI takes up most of the screen and hides the chrome dialog. The new one, however, allows the chrome dialog to show through, so users have a different expectation that closing the system UI only will return to the chrome dialog.
TBH I think this is not very important since we are migrating to the new system UI soon for tab sharing (fingers crossed) but this is an easy change. Please let me know if there's any concerns.
Related details
Attention is currently required from:
- Calder Kitagawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Calder Kitagawa (Gerrit)
Mar 11, 2026, 8:05:15 AMMar 11
to Grace Cham, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Grace Cham
Calder Kitagawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Calder Kitagawa
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Grace Cham
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Grace Cham (Gerrit)
Mar 11, 2026, 7:33:18 PMMar 11
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Grace Cham voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 11, 2026, 7:36:19 PMMar 11
to Grace Cham, Calder Kitagawa, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Media Capture] old UI: return to chrome dialog on system UI dismissed
Since the chrome dialog is still visible under the new system UI picker
for window and screen sharing, users expect to return to the dialog
instead of cancelling the sharing request completely.
Fixed: 491555640
Test: tab sharing works as is, and after dismissing system UI
Change-Id: I5e00c803d1c7446416bdc958d1710e5fecabe152
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Auto-Submit: Grace Cham <hsc...@chromium.org>
Commit-Queue: Grace Cham <hsc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1598071}
Files:
- M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCapturePickerDialog.java
Change size: XS
Delta: 1 file changed, 1 insertion(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Calder Kitagawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages