[WebMIDI/Android] Fix destruction order n MidiManagerAndroid [chromium/src : main]
0 views
Skip to first unread message
Hongchan Choi (Gerrit)
Mar 11, 2026, 5:56:06 PMMar 11
to Takashi Toyoshima, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Attention needed from Takashi Toyoshima
Hongchan Choi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongchan Choi (Gerrit)
Mar 12, 2026, 1:13:23 PMMar 12
to Thomas Guilbert, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Attention needed from Thomas Guilbert
Hongchan Choi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hongchan Choi
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Thomas Guilbert
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Mar 12, 2026, 2:30:22 PMMar 12
to Hongchan Choi, Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Attention needed from Hongchan Choi
Thomas Guilbert voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hongchan Choi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongchan Choi (Gerrit)
Mar 12, 2026, 2:34:19 PMMar 12
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Hongchan Choi voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 12, 2026, 2:37:34 PMMar 12
to Hongchan Choi, Thomas Guilbert, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[WebMIDI/Android] Fix destruction order n MidiManagerAndroid
Moving the `devices_` declaration to the end of the class ensures
it is destroyed first, safely closing ports before the hash maps
are destroyed.
Bug: 490254128
Change-Id: I1a7857ef3f0f58772cd300f603dc74720ac49964
Commit-Queue: Hongchan Choi <hong...@chromium.org>
Reviewed-by: Thomas Guilbert <tgui...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1598579}
Files:
- M media/midi/midi_manager_android.h
Change size: XS
Delta: 1 file changed, 6 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Guilbert
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages