[iOS] Add location bar to new toolbar [chromium/src : main]

0 views

Skip to first unread message

Gauthier Ambard (Gerrit)

unread,

8:08 AM (2 hours ago) 8:08 AM

to Ewann Pellé, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Ewann Pellé

Gauthier Ambard voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Ewann Pellé

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ewann Pellé (Gerrit)

unread,

10:25 AM (8 minutes ago) 10:25 AM

to Gauthier Ambard, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Gauthier Ambard

Ewann Pellé voted and added 2 comments

Votes added by Ewann Pellé

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Ewann Pellé . resolved

LGTM with comment.

File ios/chrome/browser/toolbar/ui/toolbar_view_controller.mm

Line 217, Patchset 5 (Latest): [locationBarContainer.heightAnchor constraintEqualToConstant:40].active = YES;

Ewann Pellé . unresolved

define constant in the anonymnous namespace, same below.