Display place holder title for data Urls [chromium/src : main]
0 views
Skip to first unread message
Tommy Steimel (Gerrit)
Dec 3, 2025, 3:58:08 PM (3 days ago) Dec 3
to Benjamin Keen, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Benjamin Keen
Tommy Steimel voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Benjamin Keen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Dec 3, 2025, 4:08:20 PM (3 days ago) Dec 3
to Chris Harrelson, Tommy Steimel, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Chris Harrelson
Benjamin Keen added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Chris Harrelson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Harrelson (Gerrit)
Dec 5, 2025, 5:54:52 PM (2 days ago) Dec 5
to Benjamin Keen, Tommy Steimel, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Benjamin Keen
Chris Harrelson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Benjamin Keen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Dec 5, 2025, 6:02:53 PM (2 days ago) Dec 5
to Chris Harrelson, Tommy Steimel, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Benjamin Keen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 5, 2025, 7:04:06 PM (2 days ago) Dec 5
to Benjamin Keen, Chris Harrelson, Tommy Steimel, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Display place holder title for data Urls
Before this change, the source title for data Urls would be empty. This
change introduces a generic localized placeholder title: "Data URL".
Bug: 460180762
Change-Id: Idbafcfc9b4bf17ecd808311961f5247ac19cc7a6
Reviewed-by: Chris Harrelson <chri...@chromium.org>
Commit-Queue: Benjamin Keen <bk...@google.com>
Reviewed-by: Tommy Steimel <ste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1554988}
Files:
- M content/browser/media/session/media_session_impl.cc
- M content/browser/picture_in_picture/video_picture_in_picture_content_browsertest.cc
- M third_party/blink/public/strings/blink_strings.grd
- A third_party/blink/public/strings/blink_strings_grd/IDS_MEDIA_SESSION_DATA_SOURCE.png.sha1
Change size: M
Delta: 4 files changed, 47 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Harrelson, +1 by Tommy Steimel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages