[iOS] Integrate Microphone Permissions in Gemini Live FRE [chromium/src : main]
Yasaman Sedaghat (Gerrit)
Yasaman Sedaghat added 6 comments![]( "Open in Gerrit")
The two drive links in the desc are identical.
[self dismissPresentedViewWithCompletion:^{Is this related to the crash you mentioned during a sync? If so can you attach the bug to this cl?
- (void)handleLivePermissionCheckIfNeeded {nit: I would just call it handleLiveMicPermission. I'm not sure if 'ifNeeded' is adding to readability.
- (void)handlePermissionResult:(BOOL)granted {this is live specific only right? let's update the name to make it more clear
__weak __typeof(self) weakSelf = self;let's add a comment like: if mic permission is not granted, dismiss the mic view and go back to presenting LIVE fre
if (granted) {
if (strongSelf->_consentCompletion) {
strongSelf->_consentCompletion();
}
} else {I don't really follow the logic here, but it's also new to me. why do we call consentCompletion only when permission is granted?
Related details
- Adam Arcaro
- Tarek Makkouk
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tarek Makkouk (Gerrit)
Tarek Makkouk added 6 comments![]( "Open in Gerrit")
The two drive links in the desc are identical.
Sorry about that, just corrected the link.
[self dismissPresentedViewWithCompletion:^{Is this related to the crash you mentioned during a sync? If so can you attach the bug to this cl?
I'm not sure what bug this is referring to. This change is just to establish the flow where the `kLive` FRE pauses dismissal to prompt for microphone permissions first so that it still shows in the background of the alert. This is to match the behaviour shown in the mocks.
nit: I would just call it handleLiveMicPermission. I'm not sure if 'ifNeeded' is adding to readability.
Done
this is live specific only right? let's update the name to make it more clear
Done
__weak __typeof(self) weakSelf = self;let's add a comment like: if mic permission is not granted, dismiss the mic view and go back to presenting LIVE fre
Here we actually dismiss both the FRE and the alert regardless of the outcome (i.e., whether mic perms were granted or not), as both paths are wrapped inside `dismissPresentedViewWithCompletion`. Please let me know if you think I should a comment to make this clearer.
if (granted) {
if (strongSelf->_consentCompletion) {
strongSelf->_consentCompletion();
}
} else {I don't really follow the logic here, but it's also new to me. why do we call consentCompletion only when permission is granted?
This is to make sure that the Live consent is tightly coupled with the microphone, meaning that if the microphone permission is denied, the FRE will show up again even if the "Yes, I'm in" was selected (i.e., even if Live consent is granted). Note that behaviour is only expected for the first run.
Related details
- Adam Arcaro
- Yasaman Sedaghat
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |