[iOS][Composebox] Add attachment type UMAs [chromium/src : main]
Matt Reichhoff (Gerrit)
Matt Reichhoff added 2 comments![]( "Open in Gerrit")
sending to christianxu@
Feel free to say no if these aren't useful, but especially the counts at submission/navigation seem like interesting data to get
if (item.type == ComposeboxInputItemType::kComposeboxInputItemTypeFile) {this looks like an existing bug? Seems like the counts were using the wrong category
Related details
- Christian Xu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Xu (Gerrit)
Christian Xu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Christian Xu
| Code-Review | +1 |
1 comment
if (item.type == ComposeboxInputItemType::kComposeboxInputItemTypeFile) {this looks like an existing bug? Seems like the counts were using the wrong category
- Matt Reichhoff
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Xu (Gerrit)
Christian Xu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Christian Xu
| Code-Review | +1 |
sending to christianxu@
Feel free to say no if these aren't useful, but especially the counts at submission/navigation seem like interesting data to get
These are definitely useful, in fact we just got asked to record these exact metrics. Thank you for adding them!
Related details
- Matt Reichhoff
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reichhoff (Gerrit)
Matt Reichhoff added 1 comment![]( "Open in Gerrit")
- Moe Ahmadi
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reichhoff (Gerrit)
Matt Reichhoff voted and added 2 comments![]( "Open in Gerrit")
Votes added by Matt Reichhoff
| Commit-Queue | +1 |
Christian Xusending to christianxu@
Feel free to say no if these aren't useful, but especially the counts at submission/navigation seem like interesting data to get
These are definitely useful, in fact we just got asked to record these exact metrics. Thank you for adding them!
oh, great! will get this submitted
if (item.type == ComposeboxInputItemType::kComposeboxInputItemTypeFile) {Christian Xuthis looks like an existing bug? Seems like the counts were using the wrong category
Thanks for fixing that!
np, though given a merge conflict I think someone else also found it 😊
Related details
- Matt Reichhoff
- Moe Ahmadi
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Moe Ahmadi (Gerrit)
Moe Ahmadi added 2 comments![]( "Open in Gerrit")
Metrics changes LGTM, but I'd like to have x-platform metrics where possible. CC both @nih...@google.com @khali...@chromium.org who are adding metrics.
<histogram name="Omnibox.MobileFusebox.AttachmentCountAtSubmission.{Type}"curious why aren't we logging metrics cross-platform? See "ContextualSearch.Inputs.TypeOnSubmission" added in crrev.com/c/7701697 and a bunch of other metrics logged via components/contextual_search/contextual_search_metrics_recorder.cc in
tools/metrics/histograms/metadata/contextual_search/histograms.xml
Related details
- Khalid Peer
- Matt Reichhoff
- Nihar Majmudar
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Moe Ahmadi (Gerrit)
Moe Ahmadi voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Khalid Peer
- Matt Reichhoff
- Nihar Majmudar
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reichhoff (Gerrit)
Matt Reichhoff added 1 comment![]( "Open in Gerrit")
<histogram name="Omnibox.MobileFusebox.AttachmentCountAtSubmission.{Type}"curious why aren't we logging metrics cross-platform? See "ContextualSearch.Inputs.TypeOnSubmission" added in crrev.com/c/7701697 and a bunch of other metrics logged via components/contextual_search/contextual_search_metrics_recorder.cc in
tools/metrics/histograms/metadata/contextual_search/histograms.xml
I'm happy to make the metrics in this CL cross-platform (intended to do so in follow-up CLs), but wanted to start with bling as that's the surface I work on.
I checked other metrics and didn't see the "attachment count by type at submission"; the tab selector also had an iOS-specific metric, and I wanted to get image/file selector metrics as well.
Related details
- Khalid Peer
- Moe Ahmadi
- Nihar Majmudar
Matt Reichhoff (Gerrit)
Matt Reichhoff added 1 comment![]( "Open in Gerrit")
<histogram name="Omnibox.MobileFusebox.AttachmentCountAtSubmission.{Type}"Matt Reichhoffcurious why aren't we logging metrics cross-platform? See "ContextualSearch.Inputs.TypeOnSubmission" added in crrev.com/c/7701697 and a bunch of other metrics logged via components/contextual_search/contextual_search_metrics_recorder.cc in
tools/metrics/histograms/metadata/contextual_search/histograms.xml
I'm happy to make the metrics in this CL cross-platform (intended to do so in follow-up CLs), but wanted to start with bling as that's the surface I work on.
I checked other metrics and didn't see the "attachment count by type at submission"; the tab selector also had an iOS-specific metric, and I wanted to get image/file selector metrics as well.
sorry, correction, not an iOS-specific metric, but written from the iOS UI code*
Nihar Majmudar (Gerrit)
Nihar Majmudar voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nihar Majmudar
| Code-Review | +1 |
2 comments
LGTM
Metrics changes LGTM, but I'd like to have x-platform metrics where possible. CC both @nih...@google.com @khali...@chromium.org who are adding metrics.
+1 the making this x-platform eventually. I'll add to the existing metrics doc of places where iOS and Desktop metrics overlap and maybe where we can consolidate some metrics.
Related details
- Khalid Peer
- Matt Reichhoff
- Moe Ahmadi
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reichhoff (Gerrit)
Matt Reichhoff voted and added 2 comments![]( "Open in Gerrit")
Votes added by Matt Reichhoff
| Commit-Queue | +2 |
2 comments
happy to revisit or build x-platform equivalents...landing in the meantime
<histogram name="Omnibox.MobileFusebox.AttachmentCountAtSubmission.{Type}"Matt Reichhoffcurious why aren't we logging metrics cross-platform? See "ContextualSearch.Inputs.TypeOnSubmission" added in crrev.com/c/7701697 and a bunch of other metrics logged via components/contextual_search/contextual_search_metrics_recorder.cc in
tools/metrics/histograms/metadata/contextual_search/histograms.xml
Matt ReichhoffI'm happy to make the metrics in this CL cross-platform (intended to do so in follow-up CLs), but wanted to start with bling as that's the surface I work on.
I checked other metrics and didn't see the "attachment count by type at submission"; the tab selector also had an iOS-specific metric, and I wanted to get image/file selector metrics as well.
sorry, correction, not an iOS-specific metric, but written from the iOS UI code*
- Khalid Peer
- Moe Ahmadi
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[iOS][Composebox] Add attachment type UMAs
This CL adds new UMA for the attachments on submission of a fusebox
navigation. It also adds equivalent metrics as TabPickerTabsAttached
for images and files.
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_coordinator.mm
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
- M ios/chrome/browser/composebox/ui/composebox_metrics_recorder.h
- M ios/chrome/browser/composebox/ui/composebox_metrics_recorder.mm
- M ios/chrome/browser/composebox/ui/composebox_metrics_recorder_unittest.mm
- M tools/metrics/histograms/metadata/omnibox/histograms.xml
Code-Review: +1 by Christian Xu, +1 by Nihar Majmudar, +1 by Moe Ahmadi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |