Revert "media/gpu/vaapiWrapper: Add native pixmap validation" [chromium/src : main]
0 views
Skip to first unread message
Jiacheng Guo (Gerrit)
2:13 AM (8 hours ago) 2:13 AM
to android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Ted (Chromium) Meyer, Hirokazu Honda, Chromium LUCI CQ, Kai Ninomiya, chromium...@chromium.org, vaapi-...@chromium.org, feature-me...@chromium.org, chromeos-gfx-...@google.com, media-cro...@chromium.org
Attention needed from Hirokazu Honda, Kai Ninomiya and Ted (Chromium) Meyer
Jiacheng Guo voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Hirokazu Honda
- Kai Ninomiya
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hirokazu Honda (Gerrit)
2:17 AM (8 hours ago) 2:17 AM
to Jiacheng Guo, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Ted (Chromium) Meyer, Chromium LUCI CQ, Kai Ninomiya, chromium...@chromium.org, vaapi-...@chromium.org, feature-me...@chromium.org, chromeos-gfx-...@google.com, media-cro...@chromium.org
Attention needed from Jiacheng Guo, Kai Ninomiya and Ted (Chromium) Meyer
Hirokazu Honda voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jiacheng Guo
- Kai Ninomiya
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:54 AM (7 hours ago) 2:54 AM
to Jiacheng Guo, Qijiang Fan, Hirokazu Honda, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Ted (Chromium) Meyer, Kai Ninomiya, chromium...@chromium.org, vaapi-...@chromium.org, feature-me...@chromium.org, chromeos-gfx-...@google.com, media-cro...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "media/gpu/vaapiWrapper: Add native pixmap validation"
This reverts commit 69d10d8ad171b3aa1ad5610cafaf52f8606c6282.
Reason for revert: Causing test failures on ChromeOS
https://ci.chromium.org/ui/p/chromium/builders/ci/chromeos-amd64-generic-rel-gtest/38874/overview
Original change's description:
> media/gpu/vaapiWrapper: Add native pixmap validation
>
> This CL introduces more rigorous validation for plane metadata when
> populating VADRMPRIMESurfaceDescriptor:
>
> - Verifying that plane pitch is at least the minimum required stride.
> - Ensuring that the plane's memory range (offset + size) stays within
> the bounds of the DMA-buf.
>
> Bug: 495819067
> Test: webrtc.RTCPeerConnection.*
> Change-Id: I5d27d3a21ab692367931406e9c345a4a61ee2bb6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7834744
> Reviewed-by: Ted (Chromium) Meyer <tmath...@chromium.org>
> Commit-Queue: Kai Ninomiya <kai...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1631660}
Bug: 495819067
Change-Id: Iad33edfa65a5bf771e53b57db1f3fd58d595d769
Commit-Queue: Jiacheng Guo <g...@google.com>
Owners-Override: Jiacheng Guo <g...@google.com>
Reviewed-by: Hirokazu Honda <hi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1631989}
Files:
- M media/gpu/vaapi/BUILD.gn
- M media/gpu/vaapi/vaapi_wrapper.cc
Change size: M
Delta: 2 files changed, 17 insertions(+), 78 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hirokazu Honda, Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages