[iOS] Use FullscreenCommands in toolbar mediators [chromium/src : main]
0 views
Skip to first unread message
Hira Mahmood (Gerrit)
Apr 22, 2026, 1:48:43 PM (yesterday) Apr 22
to Christian Xu, Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu
Hira Mahmood voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hira Mahmood
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Christian Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Xu (Gerrit)
7:54 AM (7 hours ago) 7:54 AM
to Hira Mahmood, Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Hira Mahmood
Christian Xu voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hira Mahmood
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hira Mahmood (Gerrit)
10:56 AM (4 hours ago) 10:56 AM
to Christian Xu, Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Hira Mahmood voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:00 AM (4 hours ago) 11:00 AM
to Hira Mahmood, Christian Xu, Scott Yoder, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Use FullscreenCommands in toolbar mediators
When the FullscreenRefactor feature is enabled, toolbar should use the
FullscreenCommands dispatcher to enter/exit fullscreen instead of the
FullscreenController.
Before:
https://screenshot.googleplex.com/3iK3LiDw4VdVr8c (Next IA)
https://screenshot.googleplex.com/6TZBRPP8Si2VpmW (legacy)
After:
https://screenshot.googleplex.com/ATrCM5F3FPKshPu (Next IA)
https://screenshot.googleplex.com/4BZX7MjkiXTMFTF (legacy)
Fixed: 505381147
Change-Id: I50002ae662245547a78eb71aadf0db05bedbd8c6
Reviewed-by: Christian Xu <chris...@chromium.org>
Commit-Queue: Hira Mahmood <hiram...@google.com>
Cr-Commit-Position: refs/heads/main@{#1619522}
Files:
- M ios/chrome/browser/toolbar/coordinator/main_toolbar_coordinator.mm
- M ios/chrome/browser/toolbar/coordinator/toolbar_mediator.h
- M ios/chrome/browser/toolbar/coordinator/toolbar_mediator.mm
- M ios/chrome/browser/toolbar/legacy/ui_bundled/secondary_toolbar_coordinator.mm
- M ios/chrome/browser/toolbar/legacy/ui_bundled/secondary_toolbar_view_controller.h
- M ios/chrome/browser/toolbar/legacy/ui_bundled/secondary_toolbar_view_controller.mm
Change size: M
Delta: 6 files changed, 53 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Christian Xu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages