Enable kWasapiInputUseDeviceSampleFormat by default [chromium/src : main]
0 views
Skip to first unread message
Syed AbuTalib (Gerrit)
Dec 16, 2025, 2:28:17 PM12/16/25
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Thomas Guilbert
Syed AbuTalib voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Thomas Guilbert
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Dec 16, 2025, 3:47:25 PM12/16/25
to Syed AbuTalib, Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Syed AbuTalib
Thomas Guilbert voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Syed AbuTalib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Dec 16, 2025, 3:50:52 PM12/16/25
to Syed AbuTalib, Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Syed AbuTalib
Thomas Guilbert added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Thomas Guilbert . unresolved
Changes LGTM. Might be more cautious to wait until the branch cut, so there is more time to catch regressions.
Leaving this unresolved, so this doesn't get submitted until M145 (Jan 7th+)
Related details
Attention is currently required from:
- Syed AbuTalib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Syed AbuTalib (Gerrit)
Jan 7, 2026, 1:53:56 PM (14 days ago) Jan 7
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Syed AbuTalib added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Thomas Guilbert . unresolved
Changes LGTM. Might be more cautious to wait until the branch cut, so there is more time to catch regressions.
Leaving this unresolved, so this doesn't get submitted until M145 (Jan 7th+)
Syed AbuTalib
Branch cut for M145 is Jan 12, lets wait until after.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Syed AbuTalib (Gerrit)
Jan 20, 2026, 3:15:18 PM (11 hours ago) Jan 20
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Syed AbuTalib added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Thomas Guilbert . resolved
Syed AbuTalibChanges LGTM. Might be more cautious to wait until the branch cut, so there is more time to catch regressions.
Leaving this unresolved, so this doesn't get submitted until M145 (Jan 7th+)
Branch cut for M145 is Jan 12, lets wait until after.
Syed AbuTalib
The day has been passed. Going to submit.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Syed AbuTalib (Gerrit)
Jan 20, 2026, 3:15:21 PM (11 hours ago) Jan 20
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Syed AbuTalib voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 20, 2026, 8:13:42 PM (6 hours ago) Jan 20
to Syed AbuTalib, Thomas Guilbert, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Enable kWasapiInputUseDeviceSampleFormat by default
Enable the kWasapiInputUseDeviceSampleFormat feature flag by default.
This allows the audio input stream to capture audio using the device's
native sample format instead of defaulting to 16-bit signed integers
(S16).
This CL has been tested with https://henrik-and.github.io/echo-demo/ to
make sure it would not break `AEC=all`.
Bug: 354625679
Change-Id: Ibfeb3670f72616dfb4848c78107f326af19024fe
Reviewed-by: Thomas Guilbert <tgui...@chromium.org>
Commit-Queue: Syed AbuTalib <low...@google.com>
Cr-Commit-Position: refs/heads/main@{#1571981}
Files:
- M media/audio/win/audio_low_latency_input_win.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Guilbert
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages