Revert "[IOS][AIM] Add invocation source to the search url request info" [chromium/src : main]

0 views
Skip to first unread message

Ameur Hosni (Gerrit)

unread,
Dec 24, 2025, 4:26:04 AM (4 days ago) Dec 24
to Radu Nitescu, AyeAye, Jason Hu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
Attention needed from Jason Hu and Radu Nitescu

Ameur Hosni voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jason Hu
  • Radu Nitescu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e45c71f14d346f34d647bc6b8a68ba51f34bb63
Gerrit-Change-Number: 7320219
Gerrit-PatchSet: 1
Gerrit-Owner: Ameur Hosni <ameur...@google.com>
Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jason Hu <huja...@google.com>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Attention: Jason Hu <huja...@google.com>
Gerrit-Attention: Radu Nitescu <radun...@google.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 09:25:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Radu Nitescu (Gerrit)

unread,
Dec 24, 2025, 4:27:01 AM (4 days ago) Dec 24
to Ameur Hosni, AyeAye, Jason Hu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
Attention needed from Ameur Hosni and Jason Hu

Radu Nitescu voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ameur Hosni
  • Jason Hu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e45c71f14d346f34d647bc6b8a68ba51f34bb63
    Gerrit-Change-Number: 7320219
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ameur Hosni <ameur...@google.com>
    Gerrit-Reviewer: Ameur Hosni <ameur...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jason Hu <huja...@google.com>
    Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
    Gerrit-Attention: Jason Hu <huja...@google.com>
    Gerrit-Attention: Ameur Hosni <ameur...@google.com>
    Gerrit-Comment-Date: Wed, 24 Dec 2025 09:26:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 24, 2025, 4:27:15 AM (4 days ago) Dec 24
    to Ameur Hosni, Radu Nitescu, AyeAye, Jason Hu, chromium...@chromium.org, feature-me...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[IOS][AIM] Add invocation source to the search url request info"

    This reverts commit 70f9a2a426dc39ed2c6572c85336113b84e6aba3.

    Reason for revert: Invocation source logging seems incorrect as is, there is no realbox on IOS.

    Original change's description:
    > [IOS][AIM] Add invocation source to the search url request info
    >
    > Bug: 470999521
    > Change-Id: Ifd21699f4c194db9b9eea220f650700daa8e0a8c
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7309365
    > Commit-Queue: Ameur Hosni <ameur...@google.com>
    > Reviewed-by: Jason Hu <huja...@google.com>
    > Cr-Commit-Position: refs/heads/main@{#1562249}
    Bug: 470999521
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I4e45c71f14d346f34d647bc6b8a68ba51f34bb63
    Commit-Queue: Radu Nitescu <radun...@google.com>
    Reviewed-by: Radu Nitescu <radun...@google.com>
    Auto-Submit: Ameur Hosni <ameur...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1562450}
    Files:
    Change size: XS
    Delta: 1 file changed, 0 insertions(+), 7 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Radu Nitescu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e45c71f14d346f34d647bc6b8a68ba51f34bb63
    Gerrit-Change-Number: 7320219
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages