[ffmpeg] add linux riscv64 support [chromium/src : main]
2 views
Skip to first unread message
Levi Zim (Gerrit)
Jul 3, 2025, 9:56:40 AM7/3/25
to Dale Curtis, Ted (Chromium) Meyer, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis and Ted (Chromium) Meyer
Levi Zim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Dale Curtis
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jul 7, 2025, 1:31:04 PM7/7/25
to Levi Zim, Ted (Chromium) Meyer, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Levi Zim and Ted (Chromium) Meyer
Dale Curtis voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
2 comments
Patchset-level comments
Dale Curtis . unresolved
lgtm. Thanks! As noted, we will just disable this upon breakages instead of trying to fix it until there's an official CQ bot.
File media/ffmpeg/scripts/build_ffmpeg.py
Line 69, Patchset 1 (Latest):
Script can run on a normal Ubuntu with ARM/ARM64 or MIPS32/MIPS64 or RISCV64 ready Chromium checkout:Dale Curtis . unresolved
Wrap to 80 chars.
Related details
Attention is currently required from:
- Levi Zim
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Levi Zim (Gerrit)
Jul 7, 2025, 9:07:03 PM7/7/25
to Dale Curtis, Ted (Chromium) Meyer, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis and Ted (Chromium) Meyer
Levi Zim added 2 comments![]( "Open in Gerrit")
Patchset-level comments
lgtm. Thanks! As noted, we will just disable this upon breakages instead of trying to fix it until there's an official CQ bot.
Levi Zim
Acknowledged
File media/ffmpeg/scripts/build_ffmpeg.py
Line 69, Patchset 1:
Script can run on a normal Ubuntu with ARM/ARM64 or MIPS32/MIPS64 or RISCV64 ready Chromium checkout:Dale Curtis . resolved
Levi ZimWrap to 80 chars.
Done
Related details
Attention is currently required from:
- Dale Curtis
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jul 8, 2025, 12:48:40 PM7/8/25
to Levi Zim, Ted (Chromium) Meyer, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Levi Zim and Ted (Chromium) Meyer
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Levi Zim
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted (Chromium) Meyer (Gerrit)
Jul 8, 2025, 1:37:34 PM7/8/25
to Levi Zim, Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Levi Zim
Ted (Chromium) Meyer voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Levi Zim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Levi Zim (Gerrit)
Jul 9, 2025, 8:47:58 PM7/9/25
to Ted (Chromium) Meyer, Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org
Levi Zim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Levi Zim . resolved
Should this be submitted after a ffmpeg roll so that the copy_config.sh changes are picked up? Or it could be submitted now?
In any case, I haven't got CQ permission yet so I need someone else to help me submit it. Thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jul 9, 2025, 8:58:17 PM7/9/25
to Levi Zim, Ted (Chromium) Meyer, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Levi Zim
Dale Curtis voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Levi Zim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jul 9, 2025, 8:58:37 PM7/9/25
to Levi Zim, Chromium LUCI CQ, Ted (Chromium) Meyer, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Levi Zim
Dale Curtis added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Levi Zim . resolved
Should this be submitted after a ffmpeg roll so that the copy_config.sh changes are picked up? Or it could be submitted now?
In any case, I haven't got CQ permission yet so I need someone else to help me submit it. Thanks!
Dale Curtis
I'm about to run an ffmpeg roll and will try this later this week.
Related details
Attention is currently required from:
- Levi Zim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 9, 2025, 9:04:31 PM7/9/25
to Levi Zim, Dale Curtis, Ted (Chromium) Meyer, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ffmpeg] add linux riscv64 support
This CL introduces support for linux riscv64 platform into
the build scripts of ffmpeg.
Bug: 42050595
Change-Id: Iee99bb945d6a71f309a5ad23ab20e2990b4d3207
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Reviewed-by: Ted (Chromium) Meyer <tmath...@chromium.org>
Commit-Queue: Dale Curtis <dalec...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1484701}
Files:
- M media/ffmpeg/scripts/build_ffmpeg.py
- M media/ffmpeg/scripts/generate_gn.py
- M media/ffmpeg/scripts/generate_gn_unittest.py
- M media/ffmpeg/scripts/robo_build.py
- M media/ffmpeg/scripts/robo_lib/config.py
- M media/ffmpeg/scripts/robo_setup.py
Change size: S
Delta: 6 files changed, 29 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis, +1 by Ted (Chromium) Meyer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages