[CVC storage IOS] Fix TestAddCardWithCvcRecordsUserAction [chromium/src : refs/branch-heads/7499]
0 views
Skip to first unread message
yiwen qian (Gerrit)
Nov 12, 2025, 6:23:35 PM (11 hours ago) Nov 12
to AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org
yiwen qian abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
Nov 12, 2025, 6:29:23 PM (11 hours ago) Nov 12
to AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org
yiwen qian restored this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Nov 12, 2025, 6:32:20 PM (11 hours ago) Nov 12
to yiwen qian, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
Nov 12, 2025, 6:36:13 PM (11 hours ago) Nov 12
to Tommy Martino, Rubber Stamper, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino
yiwen qian added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
yiwen qian . resolved
Hi Tommy, could you please review this CL? Thank you!
Related details
Attention is currently required from:
- Tommy Martino
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Donnelly (Gerrit)
Nov 12, 2025, 7:10:02 PM (10 hours ago) Nov 12
to yiwen qian, Justin Donnelly, Tommy Martino, Rubber Stamper, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino and yiwen qian
Justin Donnelly voted and added 1 comment![]( "Open in Gerrit")
Votes added by Justin Donnelly
| Code-Review | +1 |
1 comment
Patchset-level comments
Justin Donnelly . resolved
lgtm based on the fact that this is a clean cherry pick of a test file only change
Related details
Attention is currently required from:
- Tommy Martino
- yiwen qian
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Caroline Rising (Gerrit)
Nov 12, 2025, 7:26:00 PM (10 hours ago) Nov 12
to yiwen qian, Chromium LUCI CQ, Justin Donnelly, Tommy Martino, Rubber Stamper, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino and yiwen qian
Caroline Rising voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Tommy Martino
- yiwen qian
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
yiwen qian (Gerrit)
Nov 12, 2025, 8:23:45 PM (9 hours ago) Nov 12
to Caroline Rising, Chromium LUCI CQ, Justin Donnelly, Tommy Martino, Rubber Stamper, AyeAye, feature-me...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino
yiwen qian voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Tommy Martino
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Nov 12, 2025, 10:47:22 PM (7 hours ago) Nov 12
to Chrome Cherry Picker, Oleksandr Tara, AyeAye, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org, feature-me...@chromium.org
Rubber Stamper voted![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2025, 11:22:26 PM (6 hours ago) Nov 12
to Chrome Cherry Picker, Oleksandr Tara, Rubber Stamper, AyeAye, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M143] Fix TestAddCardWithCvcRecordsUserAction
Original change's description:
> Fix TestAddCardWithCvcRecordsUserAction
>
> Not familiar with the codebase but it seems like the card the test tries
> to add is already expired. It is therefore not added. I've tested the
> fix locally and the test passes.
>
> This and the next test should probably be updated because they will
> start failing in a year.
>
> Bug: 457076512
> Change-Id: I98c37daf6663a4638948b6ac9813f3b621ac7cee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7112519
> Owners-Override: Oleksandr Tara <ot...@google.com>
> Reviewed-by: Ioana Pandele <ioa...@chromium.org>
> Commit-Queue: Oleksandr Tara <ot...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1539306}
(cherry picked from commit 6048d00d13ebd0205553a4010618be95ed4ce39b)
Bug: 460251804,457076512
Change-Id: I98c37daf6663a4638948b6ac9813f3b621ac7cee
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7499@{#1573}
Cr-Branched-From: b30439823e5177773584139e72e0593e36863899-refs/heads/main@{#1536371}
Files:
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_add_credit_card_mediator_unittest.mm
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/branch-heads/7499
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages