Add some missing includes of //ui/views/layout/layout_provider.h [chromium/src : main]
David Sanders (Gerrit)
David Sanders added 13 comments![]( "Open in Gerrit")
Taking a new approach to make these quicker to review - each file includes a comment on the line that has usage requiring the include (and the associated build error and link as supporting evidence). These are split off from another CL that's removing an include.
I recommend using the "Comments" tab to review as it efficiently provides all the context with these comments.
set_fixed_width(views::LayoutProvider::Get()->GetDistanceMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
set_fixed_width(views::LayoutProvider::Get()->GetDistanceMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
model_host->set_fixed_width(views::LayoutProvider::Get()->GetDistanceMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
? overlay_web_view_->GetLayoutProvider()->GetCornerRadiusMetric(`member access into incomplete type 'const LayoutProvider'`
views::LayoutProvider::Get()->GetDistanceMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
views::LayoutProvider::Get()->GetDistanceMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
views::LayoutProvider::Get()->GetCornerRadiusMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
set_fixed_width(views::LayoutProvider::Get()->GetDistanceMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
return views::LayoutProvider::Get()->GetCornerRadiusMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
void SetWidth(views::DistanceMetric metric);`no type named 'DistanceMetric' in namespace 'views'`
https://ci.chromium.org/b/8688028021063897969
Note: `views::DistanceMetric` is an enum and cannot be forward declared.
const auto* layout_provider = views::LayoutProvider::Get();`incomplete type 'views::LayoutProvider' named in nested name specifier`
delegate->set_fixed_width(views::LayoutProvider::Get()->GetDistanceMetric(`incomplete type 'views::LayoutProvider' named in nested name specifier`
Related details
- David Roger
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Roger (Gerrit)
David Roger voted Code-Review+1![]( "Open in Gerrit")
- David Sanders
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Sanders (Gerrit)
David Sanders voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Sanders
| Commit-Queue | +2 |
1 comment
Taking a new approach to make these quicker to review - each file includes a comment on the line that has usage requiring the include (and the associated build error and link as supporting evidence). These are split off from another CL that's removing an include.
I recommend using the "Comments" tab to review as it efficiently provides all the context with these comments.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Add some missing includes of //ui/views/layout/layout_provider.h
- M chrome/browser/enterprise/connectors/analysis/content_analysis_dialog_delegate.cc
- M chrome/browser/enterprise/data_controls/desktop_data_controls_dialog.cc
- M chrome/browser/ssl/ask_before_http_dialog_controller.cc
- M chrome/browser/ui/lens/overlay_base_controller.cc
- M chrome/browser/ui/views/autofill/address_sign_in_promo_view.cc
- M chrome/browser/ui/views/bookmarks/bookmark_sign_in_promo_bubble_view.cc
- M chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
- M chrome/browser/ui/views/passwords/shared_passwords_notification_view.cc
- M chrome/browser/ui/views/search_engine_choice/search_engine_choice_dialog_view.cc
- M chrome/browser/ui/views/user_education/ios_promo_bubble_view.cc
- M chrome/browser/ui/views/user_education/ios_promo_bubble_view.h
- M chrome/browser/ui/views/web_apps/isolated_web_apps/isolated_web_app_installer_view_controller.cc
Code-Review: +1 by David Roger
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |