media: Fix data races in VEA factory static initializers [chromium/src : main]

0 views
Skip to first unread message

Eugene Zemtsov (Gerrit)

unread,
Apr 1, 2026, 8:50:34 PM (23 hours ago) Apr 1
to Eugene Zemtsov, Dale Curtis, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Dale Curtis

Eugene Zemtsov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a3a1a97ca45431133bc1da63438b8bd52bd4ba0
Gerrit-Change-Number: 7722803
Gerrit-PatchSet: 1
Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 00:50:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
12:45 PM (7 hours ago) 12:45 PM
to Eugene Zemtsov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Eugene Zemtsov

Dale Curtis voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0a3a1a97ca45431133bc1da63438b8bd52bd4ba0
    Gerrit-Change-Number: 7722803
    Gerrit-PatchSet: 1
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 16:45:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Eugene Zemtsov (Gerrit)

    unread,
    3:29 PM (4 hours ago) 3:29 PM
    to Eugene Zemtsov, Dale Curtis, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org

    Eugene Zemtsov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0a3a1a97ca45431133bc1da63438b8bd52bd4ba0
    Gerrit-Change-Number: 7722803
    Gerrit-PatchSet: 2
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 19:29:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    3:52 PM (4 hours ago) 3:52 PM
    to Eugene Zemtsov, Dale Curtis, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    1 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: media/gpu/gpu_video_encode_accelerator_factory.cc
    Insertions: 4, Deletions: 0.

    @@ -340,6 +340,10 @@
    static base::NoDestructor<VideoEncodeAccelerator::SupportedProfiles>
    second_try_profiles(GetSupportedProfilesInternal(
    gpu_preferences, gpu_workarounds, gpu_device));
    + if (second_try_profiles->empty()) {
    + return GetSupportedProfilesInternal(gpu_preferences, gpu_workarounds,
    + gpu_device);
    + }
    return *second_try_profiles;
    }
    #endif
    ```

    Change information

    Commit message:
    media: Fix data races in VEA factory static initializers

    We stopped changing static variables and only initialize them once.
    Bug: 498352423
    Change-Id: I0a3a1a97ca45431133bc1da63438b8bd52bd4ba0
    Reviewed-by: Dale Curtis <dalec...@chromium.org>
    Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1609439}
    Files:
    • M media/gpu/gpu_video_encode_accelerator_factory.cc
    Change size: M
    Delta: 1 file changed, 75 insertions(+), 59 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Dale Curtis
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0a3a1a97ca45431133bc1da63438b8bd52bd4ba0
    Gerrit-Change-Number: 7722803
    Gerrit-PatchSet: 3
    Gerrit-Owner: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages