Guard bitstream audio output creation behind BUILDFLAGs [chromium/src : main]
Dale Curtis (Gerrit)
Dale Curtis voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Chromium IPC Reviews
- Olga Sharonova
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: aj...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): aj...@chromium.org
Reviewer source(s):
aj...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Alex Gough
- Olga Sharonova
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Thomas Guilbert added 1 comment![]( "Open in Gerrit")
#if BUILDFLAG(ENABLE_PASSTHROUGH_AUDIO_CODECS)
output_bus_->set_is_bitstream_format(audio_parameters_.IsBitstreamFormat());
#endifCould we check for `audio_parameters_.IsBitstreamFormat()` in the ctor too ? I am weary of what happens if we don't set it here, but we still pass `output_bus_` to `render_callback_->render()` below.
Possibly moot... I just don't have all the code paths fresh in my memory.
Related details
- Alex Gough
- Dale Curtis
- Olga Sharonova
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Gough (Gerrit)
Alex Gough voted and added 1 comment![]( "Open in Gerrit")
- Dale Curtis
- Olga Sharonova
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Commit-Queue | +1 |
1 comment
#if BUILDFLAG(ENABLE_PASSTHROUGH_AUDIO_CODECS)
output_bus_->set_is_bitstream_format(audio_parameters_.IsBitstreamFormat());
#endifCould we check for `audio_parameters_.IsBitstreamFormat()` in the ctor too ? I am weary of what happens if we don't set it here, but we still pass `output_bus_` to `render_callback_->render()` below.
Possibly moot... I just don't have all the code paths fresh in my memory.
- Alex Gough
- Olga Sharonova
- Thomas Guilbert
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |