Clarify ScreenCaptureKit filter update behavior in NativeScreenCapturePickerMac. [chromium/src : main]
0 views
Skip to first unread message
Johannes Kron (Gerrit)
8:48 AM (6 hours ago) 8:48 AM
to Tove Petersson, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Tove Petersson
Johannes Kron voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Tove Petersson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tove Petersson (Gerrit)
9:52 AM (5 hours ago) 9:52 AM
to Johannes Kron, Chromium LUCI CQ, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Johannes Kron
Tove Petersson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tove Petersson
| Code-Review | +1 |
1 comment
Commit Message
Line 9, Patchset 1 (Latest):
Adds a comment explaining that when a ScreenCaptureKit stream is already active, the native macOS UI updates the content filter automatically, so no manual call to `[stream updateContentFilter...]` is needed. The session's filter is updated to ensure it's preserved.Tove Petersson . unresolved
nit: linebreaks
Related details
Attention is currently required from:
- Johannes Kron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Kron (Gerrit)
1:22 PM (2 hours ago) 1:22 PM
to Tove Petersson, Chromium LUCI CQ, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org
Johannes Kron voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Kron
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Commit Message
Line 9, Patchset 1:
Adds a comment explaining that when a ScreenCaptureKit stream is already active, the native macOS UI updates the content filter automatically, so no manual call to `[stream updateContentFilter...]` is needed. The session's filter is updated to ensure it's preserved.Tove Petersson . resolved
Johannes Kronnit: linebreaks
Thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:25 PM (2 hours ago) 1:25 PM
to Johannes Kron, Tove Petersson, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Clarify ScreenCaptureKit filter update behavior in NativeScreenCapturePickerMac.
Adds a comment explaining that when a ScreenCaptureKit stream is already
active, the native macOS UI updates the content filter automatically, so
no manual call to `[stream updateContentFilter...]` is needed. The
session's filter is updated to ensure it's preserved.
Bug: 505252445
Change-Id: I9921d226955967dccd75c8980f84fb2f1304d52a
Auto-Submit: Johannes Kron <kr...@chromium.org>
Reviewed-by: Tove Petersson <to...@chromium.org>
Commit-Queue: Johannes Kron <kr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1619619}
Files:
- M content/browser/media/capture/native_screen_capture_picker_mac.mm
Change size: XS
Delta: 1 file changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tove Petersson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages