[iOS][mvt-customization] Show in-product help for pin most visited site [chromium/src : main]

[Ginny Huang (Gerrit)]

Attention needed from Benjamin Williams

Ginny Huang voted and added 1 comment

Votes added by Ginny Huang

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Ginny Huang . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Benjamin Williams

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 6

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Benjamin Williams <bwwil...@google.com>

Gerrit-Comment-Date: Wed, 14 Jan 2026 23:13:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ginny Huang (Gerrit)]

Attention needed from Benjamin Williams

Ginny Huang added 1 comment

Commit Message

Line 14, Patchset 6 (Latest):currently used for placeholder purpose to mimic the asynchronization.

Ginny Huang . unresolved

Reason why I'm not using the task runner - might not be worth importing a new header if I'm removing it soon!

Open in Gerrit

Related details

Attention is currently required from:

• Benjamin Williams

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 6

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Benjamin Williams <bwwil...@google.com>

Gerrit-Comment-Date: Wed, 14 Jan 2026 23:14:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ginny Huang (Gerrit)]

Attention needed from Benjamin Williams

Ginny Huang voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Benjamin Williams

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 7

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Benjamin Williams <bwwil...@google.com>

Gerrit-Comment-Date: Wed, 14 Jan 2026 23:30:14 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ginny Huang (Gerrit)]

Attention needed from Benjamin Williams

Ginny Huang voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Benjamin Williams

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 8

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Benjamin Williams <bwwil...@google.com>

Gerrit-Comment-Date: Wed, 14 Jan 2026 23:36:55 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ginny Huang (Gerrit)]

Attention needed from Scott Yoder

Ginny Huang added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Ginny Huang . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Scott Yoder

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 8

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Scott Yoder <scott...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Scott Yoder <scott...@google.com>

Gerrit-Comment-Date: Thu, 15 Jan 2026 17:48:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ginny Huang (Gerrit)]

Ginny Huang removed Scott Yoder from this change

Deleted Reviewers:

• Scott Yoder

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteReviewer

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 10

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

[Ginny Huang (Gerrit)]

Attention needed from Benjamin Williams

Ginny Huang voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

• Benjamin Williams

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 10

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Benjamin Williams <bwwil...@google.com>

Gerrit-Comment-Date: Fri, 16 Jan 2026 01:26:40 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Benjamin Williams (Gerrit)]

Attention needed from Ginny Huang

Benjamin Williams voted and added 6 comments

Votes added by Benjamin Williams

Code-Review

+1

6 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Benjamin Williams . resolved

LGTM with comments

Commit Message

Line 13, Patchset 10 (Latest):past week" is not yet implemented yet. A "dispatch to main queue" is

Benjamin Williams . unresolved

Nit: s/`"not yet implemented yet"`/`"not implemented yet"`

Line 14, Patchset 6:currently used for placeholder purpose to mimic the asynchronization.

Ginny Huang . resolved

Reason why I'm not using the task runner - might not be worth importing a new header if I'm removing it soon!

Benjamin Williams

Ack!

File ios/chrome/browser/bubble/ui_bundled/bubble_presenter.mm

Line 540, Patchset 10 (Latest):- (void)presentPinSiteToMostVisitedTilesBubble {

Benjamin Williams . unresolved

Other methods in this file [check](https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/bubble/ui_bundled/bubble_presenter.mm;l=226-233?q=_readerModeOptionsBubblePresenter) `-canPresentBubble` and use `_layoutGuideCenter` before presenting. Should we do the same?

File ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.mm

Line 576, Patchset 10 (Latest):- (void)maybeDisplayIPH {

Benjamin Williams . unresolved

Should you also early exit if the MVTs count is zero?

Line 586, Patchset 10 (Latest): id<HelpCommands> helpHandler = self.helpHandler;

Benjamin Williams . unresolved

Should you weakify `helpHandler`?

Open in Gerrit

Related details

Attention is currently required from:

• Ginny Huang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 10

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ginny Huang <ginny...@chromium.org>

Gerrit-Comment-Date: Fri, 16 Jan 2026 16:47:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Ginny Huang <ginny...@chromium.org>

[Ginny Huang (Gerrit)]

Ginny Huang voted and added 4 comments

Votes added by Ginny Huang

Auto-Submit	+1
Commit-Queue	+2

4 comments

Commit Message

Line 13, Patchset 10:past week" is not yet implemented yet. A "dispatch to main queue" is

Benjamin Williams . resolved

Nit: s/`"not yet implemented yet"`/`"not implemented yet"`

Ginny Huang

Done

File ios/chrome/browser/bubble/ui_bundled/bubble_presenter.mm

Line 540, Patchset 10:- (void)presentPinSiteToMostVisitedTilesBubble {

Benjamin Williams . resolved

Other methods in this file [check](https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/bubble/ui_bundled/bubble_presenter.mm;l=226-233?q=_readerModeOptionsBubblePresenter) `-canPresentBubble` and use `_layoutGuideCenter` before presenting. Should we do the same?

Ginny Huang

I think the `_layoutGuideCenter` check is redundant - we can't guarantee it's onscreen just because the view is locatable, and only the Feed IPH bubbles are checking it. Added the `canPresentBubble`.

File ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.mm

Line 576, Patchset 10:- (void)maybeDisplayIPH {

Benjamin Williams . resolved

Should you also early exit if the MVTs count is zero?

Ginny Huang

That's in the next CL :) This one is just making sure that the bubble shows up at the right place.

Line 586, Patchset 10: id<HelpCommands> helpHandler = self.helpHandler;

Benjamin Williams . resolved

Should you weakify `helpHandler`?

Ginny Huang

Pretty sure not - as the help handler doesn't own the block, retaining a strong reference in the block will not create a circular reference. The bubble presenter will take care of not showing this when the layout guide is invisible.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 12

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 16 Jan 2026 17:53:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Benjamin Williams <bwwil...@google.com>

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

10 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ios/chrome/browser/bubble/ui_bundled/bubble_presenter.mm
Insertions: 3, Deletions: 0.

@@ -538,6 +538,9 @@
 }
 
 - (void)presentPinSiteToMostVisitedTilesBubble {
+  if (![self canPresentBubble]) {
+    return;
+  }
   NSString* text = l10n_util::GetNSString(
       IDS_IOS_CONTENT_SUGGESTIONS_PIN_SITE_IN_PRODUCT_HELP);
   BubbleViewControllerPresenter* presenter = [self
```

Change information

Commit message:

[iOS][mvt-customization] Show in-product help for pin most visited site

This CL adds the UI that displays the IPH for MVT customization - adding
the strings and anchoring the bubble to the correct UI element.

The condition that "the user has visited the same site >= 3 times in the
past week" is not implemented yet. A "dispatch to main queue" is

currently used for placeholder purpose to mimic the asynchronization.

Screenshot: https://screenshot.googleplex.com/8Tp2WKYWr2SudmD

Bug: 475119329

Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7459722

Reviewed-by: Benjamin Williams <bwwil...@google.com>

Auto-Submit: Ginny Huang <ginny...@chromium.org>

Commit-Queue: Ginny Huang <ginny...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1570529}

Files:

• M ios/chrome/app/strings/ios_strings.grd
• A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_CONTENT_SUGGESTIONS_PIN_SITE_IN_PRODUCT_HELP.png.sha1
• M ios/chrome/browser/bubble/public/in_product_help_type.h
• M ios/chrome/browser/bubble/ui_bundled/bubble_presenter.h
• M ios/chrome/browser/bubble/ui_bundled/bubble_presenter.mm
• M ios/chrome/browser/bubble/ui_bundled/bubble_presenter_coordinator.mm
• M ios/chrome/browser/content_suggestions/coordinator/content_suggestions_coordinator.mm
• M ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.h
• M ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.mm
• M ios/chrome/browser/content_suggestions/most_visited_tiles/ui/most_visited_tiles_collection_view.mm

Change size: M

Delta: 10 files changed, 69 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Benjamin Williams

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I425f0ca198d448041b16d5620601f76682ffa140

Gerrit-Change-Number: 7459722

Gerrit-PatchSet: 13

Gerrit-Owner: Ginny Huang <ginny...@chromium.org>

Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org