Fully relax AVC/HEVC analysis classes. Used only for logs/keyframes [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
Jun 18, 2026, 6:34:50 PM (10 days ago) Jun 18
to Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov

Dale Curtis voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1e2265c6a8b3e26ed3680b7e191a0c87e8942a0f
Gerrit-Change-Number: 7965302
Gerrit-PatchSet: 1
Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 22:34:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eugene Zemtsov (Gerrit)

unread,
Jun 26, 2026, 4:24:56 PM (2 days ago) Jun 26
to Dale Curtis, Eugene Zemtsov, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis

Eugene Zemtsov voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1e2265c6a8b3e26ed3680b7e191a0c87e8942a0f
    Gerrit-Change-Number: 7965302
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 20:24:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 26, 2026, 5:34:44 PM (2 days ago) Jun 26
    to Dale Curtis, Eugene Zemtsov, Code Review Nudger, chromium...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fully relax AVC/HEVC analysis classes. Used only for logs/keyframes

    The analysis portions of the AVC/HEVC classes are only used for
    generating non-conformant logs and key-frame detection. As such it
    doesn't really make sense to bail out early upon non-conformance when
    the packet may still be a key-frame. This change fully relaxes the
    parsers so that both is_conformant and is_keyframe will be populated.

    R=eugene
    Fixed: 519012430
    Change-Id: I1e2265c6a8b3e26ed3680b7e191a0c87e8942a0f
    Auto-Submit: Dale Curtis <dalec...@chromium.org>
    Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
    Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1653458}
    Files:
    • M media/formats/mp4/avc.cc
    • M media/formats/mp4/avc.h
    • M media/formats/mp4/avc_unittest.cc
    • M media/formats/mp4/hevc.cc
    • M media/formats/mp4/hevc.h
    • M media/formats/mp4/hevc_unittest.cc
    Change size: M
    Delta: 6 files changed, 90 insertions(+), 59 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Eugene Zemtsov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1e2265c6a8b3e26ed3680b7e191a0c87e8942a0f
    Gerrit-Change-Number: 7965302
    Gerrit-PatchSet: 2
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages