Remove superfluous callback.h includes from //ui headers [chromium/src : main]

0 views
Skip to first unread message

Nico Weber (Gerrit)

unread,
Nov 12, 2025, 7:25:55 AMNov 12
to Lei Zhang, Nico Weber, AyeAye, chromium...@chromium.org, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, Chromium LUCI CQ, feature-me...@chromium.org, jbauma...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Lei Zhang

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Code-Review+1
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nico Weber . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I07e93692f9a78f9db9c3ed51de7d2b9d5c8bc2ab
Gerrit-Change-Number: 7139545
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 12:25:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Nov 12, 2025, 7:27:13 PMNov 12
to Lei Zhang, Nico Weber, AyeAye, chromium...@chromium.org, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, Chromium LUCI CQ, feature-me...@chromium.org, jbauma...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I07e93692f9a78f9db9c3ed51de7d2b9d5c8bc2ab
Gerrit-Change-Number: 7139545
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Comment-Date: Thu, 13 Nov 2025 00:27:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 12, 2025, 7:30:10 PMNov 12
to Lei Zhang, Nico Weber, AyeAye, chromium...@chromium.org, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, feature-me...@chromium.org, jbauma...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Remove superfluous callback.h includes from //ui headers

Remove unused includes mostly found by heuristics in headers that do not
contain keywords like "Callback" or "Closure".
Bug: 40318405
Change-Id: I07e93692f9a78f9db9c3ed51de7d2b9d5c8bc2ab
Reviewed-by: Nico Weber <tha...@chromium.org>
Owners-Override: Nico Weber <tha...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544041}
Files:
  • M ui/accelerated_widget_mac/ca_transaction_observer.h
  • M ui/android/window_android.h
  • M ui/base/accelerators/media_keys_listener.h
  • M ui/base/x/selection_owner.h
  • M ui/base/x/x11_desktop_window_move_client.h
  • M ui/compositor/layer_animator_collection.h
  • M ui/display/win/color_profile_reader.h
  • M ui/events/ozone/evdev/imposter_checker_evdev_state.h
  • M ui/events/ozone/evdev/input_device_factory_evdev.h
  • M ui/events/platform/x11/x11_event_source.h
  • M ui/gl/dc_layer_overlay_params.h
  • M ui/message_center/message_center_impl.h
  • M ui/ozone/common/gl_ozone_egl.h
  • M ui/ozone/platform/drm/common/drm_wrapper.h
  • M ui/ozone/platform/wayland/test/test_output.h
  • M ui/views/animation/ink_drop.h
  • M ui/views/examples/ink_drop_example.h
  • M ui/views/widget/desktop_aura/desktop_drag_drop_client_ozone_linux.h
Change size: S
Delta: 18 files changed, 3 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nico Weber
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I07e93692f9a78f9db9c3ed51de7d2b9d5c8bc2ab
Gerrit-Change-Number: 7139545
Gerrit-PatchSet: 3
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages