Remove unused includes from WebAudio-related files [chromium/src : main]

0 views
Skip to first unread message

Michael Wilson (Gerrit)

unread,
12:19 AM (19 hours ago) 12:19 AM
to Mahesh Kannan, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, toyosh...@chromium.org
Attention needed from Mahesh Kannan

Michael Wilson added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Michael Wilson . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Mahesh Kannan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ca3f9bab85eda19a007f97617a4fa8140fbbee2
Gerrit-Change-Number: 7722260
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Wilson <mjwi...@chromium.org>
Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>
Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-Attention: Mahesh Kannan <kmah...@google.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 04:19:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mahesh Kannan (Gerrit)

unread,
2:37 PM (5 hours ago) 2:37 PM
to Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, toyosh...@chromium.org
Attention needed from Michael Wilson

Mahesh Kannan voted and added 1 comment

Votes added by Mahesh Kannan

Code-Review+1

1 comment

Patchset-level comments
Mahesh Kannan . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Wilson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ca3f9bab85eda19a007f97617a4fa8140fbbee2
    Gerrit-Change-Number: 7722260
    Gerrit-PatchSet: 2
    Gerrit-Owner: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-Attention: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 18:37:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Michael Wilson (Gerrit)

    unread,
    2:37 PM (5 hours ago) 2:37 PM
    to Mahesh Kannan, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, toyosh...@chromium.org

    Michael Wilson voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ca3f9bab85eda19a007f97617a4fa8140fbbee2
    Gerrit-Change-Number: 7722260
    Gerrit-PatchSet: 2
    Gerrit-Owner: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 18:37:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    2:42 PM (5 hours ago) 2:42 PM
    to Mahesh Kannan, chromium...@chromium.org, Hongchan Choi, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, toyosh...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove unused includes from WebAudio-related files

    This should cause no functional change.
    Change-Id: I8ca3f9bab85eda19a007f97617a4fa8140fbbee2
    Commit-Queue: Michael Wilson <mjwi...@chromium.org>
    Reviewed-by: Mahesh Kannan <kmah...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1609390}
    Files:
    • M third_party/blink/renderer/modules/webaudio/audio_buffer_source_node.cc
    • M third_party/blink/renderer/modules/webaudio/audio_node_input.cc
    • M third_party/blink/renderer/modules/webaudio/audio_node_output.cc
    • M third_party/blink/renderer/modules/webaudio/audio_scheduled_source_node.cc
    • M third_party/blink/renderer/modules/webaudio/audio_summing_junction.cc
    • M third_party/blink/renderer/modules/webaudio/base_audio_context.cc
    • M third_party/blink/renderer/modules/webaudio/convolver_node.cc
    • M third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.cc
    • M third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.cc
    • M third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.cc
    • M third_party/blink/renderer/modules/webaudio/oscillator_handler.cc
    • M third_party/blink/renderer/modules/webaudio/realtime_audio_destination_handler.h
    • M third_party/blink/renderer/modules/webaudio/script_processor_node.cc
    • M third_party/blink/renderer/modules/webaudio/stereo_panner_node.h
    • M third_party/blink/renderer/modules/webmidi/midi_access.cc
    • M third_party/blink/renderer/platform/audio/audio_bus.cc
    • M third_party/blink/renderer/platform/audio/audio_channel.cc
    • M third_party/blink/renderer/platform/audio/cpu/arm/delay_neon.cc
    • M third_party/blink/renderer/platform/audio/equal_power_panner.cc
    • M third_party/blink/renderer/platform/audio/hrtf_database.cc
    • M third_party/blink/renderer/platform/audio/hrtf_database_loader.cc
    • M third_party/blink/renderer/platform/audio/hrtf_elevation.cc
    • M third_party/blink/renderer/platform/audio/hrtf_elevation.h
    • M third_party/blink/renderer/platform/audio/hrtf_kernel.h
    • M third_party/blink/renderer/platform/audio/push_pull_fifo.cc
    • M third_party/blink/renderer/platform/audio/stereo_panner.cc
    Change size: S
    Delta: 26 files changed, 2 insertions(+), 45 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mahesh Kannan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ca3f9bab85eda19a007f97617a4fa8140fbbee2
    Gerrit-Change-Number: 7722260
    Gerrit-PatchSet: 3
    Gerrit-Owner: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mahesh Kannan <kmah...@google.com>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages