[WPT] Move credential-management/ FedCM tests to dedicated directory [chromium/src : main]

0 views
Skip to first unread message

Peter Kotwicz (Gerrit)

unread,
Jul 2, 2024, 6:09:38 PM (2 days ago) Jul 2
to Christian Biesinger, chromium...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mkwst+w...@chromium.org
Attention needed from Christian Biesinger

Peter Kotwicz added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Peter Kotwicz . resolved

Christian can you please take a look? I made Nicolas the suggested OWNER because is listed as a spec editor.

Open in Gerrit

Related details

Attention is currently required from:
  • Christian Biesinger
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5509615b793a958061db6ddf8de75a267fe877ae
Gerrit-Change-Number: 5670976
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 22:09:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Christian Biesinger (Gerrit)

unread,
Jul 2, 2024, 6:16:06 PM (2 days ago) Jul 2
to Peter Kotwicz, Christian Biesinger, chromium...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mkwst+w...@chromium.org
Attention needed from Peter Kotwicz

Christian Biesinger voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Peter Kotwicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5509615b793a958061db6ddf8de75a267fe877ae
Gerrit-Change-Number: 5670976
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Attention: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 22:15:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
Jul 3, 2024, 11:01:25 AM (2 days ago) Jul 3
to Robert Flack, Christian Biesinger, chromium...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mkwst+w...@chromium.org
Attention needed from Robert Flack

Peter Kotwicz added 1 comment

Patchset-level comments
Peter Kotwicz . resolved

Rob can you please take a look at the
third_party/blink/web_tests/VirtualTestSuites change?

Open in Gerrit

Related details

Attention is currently required from:
  • Robert Flack
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5509615b793a958061db6ddf8de75a267fe877ae
Gerrit-Change-Number: 5670976
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Attention: Robert Flack <fla...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 15:01:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Robert Flack (Gerrit)

unread,
Jul 3, 2024, 4:12:26 PM (2 days ago) Jul 3
to Peter Kotwicz, Christian Biesinger, chromium...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mkwst+w...@chromium.org
Attention needed from Peter Kotwicz

Robert Flack voted and added 1 comment

Votes added by Robert Flack

Code-Review+1

1 comment

Patchset-level comments
Robert Flack . resolved

third_party/blink/web_tests/VirtualTestSuites lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Peter Kotwicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5509615b793a958061db6ddf8de75a267fe877ae
Gerrit-Change-Number: 5670976
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Attention: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 20:12:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Blink W3C Test Autoroller (Gerrit)

unread,
Jul 3, 2024, 4:32:54 PM (2 days ago) Jul 3
to Peter Kotwicz, Robert Flack, Christian Biesinger, chromium...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mkwst+w...@chromium.org
Attention needed from Peter Kotwicz

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/46993.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:
  • Peter Kotwicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5509615b793a958061db6ddf8de75a267fe877ae
Gerrit-Change-Number: 5670976
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 20:32:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
Jul 4, 2024, 9:04:39 PM (7 hours ago) Jul 4
to Blink W3C Test Autoroller, Robert Flack, Christian Biesinger, chromium...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mkwst+w...@chromium.org

Peter Kotwicz voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5509615b793a958061db6ddf8de75a267fe877ae
Gerrit-Change-Number: 5670976
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Jul 2024 01:04:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages