[Win] Limit HW decoder video memory usage behind flag. [chromium/src : main]
Dale Curtis (Gerrit)
Dale Curtis added 2 comments![]( "Open in Gerrit")
#if BUILDFLAG(IS_WIN)If we don't need to put this in a unit test, just putting in the .cc file is fine.
if (GetVideoMemoryUsageAndBudget(usage, budget)) {Since there's only one caller lets not have a complicated bool+outvar return type. Instead make the one method `HasSufficientVideoMemoryBudget()` and have it return false if not. Document the 0.85 as a constant with why it was chosen.
I could imagine instead of a percentage that we'd want to estimate how much memory will be allocated for N buffers * resolution.
I'm not as sure it makes sense to always keep us at 85% of the budget.
Related details
- Eugene Zemtsov
- Jianlin Qiu
- Rafael Cintron
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis added 1 comment![]( "Open in Gerrit")
As noted on the bug I can't reproduce on an NVIDIA GPU. So I wonder if this is instead a resource leak issue on Intel?
Jianlin Qiu (Gerrit)
Jianlin Qiu added 1 comment![]( "Open in Gerrit")
As noted on the bug I can't reproduce on an NVIDIA GPU. So I wonder if this is instead a resource leak issue on Intel?
I think it is. Maybe the right approach is to fix this in driver, instead of workaround with this CL. Let me talk to our driver team on this.
Related details
- Dale Curtis
- Rafael Cintron
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianlin Qiu (Gerrit)
Jianlin Qiu abandoned this change![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |