Refactor insert media request unittest params to be virtual [chromium/src : main]

0 views

Skip to first unread message

Michael Cui (Gerrit)

unread,

Jul 4, 2024, 1:43:50 AM (yesterday) Jul 4

to Michael Cui, Darren Shen, AyeAye, feature-me...@chromium.org

Attention needed from Darren Shen

Michael Cui voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Darren Shen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Darren Shen (Gerrit)

unread,

Jul 4, 2024, 6:43:05 PM (10 hours ago) Jul 4

to Michael Cui, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org

Attention needed from Michael Cui

Darren Shen voted and added 2 comments

Votes added by Darren Shen

Code-Review

2 comments

File ash/picker/picker_insert_media_request_unittest.cc

Line 33, Patchset 2 (Latest): virtual ~TestCase() {}

Darren Shen . unresolved

nit: `= default`

Line 45, Patchset 2 (Latest):// Both `testing::Values` and `testing::ValuesIn` do not support move-only

Darren Shen . resolved

lol