Lei Zhang (Gerrit)

unread,

Sep 19, 2025, 5:12:05 PM (2 days ago) Sep 19

to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Mathias Bynens, Chromium LUCI CQ, abigailbk...@google.com, ayman...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, dcheng+c...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, halliwe...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lucasrada...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org

Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Sep 19, 2025, 5:31:59 PM (2 days ago) Sep 19

to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Mathias Bynens, Chromium LUCI CQ, abigailbk...@google.com, ayman...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, dcheng+c...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, halliwe...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lucasrada...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org

Attention needed from Lei Zhang

Daniel Cheng voted and added 3 comments

Votes added by Daniel Cheng

Code-Review	+1
Owners-Override	+1

3 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Daniel Cheng . resolved

LGTM

File chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

Line 475, Patchset 1 (Latest): base::WriteJson(base::Value(std::move(result))).value_or("");

Daniel Cheng . unresolved

This should work:

```suggestion
      base::WriteJson(result).value_or("");
```

Line 1561, Patchset 1 (Latest): base::WriteJson(base::Value(std::move(response))).value_or(""));

Daniel Cheng . unresolved

```suggestion
          base::WriteJson(response).value_or(""));
```

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Sep 19, 2025, 8:27:43 PM (2 days ago) Sep 19

to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Mathias Bynens, Chromium LUCI CQ, abigailbk...@google.com, ayman...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, dcheng+c...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, halliwe...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lucasrada...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org

Lei Zhang voted and added 2 comments

Votes added by Lei Zhang

Commit-Queue

+1

2 comments

File chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

Line 475, Patchset 1: base::WriteJson(base::Value(std::move(result))).value_or("");

Daniel Cheng . resolved

This should work:

```suggestion
      base::WriteJson(result).value_or("");
```

Lei Zhang

Fix applied.

Yes, I'm aware of this. I'm just trying to have the AI do these transformations mechanically and was going to do a separate pass to simplify. But since the suggested edits are here, I applied them.

Line 1561, Patchset 1: base::WriteJson(base::Value(std::move(response))).value_or(""));

Daniel Cheng . resolved

```suggestion
          base::WriteJson(response).value_or(""));
```

Lei Zhang

Fix applied.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Sep 19, 2025, 11:44:54 PM (2 days ago) Sep 19

to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Mathias Bynens, Chromium LUCI CQ, abigailbk...@google.com, ayman...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, dcheng+c...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, halliwe...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lucasrada...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 19, 2025, 11:48:26 PM (2 days ago) Sep 19

to Lei Zhang, Daniel Cheng, AyeAye, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Mathias Bynens, abigailbk...@google.com, ayman...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, dcheng+c...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, halliwe...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lucasrada...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
Insertions: 2, Deletions: 4.

@@ -471,8 +471,7 @@
   base::Value::Dict result;
   ASSERT_TRUE(
       StatusOk(client.SendCommandAndGetResult("method", params, &result)));
-  std::string json =
-      base::WriteJson(base::Value(std::move(result))).value_or("");
+  std::string json = base::WriteJson(result).value_or("");
   ASSERT_STREQ("{\"param\":1}", json.c_str());
 }
 
@@ -1557,8 +1556,7 @@
       base::Value::Dict response;
       response.Set("id", cmd_id);
       response.Set("result", base::Value::Dict());
-      queued_response_.push(
-          base::WriteJson(base::Value(std::move(response))).value_or(""));
+      queued_response_.push(base::WriteJson(response).value_or(""));
 
       // Push one event.
       base::Value::Dict event;
```

Change information

Commit message:

Remove various deprecated base::JSONWriter::Write() calls

Mechanically switch from base::JSONWriter::Write() to base::WriteJson()
for callers that did not check the return value. Keep the existing
behavior and return an empty string on failure.

This CL was initially AI generated, with human touch-ups. Based on
https://crrev.com/1511773.

Bug: 443929217

Change-Id: I553734d931fd53901107f9cb73e52cec99f5443a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6969134

Commit-Queue: Lei Zhang <the...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1518300}

Files:

M base/trace_event/trace_config_unittest.cc
M chrome/browser/enterprise/remote_commands/rotate_attestation_credential_job.cc
M chrome/browser/extensions/api/web_request/web_request_apitest.cc
M chrome/browser/policy/test/promotional_tabs_enabled_policy_browsertest.cc
M chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
M chromecast/base/device_capabilities_impl_unittest.cc
M components/commerce/core/subscriptions/subscriptions_server_proxy.cc
M components/search_provider_logos/logo_cache.cc
M media/cast/encoding/fake_software_video_encoder.cc
M net/log/file_net_log_observer.cc
M net/log/file_net_log_observer_unittest.cc
M net/tools/net_watcher/net_watcher.cc
M ui/accessibility/platform/ax_platform_node_win.cc
M ui/base/clipboard/scoped_clipboard_writer.cc

Change size: M

Delta: 14 files changed, 22 insertions(+), 47 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Remove various deprecated base::JSONWriter::Write() calls [chromium/src : main]

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted and added 3 comments

Votes added by Daniel Cheng

3 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 2 comments

Votes added by Lei Zhang

2 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information