[iOS] Remove URLLoading command [chromium/src : main]
0 views
Skip to first unread message
Gauthier Ambard (Gerrit)
Jan 21, 2026, 11:12:13 AM (23 hours ago) Jan 21
to Chromium LUCI CQ, Ewann Pellé, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ewann Pellé
Gauthier Ambard voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
Jan 21, 2026, 11:41:59 AM (23 hours ago) Jan 21
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Ewann Pellé added 3 comments![]( "Open in Gerrit")
File ios/chrome/browser/omnibox/coordinator/omnibox_coordinator.mm
Line 169, Patchset 7 (Latest):
mediator.sceneState = browser->GetSceneState();Ewann Pellé . unresolved
Looks like the new line is not needed.
File ios/chrome/browser/omnibox/coordinator/omnibox_mediator.h
File ios/chrome/browser/omnibox/coordinator/omnibox_mediator.mm
Line 344, Patchset 7 (Latest):
if (weakSelf.URLLoadingBrowserAgent) {Ewann Pellé . unresolved
You should probably use the strong self pattern here as URLLoadingBrowserAgent is a c++ object. Same below.
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
4:19 AM (6 hours ago) 4:19 AM
to Chromium LUCI CQ, Ewann Pellé, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ewann Pellé
Gauthier Ambard voted and added 3 comments![]( "Open in Gerrit")
Votes added by Gauthier Ambard
| Commit-Queue | +1 |
3 comments
File ios/chrome/browser/omnibox/coordinator/omnibox_coordinator.mm
Looks like the new line is not needed.
Gauthier Ambard
Done
File ios/chrome/browser/omnibox/coordinator/omnibox_mediator.h
Line 19, Patchset 7:
@protocol OmniboxConsumer;Ewann Pellé . resolved
Gauthier Ambardsame line 18.
Done
File ios/chrome/browser/omnibox/coordinator/omnibox_mediator.mm
You should probably use the strong self pattern here as URLLoadingBrowserAgent is a c++ object. Same below.
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
4:29 AM (6 hours ago) 4:29 AM
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Ewann Pellé added 3 comments![]( "Open in Gerrit")
File ios/chrome/browser/location_bar/ui_bundled/location_bar_mediator.h
Line 16, Patchset 8 (Latest):
#import "ios/chrome/browser/location_bar/ui_bundled/location_bar_mutator.h"Ewann Pellé . unresolved
should be upper.
File ios/chrome/browser/menu/ui_bundled/browser_action_factory.mm
Line 427, Patchset 8 (Latest):
UrlLoadingBrowserAgent::FromBrowser(weakSelf.browser);Ewann Pellé . unresolved
I think if `weakSelf` or `weakSelf.browser` is nil, it will crash. This block should probably be moved in a method, same below.
File ios/chrome/browser/qr_scanner/test/DEPS
Line 2, Patchset 8 (Latest):
"+ios/chrome/browser"Ewann Pellé . unresolved
No guards to keep it ordered ?
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
8:17 AM (2 hours ago) 8:17 AM
to Chromium LUCI CQ, Ewann Pellé, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ewann Pellé
Gauthier Ambard voted and added 3 comments![]( "Open in Gerrit")
Votes added by Gauthier Ambard
| Commit-Queue | +1 |
3 comments
File ios/chrome/browser/location_bar/ui_bundled/location_bar_mediator.h
Line 16, Patchset 8:
#import "ios/chrome/browser/location_bar/ui_bundled/location_bar_mutator.h"Ewann Pellé . resolved
Gauthier Ambardshould be upper.
Done
File ios/chrome/browser/menu/ui_bundled/browser_action_factory.mm
I think if `weakSelf` or `weakSelf.browser` is nil, it will crash. This block should probably be moved in a method, same below.
Gauthier Ambard
I thought this was returning nil when given a nil browser. TIL.
File ios/chrome/browser/qr_scanner/test/DEPS
No guards to keep it ordered ?
Gauthier Ambard
That's allowing all includes on ios/chrome/browser. Probably none will be added.
I can still add it.
Related details
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
8:28 AM (2 hours ago) 8:28 AM
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Ewann Pellé voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
9:59 AM (1 hour ago) 9:59 AM
to Ewann Pellé, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Gauthier Ambard voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:02 AM (1 hour ago) 10:02 AM
to Gauthier Ambard, Ewann Pellé, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Remove URLLoading command
This should be split into the URL Loader browser agent and the command
to pass a query to the composebox.
Bug: 472279443
Change-Id: Ide7640b9405fdc429a6ef5b55a5544490616f7b7
Reviewed-by: Ewann Pellé <ewa...@chromium.org>
Commit-Queue: Gauthier Ambard <gam...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572975}
Files:
- M ios/chrome/browser/browser_view/ui_bundled/browser_coordinator.mm
- M ios/chrome/browser/browser_view/ui_bundled/browser_view_controller.h
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.h
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
- M ios/chrome/browser/lens_overlay/coordinator/BUILD.gn
- M ios/chrome/browser/lens_overlay/coordinator/lens_overlay_coordinator.mm
- M ios/chrome/browser/lens_overlay/coordinator/lens_overlay_coordinator_unittest.mm
- M ios/chrome/browser/location_bar/ui_bundled/BUILD.gn
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_coordinator.mm
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_mediator.h
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_mediator.mm
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_mediator_unittest.mm
- A ios/chrome/browser/location_bar/ui_bundled/location_bar_mutator.h
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_view_controller.h
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_view_controller.mm
- M ios/chrome/browser/menu/ui_bundled/browser_action_factory.mm
- M ios/chrome/browser/menu/ui_bundled/browser_action_factory_unittest.mm
- M ios/chrome/browser/omnibox/coordinator/omnibox_coordinator.mm
- M ios/chrome/browser/omnibox/coordinator/omnibox_mediator.h
- M ios/chrome/browser/omnibox/coordinator/omnibox_mediator.mm
- M ios/chrome/browser/omnibox/coordinator/popup/omnibox_popup_mediator.h
- M ios/chrome/browser/qr_scanner/coordinator/BUILD.gn
- A ios/chrome/browser/qr_scanner/coordinator/DEPS
- M ios/chrome/browser/qr_scanner/coordinator/qr_scanner_legacy_coordinator.mm
- A ios/chrome/browser/qr_scanner/coordinator/qr_scanner_mediator.h
- A ios/chrome/browser/qr_scanner/coordinator/qr_scanner_mediator.mm
- M ios/chrome/browser/qr_scanner/test/BUILD.gn
- A ios/chrome/browser/qr_scanner/test/DEPS
- M ios/chrome/browser/qr_scanner/test/qr_scanner_app_interface.h
- M ios/chrome/browser/qr_scanner/test/qr_scanner_app_interface.mm
- M ios/chrome/browser/qr_scanner/test/qr_scanner_view_controller_egtest.mm
- M ios/chrome/browser/qr_scanner/ui/BUILD.gn
- A ios/chrome/browser/qr_scanner/ui/DEPS
- M ios/chrome/browser/qr_scanner/ui/qr_scanner_view_controller.h
- M ios/chrome/browser/qr_scanner/ui/qr_scanner_view_controller.mm
- M ios/chrome/browser/scanner/ui_bundled/BUILD.gn
- A ios/chrome/browser/scanner/ui_bundled/DEPS
- A ios/chrome/browser/scanner/ui_bundled/scanner_mutator.h
- M ios/chrome/browser/scanner/ui_bundled/scanner_view_controller.h
- M ios/chrome/browser/scanner/ui_bundled/scanner_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/credit_card_scanner/credit_card_scanner_view_controller.h
- M ios/chrome/browser/shared/public/commands/BUILD.gn
- D ios/chrome/browser/shared/public/commands/load_query_commands.h
- M ios/chrome/browser/toolbar/legacy/ui_bundled/adaptive_toolbar_mediator.mm
- M ios/chrome/browser/toolbar/legacy/ui_bundled/adaptive_toolbar_mediator_unittest.mm
- M ios/public/provider/chrome/browser/voice_search/voice_search_controller.h
Change size: L
Delta: 46 files changed, 293 insertions(+), 255 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ewann Pellé
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages