Optimize IsDecoderConfigSupported for frequent calls [chromium/src : main]

0 views
Skip to first unread message

Ambareesh Balaji (Gerrit)

unread,
Nov 7, 2025, 9:14:44 PM (5 days ago) Nov 7
to Eugene Zemtsov, AyeAye, chromeos-gfx-...@google.com, media-cro...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib8928d22cf393034673fda9ee151904339b64bba
Gerrit-Change-Number: 7134158
Gerrit-PatchSet: 2
Gerrit-Owner: Ambareesh Balaji <ambaree...@gmail.com>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Comment-Date: Sat, 08 Nov 2025 02:14:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
Nov 11, 2025, 1:10:38 PM (2 days ago) Nov 11
to Ambareesh Balaji, Eugene Zemtsov, AyeAye, chromeos-gfx-...@google.com, media-cro...@chromium.org, feature-me...@chromium.org
Attention needed from Ambareesh Balaji

Dale Curtis voted and added 2 comments

Votes added by Dale Curtis

Code-Review+1

2 comments

File media/mojo/clients/mojo_codec_factory.h
Line 89, Patchset 3 (Latest): media::GpuVideoAcceleratorFactories::Supported
Dale Curtis . unresolved

Drop media:: on this new function -- it should be dropped in the whole file if you want to do that while you're here.

File media/mojo/clients/mojo_codec_factory.cc
Line 102, Patchset 3 (Latest): for (const auto& supported : *supported_decoder_configs_) {
Dale Curtis . unresolved
```
  return std::ranges::any_of(supported_config, [&](const auto& c) {
      return supported.Matches(c);
  }) ? kTrue : kFalse
```

If you want.

Open in Gerrit

Related details

Attention is currently required from:
  • Ambareesh Balaji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib8928d22cf393034673fda9ee151904339b64bba
Gerrit-Change-Number: 7134158
Gerrit-PatchSet: 3
Gerrit-Owner: Ambareesh Balaji <ambaree...@gmail.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-CC: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Ambareesh Balaji <ambaree...@gmail.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 18:10:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ambareesh Balaji (Gerrit)

unread,
Nov 11, 2025, 8:01:27 PM (2 days ago) Nov 11
to Dale Curtis, Eugene Zemtsov, AyeAye, chromeos-gfx-...@google.com, media-cro...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis

Ambareesh Balaji added 1 comment

File media/mojo/clients/mojo_codec_factory.h
Line 89, Patchset 3 (Latest): media::GpuVideoAcceleratorFactories::Supported
Dale Curtis . unresolved

Drop media:: on this new function -- it should be dropped in the whole file if you want to do that while you're here.

Ambareesh Balaji

Should dropping media:: from the file be done in this CL or a different one?

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib8928d22cf393034673fda9ee151904339b64bba
Gerrit-Change-Number: 7134158
Gerrit-PatchSet: 3
Gerrit-Owner: Ambareesh Balaji <ambaree...@gmail.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-CC: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 01:00:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
Nov 12, 2025, 1:29:18 PM (16 hours ago) Nov 12
to Ambareesh Balaji, Eugene Zemtsov, AyeAye, chromeos-gfx-...@google.com, media-cro...@chromium.org, feature-me...@chromium.org
Attention needed from Ambareesh Balaji

Dale Curtis added 1 comment

File media/mojo/clients/mojo_codec_factory.h
Line 89, Patchset 3 (Latest): media::GpuVideoAcceleratorFactories::Supported
Dale Curtis . unresolved

Drop media:: on this new function -- it should be dropped in the whole file if you want to do that while you're here.

Ambareesh Balaji

Should dropping media:: from the file be done in this CL or a different one?

Dale Curtis

Either is fine.

Open in Gerrit

Related details

Attention is currently required from:
  • Ambareesh Balaji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib8928d22cf393034673fda9ee151904339b64bba
Gerrit-Change-Number: 7134158
Gerrit-PatchSet: 3
Gerrit-Owner: Ambareesh Balaji <ambaree...@gmail.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-CC: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Attention: Ambareesh Balaji <ambaree...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 18:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ambareesh Balaji <ambaree...@gmail.com>
Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Ambareesh Balaji (Gerrit)

unread,
Nov 12, 2025, 6:51:01 PM (11 hours ago) Nov 12
to Dale Curtis, Eugene Zemtsov, AyeAye, chromeos-gfx-...@google.com, media-cro...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis

Ambareesh Balaji added 2 comments

File media/mojo/clients/mojo_codec_factory.h
Line 89, Patchset 3: media::GpuVideoAcceleratorFactories::Supported
Dale Curtis . resolved

Drop media:: on this new function -- it should be dropped in the whole file if you want to do that while you're here.

Ambareesh Balaji

Should dropping media:: from the file be done in this CL or a different one?

Dale Curtis

Either is fine.

Ambareesh Balaji

Done

File media/mojo/clients/mojo_codec_factory.cc
Line 102, Patchset 3: for (const auto& supported : *supported_decoder_configs_) {
Dale Curtis . resolved
```
  return std::ranges::any_of(supported_config, [&](const auto& c) {
      return supported.Matches(c);
  }) ? kTrue : kFalse
```

If you want.

Ambareesh Balaji

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib8928d22cf393034673fda9ee151904339b64bba
    Gerrit-Change-Number: 7134158
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ambareesh Balaji <ambaree...@gmail.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-CC: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Wed, 12 Nov 2025 23:50:35 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Nov 12, 2025, 7:04:06 PM (11 hours ago) Nov 12
    to Ambareesh Balaji, Eugene Zemtsov, AyeAye, chromeos-gfx-...@google.com, media-cro...@chromium.org, feature-me...@chromium.org
    Attention needed from Ambareesh Balaji

    Dale Curtis voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ambareesh Balaji
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib8928d22cf393034673fda9ee151904339b64bba
    Gerrit-Change-Number: 7134158
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ambareesh Balaji <ambaree...@gmail.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-CC: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Attention: Ambareesh Balaji <ambaree...@gmail.com>
    Gerrit-Comment-Date: Thu, 13 Nov 2025 00:03:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Thomas Guilbert (Gerrit)

    unread,
    12:39 AM (5 hours ago) 12:39 AM
    to Ambareesh Balaji, Thomas Guilbert, Dale Curtis, Eugene Zemtsov, AyeAye, chromeos-gfx-...@google.com, media-cro...@chromium.org, feature-me...@chromium.org
    Attention needed from Ambareesh Balaji

    Thomas Guilbert voted and added 1 comment

    Votes added by Thomas Guilbert

    Code-Review+1

    1 comment

    File media/mojo/clients/mojo_codec_factory.h
    Line 88, Patchset 5 (Latest): GpuVideoAcceleratorFactories::Supported IsDecoderConfigSupported(
    Thomas Guilbert . resolved

    TINY NIT: This could be a `std::optional<bool>` instead, if ever this was reused in a context that didn't care about the `GpuVideoAcceleratorFactories::Supported` type. Since there is one use, I won't hold up the review for this.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ambareesh Balaji
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib8928d22cf393034673fda9ee151904339b64bba
      Gerrit-Change-Number: 7134158
      Gerrit-PatchSet: 5
      Gerrit-Owner: Ambareesh Balaji <ambaree...@gmail.com>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
      Gerrit-CC: Eugene Zemtsov <eug...@chromium.org>
      Gerrit-Attention: Ambareesh Balaji <ambaree...@gmail.com>
      Gerrit-Comment-Date: Thu, 13 Nov 2025 05:39:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages