Replace mediation: 'immediate' with uiMode: 'immediate' [chromium/src : main]
0 views
Skip to first unread message
Adem Derinel (Gerrit)
10:18 AM (9 hours ago) 10:18 AM
to Ken Buchanan, Chromium LUCI CQ, Kaan Icer, Christian Biesinger, AyeAye, feature-me...@chromium.org, derinel+wat...@google.com, yigu+...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org
Attention needed from Ken Buchanan
Adem Derinel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Adem Derinel . resolved
Hi Ken, could you PTAL? Thanks in advance!
Related details
Attention is currently required from:
- Ken Buchanan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yi Gu (Gerrit)
10:23 AM (9 hours ago) 10:23 AM
to Adem Derinel, Ken Buchanan, Chromium LUCI CQ, Kaan Icer, Christian Biesinger, AyeAye, feature-me...@chromium.org, derinel+wat...@google.com, yigu+...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org
Attention needed from Adem Derinel and Ken Buchanan
Yi Gu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yi Gu . unresolved
drive-by: do you also plan to enforce `mediation: required` when `UiMode: immediate` is used?
Related details
Attention is currently required from:
- Adem Derinel
- Ken Buchanan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adem Derinel (Gerrit)
11:33 AM (8 hours ago) 11:33 AM
to Yi Gu, Ken Buchanan, Chromium LUCI CQ, Kaan Icer, Christian Biesinger, AyeAye, feature-me...@chromium.org, derinel+wat...@google.com, yigu+...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org
Attention needed from Ken Buchanan and Yi Gu
Adem Derinel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yi Gu . unresolved
drive-by: do you also plan to enforce `mediation: required` when `UiMode: immediate` is used?
Attention is currently required from:
- Ken Buchanan
- Yi Gu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Buchanan (Gerrit)
2:45 PM (5 hours ago) 2:45 PM
to Adem Derinel, Yi Gu, Chromium LUCI CQ, Kaan Icer, Christian Biesinger, AyeAye, feature-me...@chromium.org, derinel+wat...@google.com, yigu+...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org
Attention needed from Adem Derinel and Yi Gu
Ken Buchanan added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 5864, Patchset 4 (Latest):
name: "WebAuthenticationUiMode",Ken Buchanan . unresolved
Should we just get rid of this now?
After this, Immediate is non-functional if this is turned off. Is there a reason to have separate flags for immediate and uiMode?
Related details
Attention is currently required from:
- Adem Derinel
- Yi Gu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages