Replace mediation: 'immediate' with uiMode: 'immediate' [chromium/src : main]

0 views
Skip to first unread message

Adem Derinel (Gerrit)

unread,
10:18 AM (9 hours ago) 10:18 AM
to Ken Buchanan, Chromium LUCI CQ, Kaan Icer, Christian Biesinger, AyeAye, feature-me...@chromium.org, derinel+wat...@google.com, yigu+...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org
Attention needed from Ken Buchanan

Adem Derinel added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Adem Derinel . resolved

Hi Ken, could you PTAL? Thanks in advance!

Open in Gerrit

Related details

Attention is currently required from:
  • Ken Buchanan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I71ef9472a320c0f64132851379193ef1aa5fc388
Gerrit-Change-Number: 7491274
Gerrit-PatchSet: 4
Gerrit-Owner: Adem Derinel <der...@google.com>
Gerrit-Reviewer: Adem Derinel <der...@google.com>
Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
Gerrit-Comment-Date: Mon, 19 Jan 2026 15:18:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yi Gu (Gerrit)

unread,
10:23 AM (9 hours ago) 10:23 AM
to Adem Derinel, Ken Buchanan, Chromium LUCI CQ, Kaan Icer, Christian Biesinger, AyeAye, feature-me...@chromium.org, derinel+wat...@google.com, yigu+...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org
Attention needed from Adem Derinel and Ken Buchanan

Yi Gu added 1 comment

Patchset-level comments
Yi Gu . unresolved

drive-by: do you also plan to enforce `mediation: required` when `UiMode: immediate` is used?

Open in Gerrit

Related details

Attention is currently required from:
  • Adem Derinel
  • Ken Buchanan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I71ef9472a320c0f64132851379193ef1aa5fc388
    Gerrit-Change-Number: 7491274
    Gerrit-PatchSet: 4
    Gerrit-Owner: Adem Derinel <der...@google.com>
    Gerrit-Reviewer: Adem Derinel <der...@google.com>
    Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Yi Gu <yi...@chromium.org>
    Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
    Gerrit-Attention: Adem Derinel <der...@google.com>
    Gerrit-Comment-Date: Mon, 19 Jan 2026 15:23:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Adem Derinel (Gerrit)

    unread,
    11:33 AM (8 hours ago) 11:33 AM
    to Yi Gu, Ken Buchanan, Chromium LUCI CQ, Kaan Icer, Christian Biesinger, AyeAye, feature-me...@chromium.org, derinel+wat...@google.com, yigu+...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org
    Attention needed from Ken Buchanan and Yi Gu

    Adem Derinel added 1 comment

    Patchset-level comments
    Yi Gu . unresolved

    drive-by: do you also plan to enforce `mediation: required` when `UiMode: immediate` is used?

    Adem Derinel

    We actually consider `mediation: "conditional"`.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ken Buchanan
    • Yi Gu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I71ef9472a320c0f64132851379193ef1aa5fc388
    Gerrit-Change-Number: 7491274
    Gerrit-PatchSet: 4
    Gerrit-Owner: Adem Derinel <der...@google.com>
    Gerrit-Reviewer: Adem Derinel <der...@google.com>
    Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Yi Gu <yi...@chromium.org>
    Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
    Gerrit-Attention: Yi Gu <yi...@chromium.org>
    Gerrit-Comment-Date: Mon, 19 Jan 2026 16:33:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Yi Gu <yi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ken Buchanan (Gerrit)

    unread,
    2:45 PM (5 hours ago) 2:45 PM
    to Adem Derinel, Yi Gu, Chromium LUCI CQ, Kaan Icer, Christian Biesinger, AyeAye, feature-me...@chromium.org, derinel+wat...@google.com, yigu+...@chromium.org, kinuko...@chromium.org, webauthn...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org
    Attention needed from Adem Derinel and Yi Gu

    Ken Buchanan added 1 comment

    File third_party/blink/renderer/platform/runtime_enabled_features.json5
    Line 5864, Patchset 4 (Latest): name: "WebAuthenticationUiMode",
    Ken Buchanan . unresolved

    Should we just get rid of this now?

    After this, Immediate is non-functional if this is turned off. Is there a reason to have separate flags for immediate and uiMode?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adem Derinel
    • Yi Gu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I71ef9472a320c0f64132851379193ef1aa5fc388
    Gerrit-Change-Number: 7491274
    Gerrit-PatchSet: 4
    Gerrit-Owner: Adem Derinel <der...@google.com>
    Gerrit-Reviewer: Adem Derinel <der...@google.com>
    Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Yi Gu <yi...@chromium.org>
    Gerrit-Attention: Adem Derinel <der...@google.com>
    Gerrit-Attention: Yi Gu <yi...@chromium.org>
    Gerrit-Comment-Date: Mon, 19 Jan 2026 19:44:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages