Add a missing return after a ReportBadMessage() in EncoderMetricsHandler [chromium/src : main]
0 views
Skip to first unread message
Daniel Cheng (Gerrit)
3:58 PM (4 hours ago) 3:58 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org
Attention needed from Xiaohan Wang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Xiaohan Wang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Wang (Gerrit)
5:42 PM (2 hours ago) 5:42 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org
Attention needed from Daniel Cheng
Xiaohan Wang voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
6:12 PM (1 hour ago) 6:12 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org
Daniel Cheng voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:15 PM (1 hour ago) 6:15 PM
to Daniel Cheng, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Add a missing return after a ReportBadMessage() in EncoderMetricsHandler
While it'd be nice to use the `mojo::Receiver`'s `ReportBadMessage()`
method, the plumbing to make that work here is probably not worth the
effort.
Bug: 498970530
Change-Id: Ib0cb51fc485b5ae90afa78bf2f04196f94f70f13
Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609523}
Files:
- M media/mojo/services/mojo_video_encoder_metrics_provider_service.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Xiaohan Wang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages