Ensure all ambisonics are considered DISCRETE [chromium/src : main]

0 views
Skip to first unread message

Syed AbuTalib (Gerrit)

unread,
Jan 20, 2026, 8:00:41 PM (6 hours ago) Jan 20
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Thomas Guilbert

Syed AbuTalib voted and added 1 comment

Votes added by Syed AbuTalib

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Syed AbuTalib . unresolved

Please do not submit until after histograms provide enough data.

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Guilbert
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d184afc5fd1867db887825f5dff16b3209d3f1a
Gerrit-Change-Number: 7500357
Gerrit-PatchSet: 2
Gerrit-Owner: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 01:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Guilbert (Gerrit)

unread,
Jan 20, 2026, 8:21:19 PM (6 hours ago) Jan 20
to Syed AbuTalib, Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Syed AbuTalib

Thomas Guilbert voted and added 1 comment

Votes added by Thomas Guilbert

Code-Review+1

1 comment

File media/ffmpeg/ffmpeg_common.cc
Line 912, Patchset 2 (Latest): return CHANNEL_LAYOUT_DISCRETE;
Thomas Guilbert . unresolved

We should keep the UMA around, and send a separate deprecation CL (probably when the UMA expires).

Open in Gerrit

Related details

Attention is currently required from:
  • Syed AbuTalib
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d184afc5fd1867db887825f5dff16b3209d3f1a
Gerrit-Change-Number: 7500357
Gerrit-PatchSet: 2
Gerrit-Owner: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Syed AbuTalib <low...@google.com>
Gerrit-Comment-Date: Wed, 21 Jan 2026 01:21:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Syed AbuTalib (Gerrit)

unread,
Jan 20, 2026, 8:34:48 PM (6 hours ago) Jan 20
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

Syed AbuTalib voted and added 1 comment

Votes added by Syed AbuTalib

Commit-Queue+0

1 comment

File media/ffmpeg/ffmpeg_common.cc
Line 912, Patchset 2: return CHANNEL_LAYOUT_DISCRETE;
Thomas Guilbert . resolved

We should keep the UMA around, and send a separate deprecation CL (probably when the UMA expires).

Syed AbuTalib

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d184afc5fd1867db887825f5dff16b3209d3f1a
Gerrit-Change-Number: 7500357
Gerrit-PatchSet: 3
Gerrit-Owner: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Syed AbuTalib <low...@google.com>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 01:34:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Guilbert <tgui...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages