[System Media Controls] Return early on failing to get timeline object [chromium/src : main]
0 views
Skip to first unread message
Tommy Steimel (Gerrit)
Jan 12, 2026, 4:22:42 PMJan 12
to Benjamin Keen, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Benjamin Keen
Tommy Steimel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Benjamin Keen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Jan 12, 2026, 4:33:30 PMJan 12
to Tommy Steimel, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Tommy Steimel
Benjamin Keen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tommy Steimel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Steimel (Gerrit)
Jan 12, 2026, 4:35:43 PMJan 12
to Benjamin Keen, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Tommy Steimel voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 12, 2026, 4:39:48 PMJan 12
to Tommy Steimel, Benjamin Keen, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[System Media Controls] Return early on failing to get timeline object
In `SystemMediaControlsWin::SetPosition()` we currently assume getting
ISystemMediaTransportControlsTimelineProperties is always successful,
but it seems this isn't always the case. This CL changes it to return
early if we fail to get
ISystemMediaTransportControlsTimelineProperties.
Bug: 389707030
Change-Id: I7181b314c62907a9560d6cecee8862d111989ac1
Commit-Queue: Tommy Steimel <ste...@chromium.org>
Reviewed-by: Benjamin Keen <bk...@google.com>
Cr-Commit-Position: refs/heads/main@{#1568037}
Files:
- M components/system_media_controls/win/system_media_controls_win.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Benjamin Keen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages