[System Media Controls] Return early on failing to get timeline object [chromium/src : main]

0 views
Skip to first unread message

Tommy Steimel (Gerrit)

unread,
Jan 12, 2026, 4:22:42 PMJan 12
to Benjamin Keen, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Benjamin Keen

Tommy Steimel added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tommy Steimel . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Keen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7181b314c62907a9560d6cecee8862d111989ac1
Gerrit-Change-Number: 7456171
Gerrit-PatchSet: 1
Gerrit-Owner: Tommy Steimel <ste...@chromium.org>
Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
Gerrit-Attention: Benjamin Keen <bk...@google.com>
Gerrit-Comment-Date: Mon, 12 Jan 2026 21:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Benjamin Keen (Gerrit)

unread,
Jan 12, 2026, 4:33:30 PMJan 12
to Tommy Steimel, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Tommy Steimel

Benjamin Keen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tommy Steimel
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7181b314c62907a9560d6cecee8862d111989ac1
    Gerrit-Change-Number: 7456171
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tommy Steimel <ste...@chromium.org>
    Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
    Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
    Gerrit-Attention: Tommy Steimel <ste...@chromium.org>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 21:33:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Tommy Steimel (Gerrit)

    unread,
    Jan 12, 2026, 4:35:43 PMJan 12
    to Benjamin Keen, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

    Tommy Steimel voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7181b314c62907a9560d6cecee8862d111989ac1
    Gerrit-Change-Number: 7456171
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tommy Steimel <ste...@chromium.org>
    Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
    Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 21:35:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 12, 2026, 4:39:48 PMJan 12
    to Tommy Steimel, Benjamin Keen, chromium...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [System Media Controls] Return early on failing to get timeline object

    In `SystemMediaControlsWin::SetPosition()` we currently assume getting
    ISystemMediaTransportControlsTimelineProperties is always successful,
    but it seems this isn't always the case. This CL changes it to return
    early if we fail to get
    ISystemMediaTransportControlsTimelineProperties.
    Bug: 389707030
    Change-Id: I7181b314c62907a9560d6cecee8862d111989ac1
    Commit-Queue: Tommy Steimel <ste...@chromium.org>
    Reviewed-by: Benjamin Keen <bk...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1568037}
    Files:
    • M components/system_media_controls/win/system_media_controls_win.cc
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Benjamin Keen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7181b314c62907a9560d6cecee8862d111989ac1
    Gerrit-Change-Number: 7456171
    Gerrit-PatchSet: 2
    Gerrit-Owner: Tommy Steimel <ste...@chromium.org>
    Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages