Fix unsafe buffer usage in vp9_uncompressed_header_parser_unittest.cc [chromium/src : main]
0 views
Skip to first unread message
Arthur Sonzogni (Gerrit)
Mar 11, 2026, 1:44:22 PMMar 11
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Arthur Sonzogni voted and added 2 comments![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Auto-Submit | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Arthur Sonzogni . resolved
This looks like a trivial patch. LGTM.
Eugene, could you please take a look?
File media/parsers/vp9_uncompressed_header_parser_unittest.cc
Line 7, Patchset 2 (Latest):
#include <type_traits>Arthur Sonzogni . resolved
Note: this is ~needed for the pre-existing `std::is_trivial`.
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Mar 11, 2026, 1:45:30 PMMar 11
to Arthur Sonzogni, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Arthur Sonzogni
Eugene Zemtsov voted![]( "Open in Gerrit")
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Mar 11, 2026, 1:58:33 PMMar 11
to Arthur Sonzogni, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Arthur Sonzogni
Eugene Zemtsov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Eugene Zemtsov . resolved
Arthur, it looks like you need to re-Auth
Related details
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Mar 11, 2026, 2:09:35 PMMar 11
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Arthur Sonzogni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 11, 2026, 3:51:53 PMMar 11
to Arthur Sonzogni, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Fix unsafe buffer usage in vp9_uncompressed_header_parser_unittest.cc
Replaced unsafe memcmp with base::byte_span_from_ref and span comparison
to fix unsafe buffer error(s).
Initial patchset generated by headless gemini-cli using:
//agents/prompts/projects/spanification/run.py
Fixed: 490869813
Change-Id: I6c8fdbbd083676348e9ec7eb647884468e65464a
Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1597932}
Files:
- M media/parsers/vp9_uncompressed_header_parser_unittest.cc
Change size: S
Delta: 1 file changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eugene Zemtsov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages