Remove superfluous callback.h includes from //content headers [chromium/src : main]

0 views
Skip to first unread message

Dmitry Gozman (Gerrit)

unread,
Nov 12, 2025, 4:43:02 PM (13 hours ago) Nov 12
to Lei Zhang, AyeAye, Arnaud Mandy, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, Hiroki Nakagawa, Peter Beverloo, Rijubrata Bhaumik, Wang, Wei4, Chromium LUCI CQ, alexmo...@chromium.org, blink-isola...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, feature-me...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, twifka...@chromium.org
Attention needed from Lei Zhang

Dmitry Gozman voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I12f1c35c3ded48cc6eec9fec674a9a510cbec6d1
Gerrit-Change-Number: 7139546
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 21:42:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Nov 12, 2025, 9:23:23 PM (8 hours ago) Nov 12
to Lei Zhang, Dmitry Gozman, AyeAye, Arnaud Mandy, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, Hiroki Nakagawa, Peter Beverloo, Rijubrata Bhaumik, Wang, Wei4, Chromium LUCI CQ, alexmo...@chromium.org, blink-isola...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, feature-me...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, twifka...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I12f1c35c3ded48cc6eec9fec674a9a510cbec6d1
Gerrit-Change-Number: 7139546
Gerrit-PatchSet: 3
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-Comment-Date: Thu, 13 Nov 2025 02:23:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 12, 2025, 9:26:29 PM (8 hours ago) Nov 12
to Lei Zhang, Dmitry Gozman, AyeAye, Arnaud Mandy, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, Hiroki Nakagawa, Peter Beverloo, Rijubrata Bhaumik, Wang, Wei4, alexmo...@chromium.org, blink-isola...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, feature-me...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org, twifka...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Remove superfluous callback.h includes from //content headers

Remove unused includes mostly found by heuristics in headers that do not
contain keywords like "Callback" or "Closure".
Bug: 40318405
Change-Id: I12f1c35c3ded48cc6eec9fec674a9a510cbec6d1
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Dmitry Gozman <dgo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544098}
Files:
  • M content/browser/background_fetch/background_fetch_registration_notifier.h
  • M content/browser/compute_pressure/pressure_service_for_frame.h
  • M content/browser/indexed_db/instance/leveldb/tombstone_sweeper.h
  • M content/browser/loader/subresource_proxying_url_loader_service.h
  • M content/browser/media/capture/sub_capture_target_id_web_contents_helper.h
  • M content/browser/media/cdm_storage_common.h
  • M content/browser/media/key_system_support_win.h
  • M content/browser/renderer_host/render_view_host_delegate.h
  • M content/browser/service_worker/service_worker_context_core_observer.h
  • M content/browser/service_worker/service_worker_info.h
  • M content/browser/service_worker/service_worker_process_manager.h
  • M content/browser/web_package/signed_exchange_devtools_proxy.h
  • M content/child/dwrite_font_proxy/dwrite_font_proxy_win.h
  • M content/public/browser/background_sync_registration.h
  • M content/public/browser/browser_main_parts.h
  • M content/public/browser/speech_recognition_manager.h
  • M content/public/common/zygote/zygote_handle.h
  • M content/public/renderer/v8_value_converter.h
  • M content/renderer/media/cast_renderer_client_factory.h
  • M content/renderer/mock_agent_scheduling_group.h
  • M content/test/did_commit_navigation_interceptor.h
  • M content/web_test/browser/web_test_bluetooth_adapter_provider.h
  • M content/web_test/browser/web_test_tracing_controller.h
Change size: S
Delta: 23 files changed, 1 insertion(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dmitry Gozman
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I12f1c35c3ded48cc6eec9fec674a9a510cbec6d1
Gerrit-Change-Number: 7139546
Gerrit-PatchSet: 4
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages